From patchwork Mon Dec 5 21:15:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ronald S. Bultje" X-Patchwork-Id: 1691 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.65.86 with SMTP id o83csp1846996vsa; Mon, 5 Dec 2016 13:28:28 -0800 (PST) X-Received: by 10.194.85.165 with SMTP id i5mr52116475wjz.147.1480973308164; Mon, 05 Dec 2016 13:28:28 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id qp9si16515071wjc.142.2016.12.05.13.28.27; Mon, 05 Dec 2016 13:28:28 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BDAE9689FDC; Mon, 5 Dec 2016 23:28:15 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qt0-f194.google.com (mail-qt0-f194.google.com [209.85.216.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2795B689D7B for ; Mon, 5 Dec 2016 23:28:09 +0200 (EET) Received: by mail-qt0-f194.google.com with SMTP id n34so37723792qtb.3 for ; Mon, 05 Dec 2016 13:28:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=F+s3eoVKUIjhwc5mCbSv8RQwCXbT6x7pKVjD0byjqYQ=; b=ImHSthLUPQ4Gg8xsZDu7GcSdap0zOzVmmGMrKYzx/Jk0bxSxaGx1ClqYCovA16+Ywh qcx8W7cYBfm5ETm8dSh9s1jDEX+811+Rawdq5/xpjt+S7ecoBJGK8b78mVLgI49fzwFn aIKUVwCzJyXclRjqMX+tG4iuwfP5ynWEiQ5gxYrJLzp09XrpPRKcMqN9kGtPhJteQ0Mv NQ2nVP6H/nFeHb+XU0F1aDd5zQwATU1Vsoj2efOKdffUoiRieRZMHcj3ZpaAvm/cV8B9 NIf5uVjJ/4vlUerxOwMQJRPmixHZwxj0C9SOY7gnptC5IJSe2DjQOy6oq7Z2CgSIuKmn FZTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=F+s3eoVKUIjhwc5mCbSv8RQwCXbT6x7pKVjD0byjqYQ=; b=kndLqkWH9xVyG0oGDooySu1RbeOxyYDSFz9CEAmg/jeUzgkmEOhYh3n1rGG4IQNM9B l5mQU2UuJO6hQWsTC8xX63YWGSfJHBALZkkmgXFJVn6yJXcFkNAiLcEi/pvuuFpquR0Z 5uyCALxvzri5IUk16X72t6lJmU4adfUkUrC/1QvspDHGaTiQsWOAv4cqlz1IoR7WAm7Y Vrj1BQ9UF7iYBtzNri62//fTjvHm5wn8a+kl2Co2CkpHMgkgg5Xo/mt+x30wWLuQO8ly EHqCoQywJWWVSqpxVDVAcBQSrg4SYs6t0lW5teI9XcSKE/cT1Sx8U5zSFzwl20by/5x8 tQmw== X-Gm-Message-State: AKaTC02jfdeeLnGxwJOzRUTvdExPW3qXYzqLOy6gNiEf0zDejURi0mR9OYunfi17NqmeQw== X-Received: by 10.200.51.119 with SMTP id u52mr52374292qta.226.1480972535330; Mon, 05 Dec 2016 13:15:35 -0800 (PST) Received: from localhost.localdomain ([65.206.95.146]) by smtp.gmail.com with ESMTPSA id 21sm10370356qkf.17.2016.12.05.13.15.34 (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 05 Dec 2016 13:15:34 -0800 (PST) From: "Ronald S. Bultje" To: ffmpeg-devel@ffmpeg.org Date: Mon, 5 Dec 2016 16:15:32 -0500 Message-Id: <1480972532-81245-1-git-send-email-rsbultje@gmail.com> X-Mailer: git-send-email 2.8.1 Subject: [FFmpeg-devel] [PATCH] checkasm/vp9: benchmark all sub-IDCTs (but not WHT or ADST). X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Ronald S. Bultje" MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" --- tests/checkasm/vp9dsp.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/tests/checkasm/vp9dsp.c b/tests/checkasm/vp9dsp.c index 441041c..f32b97c 100644 --- a/tests/checkasm/vp9dsp.c +++ b/tests/checkasm/vp9dsp.c @@ -331,15 +331,20 @@ static void check_itxfm(void) int n_txtps = tx < TX_32X32 ? N_TXFM_TYPES : 1; for (txtp = 0; txtp < n_txtps; txtp++) { - if (check_func(dsp.itxfm_add[tx][txtp], "vp9_inv_%s_%dx%d_add_%d", - tx == 4 ? "wht_wht" : txtp_types[txtp], sz, sz, - bit_depth)) { - randomize_buffers(); - ftx(coef, tx, txtp, sz, bit_depth); - - for (sub = (txtp == 0) ? 1 : 2; sub <= sz; sub <<= 1) { + // skip testing sub-IDCTs for WHT or ADST since they don't + // implement it in any of the SIMD functions. If they do, + // consider changing this to ensure we have complete test + // coverage + for (sub = (txtp == 0 && tx < 4) ? 1 : sz; sub <= sz; sub <<= 1) { + if (check_func(dsp.itxfm_add[tx][txtp], + "vp9_inv_%s_%dx%d_sub%d_add_%d", + tx == 4 ? "wht_wht" : txtp_types[txtp], + sz, sz, sub, bit_depth)) { int eob; + randomize_buffers(); + ftx(coef, tx, txtp, sz, bit_depth); + if (sub < sz) { eob = copy_subcoefs(subcoef0, coef, tx, txtp, sz, sub, bit_depth); @@ -357,8 +362,9 @@ static void check_itxfm(void) !iszero(subcoef0, sz * sz * SIZEOF_COEF) || !iszero(subcoef1, sz * sz * SIZEOF_COEF)) fail(); + + bench_new(dst, sz * SIZEOF_PIXEL, coef, eob); } - bench_new(dst, sz * SIZEOF_PIXEL, coef, sz * sz); } } }