From patchwork Mon Jan 9 22:15:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Storsj=C3=B6?= X-Patchwork-Id: 2161 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.89.21 with SMTP id n21csp7257816vsb; Mon, 9 Jan 2017 14:22:30 -0800 (PST) X-Received: by 10.28.164.196 with SMTP id n187mr5397356wme.44.1484000550750; Mon, 09 Jan 2017 14:22:30 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id ri10si66103359wjb.215.2017.01.09.14.22.30; Mon, 09 Jan 2017 14:22:30 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@martin-st.20150623.gappssmtp.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1A63B68A261; Tue, 10 Jan 2017 00:22:21 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf0-f65.google.com (mail-lf0-f65.google.com [209.85.215.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 839C168A218 for ; Tue, 10 Jan 2017 00:22:14 +0200 (EET) Received: by mail-lf0-f65.google.com with SMTP id q89so6926658lfi.1 for ; Mon, 09 Jan 2017 14:22:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=0rdFF61n+WGGaU8Xbuy66cAaRQ4Pij81HnsFlsT74A8=; b=SYOEodPiFyYrACuGToiW3oHpvNxFXyfId1kcuH/fQk6dE39cjyd/Vy994unEkF8Vqh d1PgT1gHQFwLYJStTt5I3lRJdYn/IsU2Ds5BsdTMV9xXy95xZhBzWaBp+nH3Zy+WzoCp rP09K6EK2K33fsLTXrmIbcI6P+S9JWBZth4USnAYMlmIh2cKc9S2AZMzuBIQ03yObwM1 QMXMYv+RHDlfJyCskwfkXoevrE/ohWMmg82e8lPseeo00k180xN0TnjWpDUsr/ByDk0N 26wQqYxElx/UxNcCaRQSPdZ7tHhDGfbz0zdPjUW7qBNq02wNbZ/OEAJacz5XZv6lZW3X acbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=0rdFF61n+WGGaU8Xbuy66cAaRQ4Pij81HnsFlsT74A8=; b=HmdCpO/9H+wjRUQJSCN9cOdbLO9X0DSIfgUV9iDFcj21GBxlZo1i33loKtd2bSXQxS 4mIKCfM673oIASD0FmOrvea07F/aOXWW0lDnRiDp8rVRqV7bnYop+zZXa79V0EpA9gfP KhjVVHoaoqNUSqdIWy19kyojX7kGNFybfDHKpkCM6n/NCA1bXmo1vyqaSJphb4mYeRjq a25Fxk4wqipstIQ8Mu8hsfiGdlBR8zkZOF3rN2GFv202C8seCJosB4cWDpQ+Objndv1b 1mVFYcOpJKbKmiDtDn46um6q1EaiNDeRjp6gC5xQqMkxyX0TJHsz/fHkOUnWsjYmaFcp RC8g== X-Gm-Message-State: AIkVDXJbUsdlE3zT0FZKOkxoea70DYD7uXo/oTJiZxrYsq455n6WC09buK8pH5AFpb6UIQ== X-Received: by 10.25.125.132 with SMTP id y126mr31744665lfc.86.1484000124117; Mon, 09 Jan 2017 14:15:24 -0800 (PST) Received: from localhost.localdomain ([2001:470:28:852:a9ed:5432:636c:1053]) by smtp.gmail.com with ESMTPSA id f25sm1358538lji.26.2017.01.09.14.15.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 09 Jan 2017 14:15:23 -0800 (PST) From: =?UTF-8?q?Martin=20Storsj=C3=B6?= To: ffmpeg-devel@ffmpeg.org Date: Tue, 10 Jan 2017 00:15:10 +0200 Message-Id: <1484000119-4959-4-git-send-email-martin@martin.st> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1484000119-4959-1-git-send-email-martin@martin.st> References: <1484000119-4959-1-git-send-email-martin@martin.st> Subject: [FFmpeg-devel] [PATCH 04/13] aarch64: vp9itxfm: Use w3 instead of x3 for the int eob parameter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" The clobbering tests in checkasm are only invoked when testing correctness, so this bug didn't show up when benchmarking the dc-only version. This is cherrypicked from libav commit 4d960a11855f4212eb3a4e470ce890db7f01df29. --- libavcodec/aarch64/vp9itxfm_neon.S | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/aarch64/vp9itxfm_neon.S b/libavcodec/aarch64/vp9itxfm_neon.S index 7ce3116..3535c7b 100644 --- a/libavcodec/aarch64/vp9itxfm_neon.S +++ b/libavcodec/aarch64/vp9itxfm_neon.S @@ -204,7 +204,7 @@ function ff_vp9_\txfm1\()_\txfm2\()_4x4_add_neon, export=1 movi v31.8h, #0 .ifc \txfm1\()_\txfm2,idct_idct - cmp x3, #1 + cmp w3, #1 b.ne 1f // DC-only for idct/idct ld1r {v2.4h}, [x2] @@ -344,7 +344,7 @@ function ff_vp9_\txfm1\()_\txfm2\()_8x8_add_neon, export=1 movi v5.16b, #0 .ifc \txfm1\()_\txfm2,idct_idct - cmp x3, #1 + cmp w3, #1 b.ne 1f // DC-only for idct/idct ld1r {v2.4h}, [x2] @@ -722,7 +722,7 @@ itxfm16_1d_funcs iadst .macro itxfm_func16x16 txfm1, txfm2 function ff_vp9_\txfm1\()_\txfm2\()_16x16_add_neon, export=1 .ifc \txfm1\()_\txfm2,idct_idct - cmp x3, #1 + cmp w3, #1 b.eq idct16x16_dc_add_neon .endif mov x15, x30 @@ -1074,7 +1074,7 @@ function idct32_1d_8x32_pass2_neon endfunc function ff_vp9_idct_idct_32x32_add_neon, export=1 - cmp x3, #1 + cmp w3, #1 b.eq idct32x32_dc_add_neon movrel x10, idct_coeffs