From patchwork Wed Mar 8 10:00:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Storsj=C3=B6?= X-Patchwork-Id: 2827 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.50.79 with SMTP id y76csp955605vsy; Wed, 8 Mar 2017 02:09:46 -0800 (PST) X-Received: by 10.223.176.143 with SMTP id i15mr4732318wra.136.1488967785985; Wed, 08 Mar 2017 02:09:45 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id b190si22569929wmd.47.2017.03.08.02.09.45; Wed, 08 Mar 2017 02:09:45 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@martin-st.20150623.gappssmtp.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BE143688332; Wed, 8 Mar 2017 12:09:23 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf0-f65.google.com (mail-lf0-f65.google.com [209.85.215.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 595B6688305 for ; Wed, 8 Mar 2017 12:09:22 +0200 (EET) Received: by mail-lf0-f65.google.com with SMTP id r36so2021937lfi.0 for ; Wed, 08 Mar 2017 02:09:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=KM3tNePOZhcea4Od2Q5439dPTXEznWXMrZs5ldADPHk=; b=q1iVDYSzG93PC8kHMTfS4/JGEqDVDlYdj4u7MXodNETMN1hO8djE2CUsCGj0RVyCp5 X9Bi6CuFggMoIBTkgyqEXLYIb8NwEqxk7xFc5zwUUP5TDD0wzsH70bzwgO0HWpcBVbVZ PmAenolWq5Tc+2UJztFr+AQGJZmHPqtZtezlc2fq5CN2dSVVDeiJnrhzaF4wz4CcKWmv uGCQP/lqQD4YXINK+byaMtagTuQEK7hu0SukSoxPHgjJIMHwGiSmjmm4R0yZUdiTS1sq ZxO0nqcZJoY4c7dME336F3VCLJqgXhFdi1AJeMitMvvUyLzt9fX6iK2F8BLpIaox5+UH Ce0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=KM3tNePOZhcea4Od2Q5439dPTXEznWXMrZs5ldADPHk=; b=hK7H16sLIOP+3fbLvw7Z4UqaFvl50aJIxemi9LzP1CGg36SohAYAONcthOEwkhQ7+w g2So5axLgAAbTn7iFvduRzlHJGrjufsF5gYsfY4MvIcqgUQcZsRQgmqhZufCK8KO/QaJ 6E89Xvupj4YpoWnmDG8wJZiuWRwMRrLC/Rm908twz+DJEgBc3Im3htLl7FWVJoJ1vwbw gDmn3ZsJgVLoS9SVWnrl09eA1EB50EKb8de3vglwCXXSf3EeVAqRMX7d2S7BYE6PAqgB FPDDF+9zj9ptpVCrxY/eeQ3ZEbsOL1403wt3aInbbHfO0XRa/dccHUdwCVzmZlp2iWgy LS9g== X-Gm-Message-State: AMke39nINgNjfmZ0I8HtqPCX93jy8GEstaMKbDMGlSmp6BmkTS+7YTRCf/IR3N6/fBaTQw== X-Received: by 10.46.88.29 with SMTP id m29mr1834333ljb.91.1488967285280; Wed, 08 Mar 2017 02:01:25 -0800 (PST) Received: from localhost.localdomain ([2001:470:28:852:7d47:68e:13e8:4933]) by smtp.gmail.com with ESMTPSA id m127sm513064lfg.58.2017.03.08.02.01.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 08 Mar 2017 02:01:24 -0800 (PST) From: =?UTF-8?q?Martin=20Storsj=C3=B6?= To: ffmpeg-devel@ffmpeg.org Date: Wed, 8 Mar 2017 12:00:51 +0200 Message-Id: <1488967274-8143-11-git-send-email-martin@martin.st> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1488967274-8143-1-git-send-email-martin@martin.st> References: <1488967274-8143-1-git-send-email-martin@martin.st> Subject: [FFmpeg-devel] [PATCH 11/34] aarch64: vp9itxfm: Use a single lane ld1 instead of ld1r where possible X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" The ld1r is a leftover from the arm version, where this trick is beneficial on some cores. Use a single-lane load where we don't need the semantics of ld1r. This is cherrypicked from libav commit ed8d293306e12c9b79022d37d39f48825ce7f2fa. --- libavcodec/aarch64/vp9itxfm_neon.S | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/aarch64/vp9itxfm_neon.S b/libavcodec/aarch64/vp9itxfm_neon.S index df178d2..e42cc2d 100644 --- a/libavcodec/aarch64/vp9itxfm_neon.S +++ b/libavcodec/aarch64/vp9itxfm_neon.S @@ -255,7 +255,7 @@ function ff_vp9_\txfm1\()_\txfm2\()_4x4_add_neon, export=1 cmp w3, #1 b.ne 1f // DC-only for idct/idct - ld1r {v2.4h}, [x2] + ld1 {v2.h}[0], [x2] smull v2.4s, v2.4h, v0.h[0] rshrn v2.4h, v2.4s, #14 smull v2.4s, v2.4h, v0.h[0] @@ -287,8 +287,8 @@ function ff_vp9_\txfm1\()_\txfm2\()_4x4_add_neon, export=1 \txfm2\()4 v4, v5, v6, v7 2: - ld1r {v0.2s}, [x0], x1 - ld1r {v1.2s}, [x0], x1 + ld1 {v0.s}[0], [x0], x1 + ld1 {v1.s}[0], [x0], x1 .ifnc \txfm1,iwht srshr v4.4h, v4.4h, #4 srshr v5.4h, v5.4h, #4 @@ -297,8 +297,8 @@ function ff_vp9_\txfm1\()_\txfm2\()_4x4_add_neon, export=1 .endif uaddw v4.8h, v4.8h, v0.8b uaddw v5.8h, v5.8h, v1.8b - ld1r {v2.2s}, [x0], x1 - ld1r {v3.2s}, [x0], x1 + ld1 {v2.s}[0], [x0], x1 + ld1 {v3.s}[0], [x0], x1 sqxtun v0.8b, v4.8h sqxtun v1.8b, v5.8h sub x0, x0, x1, lsl #2 @@ -394,7 +394,7 @@ function ff_vp9_\txfm1\()_\txfm2\()_8x8_add_neon, export=1 cmp w3, #1 b.ne 1f // DC-only for idct/idct - ld1r {v2.4h}, [x2] + ld1 {v2.h}[0], [x2] smull v2.4s, v2.4h, v0.h[0] rshrn v2.4h, v2.4s, #14 smull v2.4s, v2.4h, v0.h[0] @@ -485,7 +485,7 @@ function idct16x16_dc_add_neon movi v1.4h, #0 - ld1r {v2.4h}, [x2] + ld1 {v2.h}[0], [x2] smull v2.4s, v2.4h, v0.h[0] rshrn v2.4h, v2.4s, #14 smull v2.4s, v2.4h, v0.h[0] @@ -1044,7 +1044,7 @@ function idct32x32_dc_add_neon movi v1.4h, #0 - ld1r {v2.4h}, [x2] + ld1 {v2.h}[0], [x2] smull v2.4s, v2.4h, v0.h[0] rshrn v2.4h, v2.4s, #14 smull v2.4s, v2.4h, v0.h[0]