| Message ID | 1490926482-8711-1-git-send-email-thomastdt@googlemail.com |
|---|---|
| State | Superseded |
| Headers | show |
On Thu, Mar 30, 2017 at 07:14:42PM -0700, Thomas Turner wrote: > Reference found at: http://bit.ly/2ogQygb > > Signed-off-by: Thomas Turner <thomastdt@googlemail.com> > --- > tests/fate/filter-video.mak | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak > index b067cc1..a154dd2 100644 > --- a/tests/fate/filter-video.mak > +++ b/tests/fate/filter-video.mak > @@ -1,3 +1,10 @@ > +FATE_FILTER_SAMPLES-$(call ALLYES, SMJPEG_DEMUXER MJPEG_DECODER PERMS_FILTER OWDENOISE_FILTER) += fate-filter-owdenoise-sample > +fate-filter-owdenoise-sample: CMD = ffmpeg -idct simple -i $(TARGET_SAMPLES)/smjpeg/scenwin.mjpg -vf "trim=duration=1,perms=random,owdenoise=10:20:20:enable=not(between(t\,2\,3))" -an -f rawvideo - if i change this to enable=not(between(t\,4\,5)) it still passes, so this part of the filter is not tested thats likely because of the duration being 1, the enable part needs to be within the duration [...]
On Fri, Mar 31, 2017 at 2:49 AM, Michael Niedermayer <michael@niedermayer.cc > wrote: > On Thu, Mar 30, 2017 at 07:14:42PM -0700, Thomas Turner wrote: > > Reference found at: http://bit.ly/2ogQygb > > > > Signed-off-by: Thomas Turner <thomastdt@googlemail.com> > > --- > > tests/fate/filter-video.mak | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak > > index b067cc1..a154dd2 100644 > > --- a/tests/fate/filter-video.mak > > +++ b/tests/fate/filter-video.mak > > @@ -1,3 +1,10 @@ > > +FATE_FILTER_SAMPLES-$(call ALLYES, SMJPEG_DEMUXER MJPEG_DECODER > PERMS_FILTER OWDENOISE_FILTER) += fate-filter-owdenoise-sample > > > +fate-filter-owdenoise-sample: CMD = ffmpeg -idct simple -i > $(TARGET_SAMPLES)/smjpeg/scenwin.mjpg -vf "trim=duration=1,perms=random, > owdenoise=10:20:20:enable=not(between(t\,2\,3))" -an -f rawvideo - > > if i change this to > enable=not(between(t\,4\,5)) > it still passes, so this part of the filter is not tested > thats likely because of the duration being 1, the enable part needs > to be within the duration > > Okay, will send in patch with updated reference file. Though, the reference file will be approx. 3MB > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Complexity theory is the science of finding the exact solution to an > approximation. Benchmarking OTOH is finding an approximation of the exact > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >
On Sun, Apr 02, 2017 at 02:09:20PM -0700, Thomas Turner wrote: > On Fri, Mar 31, 2017 at 2:49 AM, Michael Niedermayer <michael@niedermayer.cc > > wrote: > > > On Thu, Mar 30, 2017 at 07:14:42PM -0700, Thomas Turner wrote: > > > Reference found at: http://bit.ly/2ogQygb > > > > > > Signed-off-by: Thomas Turner <thomastdt@googlemail.com> > > > --- > > > tests/fate/filter-video.mak | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak > > > index b067cc1..a154dd2 100644 > > > --- a/tests/fate/filter-video.mak > > > +++ b/tests/fate/filter-video.mak > > > @@ -1,3 +1,10 @@ > > > +FATE_FILTER_SAMPLES-$(call ALLYES, SMJPEG_DEMUXER MJPEG_DECODER > > PERMS_FILTER OWDENOISE_FILTER) += fate-filter-owdenoise-sample > > > > > +fate-filter-owdenoise-sample: CMD = ffmpeg -idct simple -i > > $(TARGET_SAMPLES)/smjpeg/scenwin.mjpg -vf "trim=duration=1,perms=random, > > owdenoise=10:20:20:enable=not(between(t\,2\,3))" -an -f rawvideo - > > > > if i change this to > > enable=not(between(t\,4\,5)) > > > it still passes, so this part of the filter is not tested > > thats likely because of the duration being 1, the enable part needs > > to be within the duration > > > > Okay, will send in patch with updated reference file. Though, the > reference file will be approx. 3MB you can use values less than 1 in not(between(t\,2\,3)) like 0.2 That way it should work with a smaller reference i didnt try though, please tell me if it does not work thx [...]
it works, i'll send in patch with smaller reference On Sun, Apr 2, 2017 at 2:56 PM, Michael Niedermayer <michael@niedermayer.cc> wrote: > On Sun, Apr 02, 2017 at 02:09:20PM -0700, Thomas Turner wrote: > > On Fri, Mar 31, 2017 at 2:49 AM, Michael Niedermayer > <michael@niedermayer.cc > > > wrote: > > > > > On Thu, Mar 30, 2017 at 07:14:42PM -0700, Thomas Turner wrote: > > > > Reference found at: http://bit.ly/2ogQygb > > > > > > > > Signed-off-by: Thomas Turner <thomastdt@googlemail.com> > > > > --- > > > > tests/fate/filter-video.mak | 7 +++++++ > > > > 1 file changed, 7 insertions(+) > > > > > > > > diff --git a/tests/fate/filter-video.mak > b/tests/fate/filter-video.mak > > > > index b067cc1..a154dd2 100644 > > > > --- a/tests/fate/filter-video.mak > > > > +++ b/tests/fate/filter-video.mak > > > > @@ -1,3 +1,10 @@ > > > > +FATE_FILTER_SAMPLES-$(call ALLYES, SMJPEG_DEMUXER MJPEG_DECODER > > > PERMS_FILTER OWDENOISE_FILTER) += fate-filter-owdenoise-sample > > > > > > > +fate-filter-owdenoise-sample: CMD = ffmpeg -idct simple -i > > > $(TARGET_SAMPLES)/smjpeg/scenwin.mjpg -vf > "trim=duration=1,perms=random, > > > owdenoise=10:20:20:enable=not(between(t\,2\,3))" -an -f rawvideo - > > > > > > if i change this to > > > enable=not(between(t\,4\,5)) > > > > > it still passes, so this part of the filter is not tested > > > thats likely because of the duration being 1, the enable part needs > > > to be within the duration > > > > > > Okay, will send in patch with updated reference file. Though, the > > reference file will be approx. 3MB > > you can use values less than 1 in not(between(t\,2\,3)) > like 0.2 > > That way it should work with a smaller reference > i didnt try though, please tell me if it does not work > > thx > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Complexity theory is the science of finding the exact solution to an > approximation. Benchmarking OTOH is finding an approximation of the exact > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >
diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak index b067cc1..a154dd2 100644 --- a/tests/fate/filter-video.mak +++ b/tests/fate/filter-video.mak @@ -1,3 +1,10 @@ +FATE_FILTER_SAMPLES-$(call ALLYES, SMJPEG_DEMUXER MJPEG_DECODER PERMS_FILTER OWDENOISE_FILTER) += fate-filter-owdenoise-sample +fate-filter-owdenoise-sample: CMD = ffmpeg -idct simple -i $(TARGET_SAMPLES)/smjpeg/scenwin.mjpg -vf "trim=duration=1,perms=random,owdenoise=10:20:20:enable=not(between(t\,2\,3))" -an -f rawvideo - +fate-filter-owdenoise-sample: REF = $(TARGET_SAMPLES)/filter-reference/owdenoise-scenwin.raw +fate-filter-owdenoise-sample: CMP_TARGET = 1 +fate-filter-owdenoise-sample: FUZZ = 3539 +fate-filter-owdenoise-sample: CMP = oneoff + FATE_FILTER_SAMPLES-$(call ALLYES, PERMS_FILTER DELOGO_FILTER RM_DEMUXER RV30_DECODER) += fate-filter-delogo fate-filter-delogo: CMD = framecrc -i $(TARGET_SAMPLES)/real/rv30.rm -vf perms=random,delogo=show=0:x=290:y=25:w=26:h=16 -an
Reference found at: http://bit.ly/2ogQygb Signed-off-by: Thomas Turner <thomastdt@googlemail.com> --- tests/fate/filter-video.mak | 7 +++++++ 1 file changed, 7 insertions(+)