diff mbox

[FFmpeg-devel,1/6] idct_arm: remove use of ff_put/add_pixels_clamped function pointer.

Message ID 1491324498-26655-1-git-send-email-rsbultje@gmail.com
State Superseded
Headers show

Commit Message

Ronald S. Bultje April 4, 2017, 4:48 p.m. UTC 
Instead, hardcode the use of the _arm implementation of this function.
Since there's separate implementations of idct{,_put,_add} for neon,
this has no practical effect on performance.
---
 libavcodec/arm/idctdsp_init_arm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Michael Niedermayer April 4, 2017, 9:18 p.m. UTC | #1 
On Tue, Apr 04, 2017 at 12:48:13PM -0400, Ronald S. Bultje wrote:
> Instead, hardcode the use of the _arm implementation of this function.
> Since there's separate implementations of idct{,_put,_add} for neon,
> this has no practical effect on performance.
> ---
>  libavcodec/arm/idctdsp_init_arm.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

fails to build here

src/libavcodec/arm/idctdsp_init_arm.c: In function ‘j_rev_dct_arm_put’:
src/libavcodec/arm/idctdsp_init_arm.c:42:5: error: implicit declaration of function ‘ff_put_pixels_clamped_arm’
make: *** [libavcodec/arm/idctdsp_init_arm.o] Error 1


[...]
Ronald S. Bultje April 4, 2017, 9:47 p.m. UTC | #2 
Hi,

On Tue, Apr 4, 2017 at 5:18 PM, Michael Niedermayer <michael@niedermayer.cc>
wrote:

> On Tue, Apr 04, 2017 at 12:48:13PM -0400, Ronald S. Bultje wrote:
> > Instead, hardcode the use of the _arm implementation of this function.
> > Since there's separate implementations of idct{,_put,_add} for neon,
> > this has no practical effect on performance.
> > ---
> >  libavcodec/arm/idctdsp_init_arm.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
>
> fails to build here
>
> src/libavcodec/arm/idctdsp_init_arm.c: In function ‘j_rev_dct_arm_put’:
> src/libavcodec/arm/idctdsp_init_arm.c:42:5: error: implicit declaration
> of function ‘ff_put_pixels_clamped_arm’
> make: *** [libavcodec/arm/idctdsp_init_arm.o] Error 1


Crap I misread the code. New version sent that I (compile-)tested.

Ronald
diff mbox

Patch

diff --git a/libavcodec/arm/idctdsp_init_arm.c b/libavcodec/arm/idctdsp_init_arm.c
index 43782b2..b5c3507 100644
--- a/libavcodec/arm/idctdsp_init_arm.c
+++ b/libavcodec/arm/idctdsp_init_arm.c
@@ -39,28 +39,28 @@  static void j_rev_dct_arm_put(uint8_t *dest, ptrdiff_t line_size,
                               int16_t *block)
 {
     ff_j_rev_dct_arm(block);
-    ff_put_pixels_clamped(block, dest, line_size);
+    ff_put_pixels_clamped_arm(block, dest, line_size);
 }
 
 static void j_rev_dct_arm_add(uint8_t *dest, ptrdiff_t line_size,
                               int16_t *block)
 {
     ff_j_rev_dct_arm(block);
-    ff_add_pixels_clamped(block, dest, line_size);
+    ff_add_pixels_clamped_arm(block, dest, line_size);
 }
 
 static void simple_idct_arm_put(uint8_t *dest, ptrdiff_t line_size,
                                 int16_t *block)
 {
     ff_simple_idct_arm(block);
-    ff_put_pixels_clamped(block, dest, line_size);
+    ff_put_pixels_clamped_arm(block, dest, line_size);
 }
 
 static void simple_idct_arm_add(uint8_t *dest, ptrdiff_t line_size,
                                 int16_t *block)
 {
     ff_simple_idct_arm(block);
-    ff_add_pixels_clamped(block, dest, line_size);
+    ff_add_pixels_clamped_arm(block, dest, line_size);
 }
 
 av_cold void ff_idctdsp_init_arm(IDCTDSPContext *c, AVCodecContext *avctx,