From patchwork Tue Apr 4 21:47:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ronald S. Bultje" X-Patchwork-Id: 3293 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.44.195 with SMTP id s186csp378983vss; Tue, 4 Apr 2017 14:47:22 -0700 (PDT) X-Received: by 10.223.179.13 with SMTP id j13mr22025021wrd.148.1491342442769; Tue, 04 Apr 2017 14:47:22 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id e24si26244601wra.213.2017.04.04.14.47.22; Tue, 04 Apr 2017 14:47:22 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2571068826D; Wed, 5 Apr 2017 00:47:17 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qt0-f181.google.com (mail-qt0-f181.google.com [209.85.216.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5C0B26808B7 for ; Wed, 5 Apr 2017 00:47:11 +0300 (EEST) Received: by mail-qt0-f181.google.com with SMTP id i34so151081531qtc.0 for ; Tue, 04 Apr 2017 14:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gd2dDd5v/SEXBNFaKkywVjPGeHC8aKUPpl+W1qC6E3A=; b=NyXoNURq3w4BvvMRy4Z0wdbKtDYVbt2Aaueilpu5TsBv/eeREIe1GAiB6oqRIvsMk+ 1gemWl+mAxMdXGP7NrzO/ipRGP05m+W9EOQ3g6jV0Jx15adza6Bypj4JT5UUKQdcc2RN AX0L6ssU8gwlr0QdvFgcAIk37SeB1fkOablagBv1IMm/qnwiSI8Ih6vAmWgJycTfYjyv yLH28sin/mJl8i1oWXLoeVUCMIYm3rkJUcv8iY4oJIJ+H2qHRcZ9feCUCFgQKHKRwrCW bgDmVApmuX1zUpjlYTzVwwfL1SliHnqUoG4JAw0jGqR2rBvo2+mFpvvzHCcvJfhrOpB0 fh0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gd2dDd5v/SEXBNFaKkywVjPGeHC8aKUPpl+W1qC6E3A=; b=W1AwPjO2qKBRsYnW09+CQxZwlWL/pKBguKQsPBGImpZ3Gmmgbauvxm599pKXzbVtec 8Z20LrxBF+tbKdbLHkyWlqFowK9f0HS+8bLW3FlQue0pMG4OeYz31rXEJQ3W5AgK3L6f GTO7mRHJs9wRV2BMo5RJhZ6b7aRnSvBcDDF2Kzpe4LnAiZ0xXGfRZ3U7LZTTNucWOod5 WFmOvDtEcWpO4jrpoHEFH+kfofv/tZdmgzUNTI73BP4Xo5La1+n1RqzjJjYdMr088jK9 LYyaUh0LKepizX9l2RSmSAiQdY39ZxAJj1mJ3tBknryV+Hq+iGWjl0yFLJK1uTlfeQ/Q UP4A== X-Gm-Message-State: AFeK/H2TWYqu/iAY5kjpsmlD+As/G8FDyOR4RzI+uMMWDfVK8W9gSnOIsYg0sA6QhD54Uw== X-Received: by 10.237.42.194 with SMTP id t60mr27970799qtd.269.1491342432096; Tue, 04 Apr 2017 14:47:12 -0700 (PDT) Received: from localhost.localdomain ([65.206.95.146]) by smtp.gmail.com with ESMTPSA id k133sm6048166qke.25.2017.04.04.14.47.10 (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 04 Apr 2017 14:47:10 -0700 (PDT) From: "Ronald S. Bultje" To: ffmpeg-devel@ffmpeg.org Date: Tue, 4 Apr 2017 17:47:08 -0400 Message-Id: <1491342428-28888-1-git-send-email-rsbultje@gmail.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1491324498-26655-1-git-send-email-rsbultje@gmail.com> References: <1491324498-26655-1-git-send-email-rsbultje@gmail.com> Subject: [FFmpeg-devel] [PATCH] idct_arm: remove use of ff_put/add_pixels_clamped function pointer. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Ronald S. Bultje" MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Instead, hardcode the use of the _arm implementation of add_pixels, and use the C version for put_pixels (as no arm-optimized version exists). Since there's separate implementations of idct{,_put,_add} for neon, this has no practical impact on performance. --- libavcodec/arm/idctdsp_init_arm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/arm/idctdsp_init_arm.c b/libavcodec/arm/idctdsp_init_arm.c index 43782b2..ebc90e4 100644 --- a/libavcodec/arm/idctdsp_init_arm.c +++ b/libavcodec/arm/idctdsp_init_arm.c @@ -39,28 +39,28 @@ static void j_rev_dct_arm_put(uint8_t *dest, ptrdiff_t line_size, int16_t *block) { ff_j_rev_dct_arm(block); - ff_put_pixels_clamped(block, dest, line_size); + ff_put_pixels_clamped_c(block, dest, line_size); } static void j_rev_dct_arm_add(uint8_t *dest, ptrdiff_t line_size, int16_t *block) { ff_j_rev_dct_arm(block); - ff_add_pixels_clamped(block, dest, line_size); + ff_add_pixels_clamped_arm(block, dest, line_size); } static void simple_idct_arm_put(uint8_t *dest, ptrdiff_t line_size, int16_t *block) { ff_simple_idct_arm(block); - ff_put_pixels_clamped(block, dest, line_size); + ff_put_pixels_clamped_c(block, dest, line_size); } static void simple_idct_arm_add(uint8_t *dest, ptrdiff_t line_size, int16_t *block) { ff_simple_idct_arm(block); - ff_add_pixels_clamped(block, dest, line_size); + ff_add_pixels_clamped_arm(block, dest, line_size); } av_cold void ff_idctdsp_init_arm(IDCTDSPContext *c, AVCodecContext *avctx,