diff mbox

[FFmpeg-devel] configure: require pkg-config for libvmaf

Message ID 1500634119-28731-1-git-send-email-ashk43712@gmail.com
State Superseded
Headers

Commit Message

Ashish Singh July 21, 2017, 10:48 a.m. UTC 
From: Ashish Singh <ashk43712@gmail.com>

Hi, libvmaf now has a pkg-config file. This patch makes libvmaf filter link to
pkg-config of libvmaf.

Signed-off-by: Ashish Singh <ashk43712@gmail.com>
---
 configure | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Ronald S. Bultje Aug. 1, 2017, 1:45 p.m. UTC | #1 
Hi,

On Fri, Jul 21, 2017 at 6:48 AM, Ashish Pratap Singh <ashk43712@gmail.com>
wrote:

> From: Ashish Singh <ashk43712@gmail.com>
>
> Hi, libvmaf now has a pkg-config file. This patch makes libvmaf filter
> link to
> pkg-config of libvmaf.


"This patch makes the libvmaf filter use pkg-config to detect and link to
libvmaf."

I think?

Ronald
Ashish Singh Aug. 1, 2017, 2:59 p.m. UTC | #2 
Hi,

On Aug 1, 2017 7:15 PM, "Ronald S. Bultje" <rsbultje@gmail.com> wrote:

Hi,

On Fri, Jul 21, 2017 at 6:48 AM, Ashish Pratap Singh <ashk43712@gmail.com>
wrote:

> From: Ashish Singh <ashk43712@gmail.com>
>
> Hi, libvmaf now has a pkg-config file. This patch makes libvmaf filter
> link to
> pkg-config of libvmaf.


"This patch makes the libvmaf filter use pkg-config to detect and link to
libvmaf."

I think?

Oh yes, correct. Sorry for the bad sentence.


Ronald
diff mbox

Patch

diff --git a/configure b/configure
index 57694f3..aa8a785 100755
--- a/configure
+++ b/configure
@@ -5848,8 +5848,7 @@  enabled libtwolame        && require libtwolame twolame.h twolame_init -ltwolame
                                die "ERROR: libtwolame must be installed and version must be >= 0.3.10"; }
 enabled libv4l2           && require_pkg_config libv4l2 libv4l2.h v4l2_ioctl
 enabled libvidstab        && require_pkg_config "vidstab >= 0.98" vid.stab/libvidstab.h vsMotionDetectInit
-enabled libvmaf           && { check_lib libvmaf "libvmaf.h" "compute_vmaf" -lvmaf -lstdc++ -lpthread -lm ||
-                               die "ERROR: libvmaf must be installed"; }
+enabled libvmaf           && require_pkg_config libvmaf libvmaf.h compute_vmaf
 enabled libvo_amrwbenc    && require libvo_amrwbenc vo-amrwbenc/enc_if.h E_IF_init -lvo-amrwbenc
 enabled libvorbis         && require libvorbis vorbis/vorbisenc.h vorbis_info_init -lvorbisenc -lvorbis -logg