diff mbox

[FFmpeg-devel] fate: add test for asetnsamples filter with padding disabled

Message ID 1504617195-30007-1-git-send-email-t.rapp@noa-archive.com
State Accepted
Commit d47159a42d8a0a370fd94b02f7f59e3d4787ddf4
Headers show

Commit Message

Tobias Rapp Sept. 5, 2017, 1:13 p.m. UTC
Adds another test for asetnsamples filter where padding of the last
frame is switched off. Renames the existing test to make the difference
obvious.

Signed-off-by: Tobias Rapp <t.rapp@noa-archive.com>
---
 tests/fate/filter-audio.mak                                 | 13 +++++++++----
 .../fate/{filter-asetnsamples => filter-asetnsamples-nopad} |  2 +-
 .../fate/{filter-asetnsamples => filter-asetnsamples-pad}   |  0
 3 files changed, 10 insertions(+), 5 deletions(-)
 copy tests/ref/fate/{filter-asetnsamples => filter-asetnsamples-nopad} (99%)
 rename tests/ref/fate/{filter-asetnsamples => filter-asetnsamples-pad} (100%)

Comments

Michael Niedermayer Sept. 8, 2017, 2:04 a.m. UTC | #1
On Tue, Sep 05, 2017 at 03:13:15PM +0200, Tobias Rapp wrote:
> Adds another test for asetnsamples filter where padding of the last
> frame is switched off. Renames the existing test to make the difference
> obvious.
> 
> Signed-off-by: Tobias Rapp <t.rapp@noa-archive.com>
> ---
>  tests/fate/filter-audio.mak                                 | 13 +++++++++----
>  .../fate/{filter-asetnsamples => filter-asetnsamples-nopad} |  2 +-
>  .../fate/{filter-asetnsamples => filter-asetnsamples-pad}   |  0
>  3 files changed, 10 insertions(+), 5 deletions(-)
>  copy tests/ref/fate/{filter-asetnsamples => filter-asetnsamples-nopad} (99%)
>  rename tests/ref/fate/{filter-asetnsamples => filter-asetnsamples-pad} (100%)

tested on linux x86-32 / 64, mips + migw32/64


[...]
Tobias Rapp Sept. 8, 2017, 7:08 a.m. UTC | #2
On 08.09.2017 04:04, Michael Niedermayer wrote:
> On Tue, Sep 05, 2017 at 03:13:15PM +0200, Tobias Rapp wrote:
>> Adds another test for asetnsamples filter where padding of the last
>> frame is switched off. Renames the existing test to make the difference
>> obvious.
>>
>> Signed-off-by: Tobias Rapp <t.rapp@noa-archive.com>
>> ---
>>   tests/fate/filter-audio.mak                                 | 13 +++++++++----
>>   .../fate/{filter-asetnsamples => filter-asetnsamples-nopad} |  2 +-
>>   .../fate/{filter-asetnsamples => filter-asetnsamples-pad}   |  0
>>   3 files changed, 10 insertions(+), 5 deletions(-)
>>   copy tests/ref/fate/{filter-asetnsamples => filter-asetnsamples-nopad} (99%)
>>   rename tests/ref/fate/{filter-asetnsamples => filter-asetnsamples-pad} (100%)
> 
> tested on linux x86-32 / 64, mips + migw32/64

Pushed, thanks for testing.

Regards,
Tobias
diff mbox

Patch

diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-audio.mak
index 5035e8f..35ad0f8 100644
--- a/tests/fate/filter-audio.mak
+++ b/tests/fate/filter-audio.mak
@@ -84,10 +84,15 @@  fate-filter-anequalizer: tests/data/filtergraphs/anequalizer
 fate-filter-anequalizer: SRC = $(TARGET_PATH)/tests/data/asynth-44100-2.wav
 fate-filter-anequalizer: CMD = framecrc -i $(SRC) -filter_complex_script $(TARGET_PATH)/tests/data/filtergraphs/anequalizer
 
-FATE_AFILTER-$(call FILTERDEMDECENCMUX, ASETNSAMPLES, WAV, PCM_S16LE, PCM_S16LE, WAV) += fate-filter-asetnsamples
-fate-filter-asetnsamples: tests/data/asynth-44100-2.wav
-fate-filter-asetnsamples: SRC = $(TARGET_PATH)/tests/data/asynth-44100-2.wav
-fate-filter-asetnsamples: CMD = framecrc -i $(SRC) -af asetnsamples=512:p=1
+FATE_AFILTER-$(call FILTERDEMDECENCMUX, ASETNSAMPLES, WAV, PCM_S16LE, PCM_S16LE, WAV) += fate-filter-asetnsamples-pad
+fate-filter-asetnsamples-pad: tests/data/asynth-44100-2.wav
+fate-filter-asetnsamples-pad: SRC = $(TARGET_PATH)/tests/data/asynth-44100-2.wav
+fate-filter-asetnsamples-pad: CMD = framecrc -i $(SRC) -af asetnsamples=512:p=1
+
+FATE_AFILTER-$(call FILTERDEMDECENCMUX, ASETNSAMPLES, WAV, PCM_S16LE, PCM_S16LE, WAV) += fate-filter-asetnsamples-nopad
+fate-filter-asetnsamples-nopad: tests/data/asynth-44100-2.wav
+fate-filter-asetnsamples-nopad: SRC = $(TARGET_PATH)/tests/data/asynth-44100-2.wav
+fate-filter-asetnsamples-nopad: CMD = framecrc -i $(SRC) -af asetnsamples=512:p=0
 
 FATE_AFILTER-$(call FILTERDEMDECENCMUX, ASETRATE, WAV, PCM_S16LE, PCM_S16LE, WAV) += fate-filter-asetrate
 fate-filter-asetrate: tests/data/asynth-44100-2.wav
diff --git a/tests/ref/fate/filter-asetnsamples b/tests/ref/fate/filter-asetnsamples-nopad
similarity index 99%
copy from tests/ref/fate/filter-asetnsamples
copy to tests/ref/fate/filter-asetnsamples-nopad
index 23cf11b..c1cc01a 100644
--- a/tests/ref/fate/filter-asetnsamples
+++ b/tests/ref/fate/filter-asetnsamples-nopad
@@ -520,4 +520,4 @@ 
 0,     262656,     262656,      512,     2048, 0xb881fa44
 0,     263168,     263168,      512,     2048, 0xb7cdf1f3
 0,     263680,     263680,      512,     2048, 0x1e9b17b5
-0,     264192,     264192,      512,     2048, 0xfd82313e
+0,     264192,     264192,      408,     1632, 0xf412313e
diff --git a/tests/ref/fate/filter-asetnsamples b/tests/ref/fate/filter-asetnsamples-pad
similarity index 100%
rename from tests/ref/fate/filter-asetnsamples
rename to tests/ref/fate/filter-asetnsamples-pad