diff mbox

[FFmpeg-devel,v2,2/3] lavf/qsv_overlay: check the return value of ff_formats_ref()

Message ID 1511169274-28005-2-git-send-email-zhong.li@intel.com
State Accepted
Commit 81c615f0feb2a871b75c7fa6d895e7e92a570f7c
Headers show

Commit Message

Zhong Li Nov. 20, 2017, 9:14 a.m. UTC 
suppress the build warning of "ignoring return value of ‘ff_formats_ref’,
declared with attribute warn_unused_result"

Signed-off-by: Zhong Li <zhong.li@intel.com>
Reviewed-by: Carl Eugen Hoyos <ceffmpeg@gmail.com>
---
 libavfilter/vf_overlay_qsv.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
diff mbox

Patch

diff --git a/libavfilter/vf_overlay_qsv.c b/libavfilter/vf_overlay_qsv.c
index 1f50d4b..6c3efdb 100644
--- a/libavfilter/vf_overlay_qsv.c
+++ b/libavfilter/vf_overlay_qsv.c
@@ -415,6 +415,7 @@  static void overlay_qsv_uninit(AVFilterContext *ctx)
 static int overlay_qsv_query_formats(AVFilterContext *ctx)
 {
     int i;
+    int ret;
 
     static const enum AVPixelFormat main_in_fmts[] = {
         AV_PIX_FMT_YUV420P,
@@ -430,10 +431,15 @@  static int overlay_qsv_query_formats(AVFilterContext *ctx)
         AV_PIX_FMT_NONE
     };
 
-    for (i = 0; i < ctx->nb_inputs; i++)
-        ff_formats_ref(ff_make_format_list(main_in_fmts), &ctx->inputs[i]->out_formats);
+    for (i = 0; i < ctx->nb_inputs; i++) {
+        ret = ff_formats_ref(ff_make_format_list(main_in_fmts), &ctx->inputs[i]->out_formats);
+        if (ret < 0)
+            return ret;
+    }
 
-    ff_formats_ref(ff_make_format_list(out_pix_fmts), &ctx->outputs[0]->in_formats);
+    ret = ff_formats_ref(ff_make_format_list(out_pix_fmts), &ctx->outputs[0]->in_formats);
+    if (ret < 0)
+        return ret;
 
     return 0;
 }