From patchwork Mon Jan 15 08:21:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dixit, Vishwanath" X-Patchwork-Id: 7287 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.78.2 with SMTP id r2csp2627840jaa; Mon, 15 Jan 2018 00:22:26 -0800 (PST) X-Google-Smtp-Source: ACJfBouxx8SO8akKzqvB4L9UmQvDADoSmFZHyrBbqLUqCSi40v7jO9PYxe/dYuwMtmYdVsqGfIaM X-Received: by 10.223.163.91 with SMTP id d27mr2589676wrb.18.1516004546514; Mon, 15 Jan 2018 00:22:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516004546; cv=none; d=google.com; s=arc-20160816; b=CBDpT/xuDLgJe1+a82sptnFnsLHi3HE+QTJbNH4xlOdBQrxigOlLGMc9RDivyXpUXP sUxl0/99bnZmpVXA8GA2ikYwOq5cAYTMyUkTD4iGelhJLNcYwZDic1LDOR6u6crLTMas +fYfwBN1/m+EvC+73smzi/WOgFY9Gs+ubvzJrWFkZb2+u1IQWpoGDDtEc7pp1BEUmArQ VTRsH4CqbfxsqBlBjQkAp3KTr1oX1fhCOtQySw9cDwYYQwUlQlGAZFrTVDQMc0zA5Z32 i1KliYyrofsnQJTJxnfJm/Lw5XNllXmxB9f/DZOjVFsyAO9m9Vcr1dy3KH1hEs9YiUcT MN3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:feedback-id:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to :arc-authentication-results; bh=FUcDt560CE0uMgUR2LnHk5aASs4N73wB2j2KWBaaiv0=; b=PNUdbCXdqv5aHQRy8cM/VvbU7fQvnULYGvbDiM8K+OUtilBEqaQ1ctXxh/JYQ0MJuL T2a/kkbSdKdNkWqvaxkGuv8K/QSxiwLeTu1m4YbMehO6X+FeT5UgchpvYhApaFGzNZaC wpkpe2x8RsVo1OSS6UB2PfEUVjq31J3hZ773aQguoJNw8qw5bIbRGO0hQ2GOMBb6m5Iv 1vYqwUS/RzImgyWS1+gIOhKWzKjOCbL+Eb4EBsWm8y8PHMdCm3LYugVnd6IUbBhZfXRp M+lZgWPo0SoWN1FvvX+ESLJ0Zj2KuVOs6zSI7eFH19lvGvOrapMF88Dk2qGTztWpWfoi 9tlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@smtpservice.net header.s=m78bu0.a1-4.dyn header.b=T8avJdGR; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=akamai.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id w5si885825wrb.499.2018.01.15.00.22.26; Mon, 15 Jan 2018 00:22:26 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@smtpservice.net header.s=m78bu0.a1-4.dyn header.b=T8avJdGR; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=akamai.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5B6A7689FF7; Mon, 15 Jan 2018 10:22:23 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from a2i831.smtp2go.com (unknown [103.47.207.63]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 72989689FED for ; Mon, 15 Jan 2018 10:22:16 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpservice.net; s=m78bu0.a1-4.dyn; x=1516005443; h=Feedback-ID: X-Smtpcorp-Track:Message-Id:Date:Subject:To:From:Reply-To:Sender: List-Unsubscribe; bh=05eL13fIHFNi9pRhifhvcP/a+gdfx0rdfGvtskzH8m8=; b=T8avJdGR +xzw0yMAAFnzTRuORy8uXYynOYpmc69xXOsYa76BdfXThSnOVbtrgNysdMaJ4cZDcipwlTEe0vI77 uZ41GNfVJ0+l2BbCG4iM1g+08BPeCdbxEzgMyO330qGAHWVZGg+bOYlgzbgW6cdGpIsLW7t729dwj EsGwg1uq3PYE325FN73yVQypt/YC172XiGiwLvpmHAiAYkhsPwY9tS0mq/Fnn0932Ke1J41WE6GIj LGSpYXKY1ONoiw+ZNZPtoz1ExVZsS1uvFnRREgb+MDqXdwPSPM+RlwTEelbTVAJxOj7vmqp5aELbx n5DhNVhklAuhDVOZNf/mG1xzeA==; From: vdixit@akamai.com To: ffmpeg-devel@ffmpeg.org Date: Mon, 15 Jan 2018 13:51:46 +0530 Message-Id: <1516004506-12626-1-git-send-email-vdixit@akamai.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: X-Smtpcorp-Track: 1-P01s4ba7ia6v.bCStStf1E Feedback-ID: 337386m:337386asVRLGB:337386sEEJSooxvI:SMTPCORP X-Report-Abuse: Please forward a copy of this message, including all headers, to Subject: [FFmpeg-devel] [PATCH v3 1/3] avdevice/decklink: addition of copyts option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Vishwanath Dixit MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Vishwanath Dixit --- doc/indevs.texi | 5 +++++ libavdevice/decklink_common_c.h | 1 + libavdevice/decklink_dec.cpp | 18 +++++++++++------- libavdevice/decklink_dec_c.c | 1 + 4 files changed, 18 insertions(+), 7 deletions(-) diff --git a/doc/indevs.texi b/doc/indevs.texi index 56066bf..36aef49 100644 --- a/doc/indevs.texi +++ b/doc/indevs.texi @@ -317,6 +317,11 @@ Defaults to @samp{1073741824}. Sets the audio sample bit depth. Must be @samp{16} or @samp{32}. Defaults to @samp{16}. +@item decklink_copyts +If set to @option{true}, timestamps are forwarded as they are without removing +the initial offset. +Defaults to @option{false}. + @end table @subsection Examples diff --git a/libavdevice/decklink_common_c.h b/libavdevice/decklink_common_c.h index 368ac25..ac6563a 100644 --- a/libavdevice/decklink_common_c.h +++ b/libavdevice/decklink_common_c.h @@ -52,6 +52,7 @@ struct decklink_cctx { char *format_code; int raw_format; int64_t queue_size; + int copyts; }; #endif /* AVDEVICE_DECKLINK_COMMON_C_H */ diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 94dae26..1fd40ca 100644 --- a/libavdevice/decklink_dec.cpp +++ b/libavdevice/decklink_dec.cpp @@ -586,7 +586,8 @@ static int64_t get_pkt_pts(IDeckLinkVideoInputFrame *videoFrame, IDeckLinkAudioInputPacket *audioFrame, int64_t wallclock, DecklinkPtsSource pts_src, - AVRational time_base, int64_t *initial_pts) + AVRational time_base, int64_t *initial_pts, + int copyts) { int64_t pts = AV_NOPTS_VALUE; BMDTimeValue bmd_pts; @@ -619,10 +620,12 @@ static int64_t get_pkt_pts(IDeckLinkVideoInputFrame *videoFrame, if (res == S_OK) pts = bmd_pts / time_base.num; - if (pts != AV_NOPTS_VALUE && *initial_pts == AV_NOPTS_VALUE) - *initial_pts = pts; - if (*initial_pts != AV_NOPTS_VALUE) - pts -= *initial_pts; + if (!copyts) { + if (pts != AV_NOPTS_VALUE && *initial_pts == AV_NOPTS_VALUE) + *initial_pts = pts; + if (*initial_pts != AV_NOPTS_VALUE) + pts -= *initial_pts; + } return pts; } @@ -635,6 +638,7 @@ HRESULT decklink_input_callback::VideoInputFrameArrived( BMDTimeValue frameTime; BMDTimeValue frameDuration; int64_t wallclock = 0; + struct decklink_cctx *cctx = (struct decklink_cctx *) avctx->priv_data; if (ctx->autodetect) { if (videoFrame && !(videoFrame->GetFlags() & bmdFrameHasNoInputSource) && @@ -694,7 +698,7 @@ HRESULT decklink_input_callback::VideoInputFrameArrived( no_video = 0; } - pkt.pts = get_pkt_pts(videoFrame, audioFrame, wallclock, ctx->video_pts_source, ctx->video_st->time_base, &initial_video_pts); + pkt.pts = get_pkt_pts(videoFrame, audioFrame, wallclock, ctx->video_pts_source, ctx->video_st->time_base, &initial_video_pts, cctx->copyts); pkt.dts = pkt.pts; pkt.duration = frameDuration; @@ -785,7 +789,7 @@ HRESULT decklink_input_callback::VideoInputFrameArrived( pkt.size = audioFrame->GetSampleFrameCount() * ctx->audio_st->codecpar->channels * (ctx->audio_depth / 8); audioFrame->GetBytes(&audioFrameBytes); audioFrame->GetPacketTime(&audio_pts, ctx->audio_st->time_base.den); - pkt.pts = get_pkt_pts(videoFrame, audioFrame, wallclock, ctx->audio_pts_source, ctx->audio_st->time_base, &initial_audio_pts); + pkt.pts = get_pkt_pts(videoFrame, audioFrame, wallclock, ctx->audio_pts_source, ctx->audio_st->time_base, &initial_audio_pts, cctx->copyts); pkt.dts = pkt.pts; //fprintf(stderr,"Audio Frame size %d ts %d\n", pkt.size, pkt.pts); diff --git a/libavdevice/decklink_dec_c.c b/libavdevice/decklink_dec_c.c index 1c6d826..f65b177 100644 --- a/libavdevice/decklink_dec_c.c +++ b/libavdevice/decklink_dec_c.c @@ -73,6 +73,7 @@ static const AVOption options[] = { { "draw_bars", "draw bars on signal loss" , OFFSET(draw_bars), AV_OPT_TYPE_BOOL, { .i64 = 1}, 0, 1, DEC }, { "queue_size", "input queue buffer size", OFFSET(queue_size), AV_OPT_TYPE_INT64, { .i64 = (1024 * 1024 * 1024)}, 0, INT64_MAX, DEC }, { "audio_depth", "audio bitdepth (16 or 32)", OFFSET(audio_depth), AV_OPT_TYPE_INT, { .i64 = 16}, 16, 32, DEC }, + { "decklink_copyts", "copy timestamps, do not remove the initial offset", OFFSET(copyts), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, DEC }, { NULL }, };