diff mbox

[FFmpeg-devel,04/11] avformat/dashenc: removed 'write_manifest' call from 'write_header'

Message ID 1521782801-26262-1-git-send-email-vdixit@akamai.com
State Accepted
Commit 1263d91198676790527f288e9af52eeb8d6afc45
Headers show

Commit Message

Dixit, Vishwanath March 23, 2018, 5:26 a.m. UTC
From: Vishwanath Dixit <vdixit@akamai.com>

Calling 'write_manifest' from 'write_header' was causing creation of
first MPD with invalid values. Ex: zero @duration param value. Also,
the manifest files (MPD or M3U8s) should be created when at-least
one media frame is ready for consumption.
 libavformat/dashenc.c | 3 ---
 1 file changed, 3 deletions(-)
diff mbox


diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
index 5fb839d..7b854b5 100644
--- a/libavformat/dashenc.c
+++ b/libavformat/dashenc.c
@@ -1036,9 +1036,6 @@  static int dash_write_header(AVFormatContext *s)
         if ((ret = avformat_write_header(os->ctx, NULL)) < 0)
             return ret;
-    ret = write_manifest(s, 0);
-    if (!ret)
-        av_log(s, AV_LOG_VERBOSE, "Manifest written to: %s\n", s->url);
     return ret;