From patchwork Fri Mar 23 05:26:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dixit, Vishwanath" X-Patchwork-Id: 8112 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.1.70 with SMTP id c67csp19252jad; Thu, 22 Mar 2018 22:26:54 -0700 (PDT) X-Google-Smtp-Source: AG47ELt5qe6fOHT3BB1dDYnco8zUtHQKIi2BKQ63NAKxRzHQW/wuW+wjsF+3evLpaLLFDdTpXuTA X-Received: by 10.28.140.76 with SMTP id o73mr7160596wmd.67.1521782813979; Thu, 22 Mar 2018 22:26:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521782813; cv=none; d=google.com; s=arc-20160816; b=Ee6IRmAzlLy3T28d0IBFhIP3SsaAcvzyysYgwLBtXGMPOPK0B13XKKN2QjkPhwS4GU KdRehC8gFoN2kpFeLM48jGAwmzW0cE8IR6Tf14LHhukdzmF5mHVJ4Awcapeo6UytufAY 1xUPrd2eeFzENkycGDzggk1RY9+LuEXrC0k+hUEp70jCVomxR0c/7/ZydzfGpqR44W5z R8i/pRIrS3kDyStdnB6G/yaVkzYGXJG8pvSH7Ubrnb1cx2+FmAVIp0Eu7+LskCWc68Mx LGs4sTCVYXr5/4NDv5hmCXvcd8AaFmtFA9C0//QYsHYoqaRKbbRNTA8Yn1eMkGRR+Rrb MpiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:feedback-id:message-id:date:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=xsWFamjTtyDs6U6B4q3jsxv7VnXnY7Jd0UN0o8pGX+Y=; b=ESw7xoCJYHoOwriULW5SUWIOzybGsZGvdewDbAO+wfAC3l268wqazy/B3gOoLsG4WW fTUCGuSMn2yJTStL4aDBhuQODEEi8FkGhh2V/liEu0ZTpsFIdN84ZfFBcjFAdxL6ZdSw 6GOMwmNeuHyEdPDfKmKMNpTTBik8C/hAOAiGHFlYjNLD3Y3Bea9Qwu9N7VdIGxFVAywi BeWJ41cU0zEjJGCtJq5Kj0WMgbtQSVnBHoPIfmrjF+SXRllP9ZQPyub11toA9mLuFLpv QBSyELcw5iD50yVn79JK1WDZWUYbhbcJVaOcuZ85W4wW70zgfdRcns7MKRF1WotO6C+V KUAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@smtpservice.net header.s=m78bu0.a1-4.dyn header.b=bFICYBQ+; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=akamai.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y59si6052921wrb.253.2018.03.22.22.26.53; Thu, 22 Mar 2018 22:26:53 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@smtpservice.net header.s=m78bu0.a1-4.dyn header.b=bFICYBQ+; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=akamai.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 460796897C0; Fri, 23 Mar 2018 07:26:35 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from a2i831.smtp2go.com (a2i831.smtp2go.com [103.47.207.63]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 02A9B6897C0 for ; Fri, 23 Mar 2018 07:26:32 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpservice.net; s=m78bu0.a1-4.dyn; x=1521783709; h=Feedback-ID: X-Smtpcorp-Track:Message-Id:Date:Subject:To:From:Reply-To:Sender: List-Unsubscribe; bh=gqzjkveliyU4/msPLShwf4KQiltBHrTJJvPp0TfTyFk=; b=bFICYBQ+ m1IMZ2uXETQb6vlfy/skh/pLB+7giHJhvh5vKyx5jde1IPnUDbA/WnoMkPyelFMs8a4Rw0CFS4DMX AKRzPOdxkXDsPJqndtWDzq6jgsNoKXOiMoYpm53H4vlr069lQwDsL18GpO/K9G+0u0rw5xAD6oh/8 szHVNAxzL212HjXbCB1JShcCUwcvoHhcND+3ph+iga2nMhYOxdldfvDFGQmsO9DvxYmnuPxJuj+L3 Q7LpS2P2+8n2YmzxRSeG2BUMkjvuXQbZb641vDNmXJgKmcxc/wHusmLTcvKQzdVjtGIxqIOxQCPyC 7RJWl+oEdjmmUp1ZkPfZmj2/Zg==; From: vdixit@akamai.com To: ffmpeg-devel@ffmpeg.org Date: Fri, 23 Mar 2018 10:56:41 +0530 Message-Id: <1521782801-26262-1-git-send-email-vdixit@akamai.com> X-Mailer: git-send-email 1.9.1 X-Smtpcorp-Track: 1-zFDwNmF8oRCy.tNjV5matz Feedback-ID: 337386m:337386asVRLGB:337386sTmlYPjaRG:SMTPCORP X-Report-Abuse: Please forward a copy of this message, including all headers, to Subject: [FFmpeg-devel] [PATCH 04/11] avformat/dashenc: removed 'write_manifest' call from 'write_header' X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Vishwanath Dixit MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Vishwanath Dixit Calling 'write_manifest' from 'write_header' was causing creation of first MPD with invalid values. Ex: zero @duration param value. Also, the manifest files (MPD or M3U8s) should be created when at-least one media frame is ready for consumption. --- libavformat/dashenc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 5fb839d..7b854b5 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -1036,9 +1036,6 @@ static int dash_write_header(AVFormatContext *s) if ((ret = avformat_write_header(os->ctx, NULL)) < 0) return ret; } - ret = write_manifest(s, 0); - if (!ret) - av_log(s, AV_LOG_VERBOSE, "Manifest written to: %s\n", s->url); return ret; }