From patchwork Wed Apr 4 08:37:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dixit, Vishwanath" X-Patchwork-Id: 8316 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.1.70 with SMTP id c67csp4619020jad; Wed, 4 Apr 2018 01:37:30 -0700 (PDT) X-Google-Smtp-Source: AIpwx497pUBeYaP+FxRVUmdj0e8fxw/JiYDIdgFNSlUVuRJTp493rUHCEFn0vENchqoMdzDvxD87 X-Received: by 10.223.209.198 with SMTP id m6mr12899656wri.267.1522831050255; Wed, 04 Apr 2018 01:37:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522831050; cv=none; d=google.com; s=arc-20160816; b=O55PHIwiXAt1Hfwbk905rJ339Tnv9Q5gioAkrouWKlC4iriqkPD3r3e9wGq3gGY5Lb tag0kIbG437gMLXAI9kIxCaDy7dFdbqAKR8qBKbNa9T1Rcd93ScIpkFzmwFk++i03BtV DDGQ8SRZyGsvMERe3vwQ5yaUS7/sfN6tFfWmaEi56GY98QKw1Gyv2EEv2+mX6btUuomF mPoRV3xKeCOEXSs9u2N8xLOMkXHckizZa3Qccvr50ebPPJN4quWYGDxTmDKBZ3vJnTHn ZfPKr2RUYmCXbk6D1hugBmF8OWhMbcI2S/CHkJvofGEnuBfU1/dLg8MjyaqdOkB33t+A gvmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:feedback-id:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to :arc-authentication-results; bh=guzyKnQKIIPw82V0eUeafWnDsLl8MRUt+YbKMkOVVrE=; b=Ri3oVzJpOTIdFo5zAbOYpSYz+L4QuNezph6kypXee1N2Ldw7oDiWquiFvghdm9Mj7J zja+kbjnxPskooRL7xoWE0rGkVeCuB0+5Oa2Uls2TgqJC/DwJC/8ut2qtQkRsWLyGADe b6hFmPJWWIw+hM71QcqBvRZWmXoAXiBERn0wSH/T7s7guneQeUGoS3kbDp/aK3vplapG IuFH5jILIImiPy3+YC2lGRT8cr3LkT17Vn0RX0zWQr4/UULXDszbCker9TiA20DFYxyg Ms0eYGNQ7UXvJ8qG7IHGIX0M1YVY5QU5xJl3KQ4TaFMNe7ENHUnOrKLl6E6mUAniao6c k53A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@smtpservice.net header.s=m78bu0.a1-4.dyn header.b=wLeqFZAn; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=akamai.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id v6si3422106wmh.167.2018.04.04.01.37.29; Wed, 04 Apr 2018 01:37:30 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@smtpservice.net header.s=m78bu0.a1-4.dyn header.b=wLeqFZAn; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=akamai.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 13E3E689A7B; Wed, 4 Apr 2018 11:37:04 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from a1i318.smtp2go.com (a1i318.smtp2go.com [43.228.185.62]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CA5DA689A03 for ; Wed, 4 Apr 2018 11:37:02 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpservice.net; s=m78bu0.a1-4.dyn; x=1522831944; h=Feedback-ID: X-Smtpcorp-Track:Message-Id:Date:Subject:To:From:Reply-To:Sender: List-Unsubscribe; bh=3Dxptxn7CH9piMXswUiVU8mehhsGh3dLcHPrNcViCdQ=; b=wLeqFZAn bh9nIRadCW5KZ0clAAmkRlgquw7UQkY1tvBgLtsRXgKU5mRRA+B+I7EcHoqokwV2HSVV2ZBQM71YI F6Ytshkm1GVi0KtJ/x/8e4rD192NWv/erpqdsGbYSS4OaUTfKMqAF5xwUGl6ESDPFpe2nBILMCikQ 9Z7st/v8egEsr7E9Xpl+NLe8WTe12OpzBXFO4MfXhMMDbFydNdeMFkhrKsVFxbfWECoLubIx0VWm5 qGGiPtH1byJZgUXQW8sBSmO1j5alg1gzPIwSubroNwUY25TpQ9S4mLKWzl1Z8oOFhkAhWf6mRWN7E 2ujRO0L+rQrDgbqzK801atDqBQ==; From: vdixit@akamai.com To: ffmpeg-devel@ffmpeg.org Date: Wed, 4 Apr 2018 14:07:15 +0530 Message-Id: <1522831035-7078-1-git-send-email-vdixit@akamai.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1521782801-26262-1-git-send-email-vdixit@akamai.com> References: <1521782801-26262-1-git-send-email-vdixit@akamai.com> X-Smtpcorp-Track: 1f3dIxNmF9tCHc.xu6AUowJo Feedback-ID: 337386m:337386asVRLGB:337386sVwVi3Jsv5:SMTPCORP X-Report-Abuse: Please forward a copy of this message, including all headers, to Subject: [FFmpeg-devel] [PATCH v2 04/11] avformat/dashenc: removed 'write_manifest' call from 'write_header' X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Vishwanath Dixit MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Vishwanath Dixit Calling 'write_manifest' from 'write_header' was causing creation of first MPD with invalid values. Ex: zero @duration param value. Also, the manifest files (MPD or M3U8s) should be created when at-least one media frame is ready for consumption. --- libavformat/dashenc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index e719409..1bac2c9 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -1042,9 +1042,6 @@ static int dash_write_header(AVFormatContext *s) if ((ret = avformat_write_header(os->ctx, NULL)) < 0) return ret; } - ret = write_manifest(s, 0); - if (!ret) - av_log(s, AV_LOG_VERBOSE, "Manifest written to: %s\n", s->url); return ret; }