From patchwork Wed Apr 11 07:01:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dixit, Vishwanath" X-Patchwork-Id: 8391 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.1.70 with SMTP id c67csp369275jad; Wed, 11 Apr 2018 00:01:44 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/FZQpGhhX8rk6zRauQxE/Pj5KWegggvFCk0oM48FHWFxJzFuHo5U8vgxMyctaoVgP3SILP X-Received: by 10.223.150.117 with SMTP id c50mr2413815wra.196.1523430104791; Wed, 11 Apr 2018 00:01:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523430104; cv=none; d=google.com; s=arc-20160816; b=rTmildRLEn2n32erAmzgyD58BMWecfuhCvwNe1o3M0tmlriPcziZfBpFnWzzhyEwgN xCC7rEWgZorJCcTKesOsLIC7oGquI1jiSViVBMAS0Htru4m0hbqAIXvHQLCXXCSMXBH4 FAY3W9ZrszUP7xXZXncunplSDprBSO6zWxoJ4DUK7dUGg2klHth2EdUhzAuB3fFIwvTZ ATI2M7kQMC4Fv0wx38YgyC4PSlJFDxF4NFovOzDfEs0MsI80JZk4rbF6puif4tBqdScR 1NlAci4ijTOXu0WqKFxA3+5JtzAUsKc7cCdWwtCkgJB8mN5k1BVzjs3Djy6xdVrejZC2 S6Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:feedback-id:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to :arc-authentication-results; bh=C7YvdLId8pnpq6fWvwbvLve/wXDg98g8fpLuYVJMzak=; b=PZFCvDHqzyNgzQ+8x6YLRcEv0m6J5J4vU0R9ZA3zKCxqRh1r8E5emgNV9AL8rd07Qk ZP7AmG3cDIQxJ+dU//mRMvvfj7e4FgrQ9atvz5i1izyBNCGJAXrptmS1KOTezeLuYxRe 96P0/KlvcuhgizjZUYZx9s1Z+5Q5xIsHydD0PdVlC6WNsTEVZ6jZfd8dzTOlUevgiPKT kvAOM73iHe0AXRGVkyzxvUc8t1KIWrMb0Mr0Kx+lAN8mgnm7OeWS+0xrpQPmYe97dJ6T MosK7hU4AEjxeK8huaHAjpAulTWQe7pGz2Io2eYS/zAJaW1SRfJbNjrKzMO2UAVxz6GX 9IFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@smtpservice.net header.s=m78bu0.a1-4.dyn header.b=4KtJFFdv; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=akamai.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id o7si527285wmo.196.2018.04.11.00.01.44; Wed, 11 Apr 2018 00:01:44 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@smtpservice.net header.s=m78bu0.a1-4.dyn header.b=4KtJFFdv; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=akamai.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 864F968A20A; Wed, 11 Apr 2018 10:01:19 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from a1i318.smtp2go.com (a1i318.smtp2go.com [43.228.185.62]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 10645689B7C for ; Wed, 11 Apr 2018 10:01:13 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpservice.net; s=m78bu0.a1-4.dyn; x=1523431002; h=Feedback-ID: X-Smtpcorp-Track:Message-Id:Date:Subject:To:From:Reply-To:Sender: List-Unsubscribe; bh=wk3lhrkyJvNcb1d1CXuFQSn53O8UOxIwwQzc8tK7hEA=; b=4KtJFFdv 4Ehvf16w3ScehjuEZVA3sd6ZxT5IAEgV6oK97OsRMQWwrO1nFmRuI0q92Tna8+0l7cRC8OeomTzol e0Mx7SUTrQvl2Qh/xStm8RoZ//x6f1r/3yHqRIus17xV0EmzBvyescxIXWejkLyy1y718xtm0qKyQ r1IqP/mkK+1YUUKJanUMRWEEl9xhZuVSBEH/0TlEGazKbHo5skE8W5hu0Q88byT6k4ctn3QZ9rzZm RRkBXkMoQcGLPI6AUz+pWtsljSGMdf6CrsQXSN8hxnKo+C+0CGviL08X+6Mh6SsA+cn7EZYunlnkv Hi6lAr/wNaCxTrxzMGuThoOE3w==; From: vdixit@akamai.com To: ffmpeg-devel@ffmpeg.org Date: Wed, 11 Apr 2018 12:31:26 +0530 Message-Id: <1523430086-17114-1-git-send-email-vdixit@akamai.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1522831035-7078-1-git-send-email-vdixit@akamai.com> References: <1522831035-7078-1-git-send-email-vdixit@akamai.com> X-Smtpcorp-Track: 1f69_6RyIKOuFh.zfLNBaTzR Feedback-ID: 337386m:337386asVRLGB:337386sQm-4VurKi:SMTPCORP X-Report-Abuse: Please forward a copy of this message, including all headers, to Subject: [FFmpeg-devel] [PATCH v3 04/11] avformat/dashenc: removed 'write_manifest' call from 'write_header' X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Vishwanath Dixit MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Vishwanath Dixit Calling 'write_manifest' from 'write_header' was causing creation of first MPD with invalid values. Ex: zero @duration param value. Also, the manifest files (MPD or M3U8s) should be created when at-least one media frame is ready for consumption. --- libavformat/dashenc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 4c2e63c..bf06a7b 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -1046,9 +1046,6 @@ static int dash_write_header(AVFormatContext *s) if ((ret = avformat_write_header(os->ctx, NULL)) < 0) return ret; } - ret = write_manifest(s, 0); - if (!ret) - av_log(s, AV_LOG_VERBOSE, "Manifest written to: %s\n", s->url); return ret; }