diff mbox

[FFmpeg-devel] fate: add more tests for hue video filter

Message ID 1525860348-21386-1-git-send-email-t.rapp@noa-archive.com
State Accepted
Commit 66ba303c53698829e0b2c2d8f1c063fa35763fca
Headers show

Commit Message

Tobias Rapp May 9, 2018, 10:05 a.m. UTC
Adds tests for the hue angle and brightness filter parameters.
Renames the existing saturation parameter test for consistency.

Signed-off-by: Tobias Rapp <t.rapp@noa-archive.com>
---
 tests/fate/filter-video.mak | 10 ++++++++--
 tests/ref/fate/filter-hue   |  1 -
 tests/ref/fate/filter-hue1  |  1 +
 tests/ref/fate/filter-hue2  |  1 +
 tests/ref/fate/filter-hue3  |  1 +
 5 files changed, 11 insertions(+), 3 deletions(-)
 delete mode 100644 tests/ref/fate/filter-hue
 create mode 100644 tests/ref/fate/filter-hue1
 create mode 100644 tests/ref/fate/filter-hue2
 create mode 100644 tests/ref/fate/filter-hue3

Comments

Michael Niedermayer May 10, 2018, 9:04 p.m. UTC | #1
On Wed, May 09, 2018 at 12:05:48PM +0200, Tobias Rapp wrote:
> Adds tests for the hue angle and brightness filter parameters.
> Renames the existing saturation parameter test for consistency.
> 
> Signed-off-by: Tobias Rapp <t.rapp@noa-archive.com>
> ---
>  tests/fate/filter-video.mak | 10 ++++++++--
>  tests/ref/fate/filter-hue   |  1 -
>  tests/ref/fate/filter-hue1  |  1 +
>  tests/ref/fate/filter-hue2  |  1 +
>  tests/ref/fate/filter-hue3  |  1 +
>  5 files changed, 11 insertions(+), 3 deletions(-)
>  delete mode 100644 tests/ref/fate/filter-hue
>  create mode 100644 tests/ref/fate/filter-hue1
>  create mode 100644 tests/ref/fate/filter-hue2
>  create mode 100644 tests/ref/fate/filter-hue3

should be ok

thx

[...]
Tobias Rapp May 11, 2018, 7:18 a.m. UTC | #2
On 10.05.2018 23:04, Michael Niedermayer wrote:
> On Wed, May 09, 2018 at 12:05:48PM +0200, Tobias Rapp wrote:
>> Adds tests for the hue angle and brightness filter parameters.
>> Renames the existing saturation parameter test for consistency.
>>
>> Signed-off-by: Tobias Rapp <t.rapp@noa-archive.com>
>> ---
>>   tests/fate/filter-video.mak | 10 ++++++++--
>>   tests/ref/fate/filter-hue   |  1 -
>>   tests/ref/fate/filter-hue1  |  1 +
>>   tests/ref/fate/filter-hue2  |  1 +
>>   tests/ref/fate/filter-hue3  |  1 +
>>   5 files changed, 11 insertions(+), 3 deletions(-)
>>   delete mode 100644 tests/ref/fate/filter-hue
>>   create mode 100644 tests/ref/fate/filter-hue1
>>   create mode 100644 tests/ref/fate/filter-hue2
>>   create mode 100644 tests/ref/fate/filter-hue3
> 
> should be ok

Pushed, thanks for review.

Regards,
Tobias
diff mbox

Patch

diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
index 17d6363..f2ab263 100644
--- a/tests/fate/filter-video.mak
+++ b/tests/fate/filter-video.mak
@@ -499,8 +499,14 @@  fate-filter-edgedetect: CMD = video_filter "format=gray,perms=random,edgedetect"
 FATE_FILTER_VSYNTH-$(call ALLYES, FORMAT_FILTER PERMS_FILTER EDGEDETECT_FILTER) += fate-filter-edgedetect-colormix
 fate-filter-edgedetect-colormix: CMD = video_filter "format=gbrp,perms=random,edgedetect=mode=colormix" -frames:v 20
 
-FATE_FILTER_VSYNTH-$(call ALLYES, PERMS_FILTER HUE_FILTER) += fate-filter-hue
-fate-filter-hue: CMD = video_filter "perms=random,hue=s=sin(2*PI*t)+1" -frames:v 20
+FATE_FILTER_VSYNTH-$(call ALLYES, PERMS_FILTER HUE_FILTER) += fate-filter-hue1
+fate-filter-hue1: CMD = video_filter "perms=random,hue=s=sin(2*PI*t)+1" -frames:v 20
+
+FATE_FILTER_VSYNTH-$(call ALLYES, PERMS_FILTER HUE_FILTER) += fate-filter-hue2
+fate-filter-hue2: CMD = video_filter "perms=random,hue=h=18*n" -frames:v 20
+
+FATE_FILTER_VSYNTH-$(call ALLYES, PERMS_FILTER HUE_FILTER) += fate-filter-hue3
+fate-filter-hue3: CMD = video_filter "perms=random,hue=b=n-10" -frames:v 20
 
 FATE_FILTER_VSYNTH-$(CONFIG_IDET_FILTER) += fate-filter-idet
 fate-filter-idet: CMD = framecrc -flags bitexact -idct simple -i $(SRC) -vf idet -frames:v 25 -flags +bitexact
diff --git a/tests/ref/fate/filter-hue b/tests/ref/fate/filter-hue
deleted file mode 100644
index 2f1ae61..0000000
--- a/tests/ref/fate/filter-hue
+++ /dev/null
@@ -1 +0,0 @@ 
-hue                 57463dd9bc17156a51b704dd7271c863
diff --git a/tests/ref/fate/filter-hue1 b/tests/ref/fate/filter-hue1
new file mode 100644
index 0000000..7059ba7
--- /dev/null
+++ b/tests/ref/fate/filter-hue1
@@ -0,0 +1 @@ 
+hue1                57463dd9bc17156a51b704dd7271c863
diff --git a/tests/ref/fate/filter-hue2 b/tests/ref/fate/filter-hue2
new file mode 100644
index 0000000..2e060e1
--- /dev/null
+++ b/tests/ref/fate/filter-hue2
@@ -0,0 +1 @@ 
+hue2                e951ae8ffb279552abc4354c4de7cb5b
diff --git a/tests/ref/fate/filter-hue3 b/tests/ref/fate/filter-hue3
new file mode 100644
index 0000000..14a8379
--- /dev/null
+++ b/tests/ref/fate/filter-hue3
@@ -0,0 +1 @@ 
+hue3                149dc22f5dc9f578f7d281dc3120c09b