From patchwork Fri Aug 31 13:57:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiyou Yin X-Patchwork-Id: 10195 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:12c4:0:0:0:0:0 with SMTP id 65-v6csp797575jap; Fri, 31 Aug 2018 06:57:34 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbH9iF9omFEzb/IIqHxFqu/voobTs6RA/RYX0XAw5IiaT8PfLV7HQujrQM7hSMi/vCOg7KO X-Received: by 2002:a1c:752:: with SMTP id 79-v6mr5078840wmh.59.1535723854786; Fri, 31 Aug 2018 06:57:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535723854; cv=none; d=google.com; s=arc-20160816; b=HByOrCPc2+vWzETMfsfuoJHksiI9TghTwVXvAo+fpetUnMjWvpel/KwTO0x5hu+iBW VCQPzFaNGnuCqA9ArMOZLj+WXuFJc14854yXAP93Uksa/JMPAM8piXLZGQuFcAx/VtFh RWnbxhFfmjLZ5F6t6+wFlaxSWqegkEWNNGa/BVJs1uwiJH3eX7l/YfLWjKMbltF/ydT8 r4vPmRv34/bfIwJQ3YdIIEcP2f3II1o9uM3k1doiqq3IChP63EsUD5xi22Vlu2GFTZWA E8IO3N+s2yrNnTGNvbxt1NwabJRE40hU1S9h7nr9A9mnUBFUWN5BSqF2y/iXeNW6+y1G HjXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to :arc-authentication-results; bh=LCLm/UX38bqNbm3RNQ1MC8N3FBFPffllMws7V9J+TGY=; b=H7uwfhpKTmzPvZX4ipQczlPNQ72Exz0917XOOGbHjk5UXiu4BvWZ/Y0xaCxrsrI44E iDi+FdpxJtNDgmAhIKbZQcIHiVZUD6z0bbYLpeeHypoNNlPRA2/Or3QC+4w2vc5C/Jak LwC1Z18BkzOjeFhEBKbSKytlEUY41bxf+TC00Z45ppsgz8UbiTy0ywx4KDoQbKtEY8xU 2urKR0SbplL45Idia2Ucp+HyYzu5AIScgVdWgkAAjPZi16ylo3pJo9G6YROa64zcVQEW 9EfQYqZa2bdzqJm5Uj+cQH7rTKtNqcDBcnQs/7tBuNJM43zclmNEsj3zZe7HM5eMlbFt qnNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id l13-v6si8692477wrs.164.2018.08.31.06.57.34; Fri, 31 Aug 2018 06:57:34 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 719EA689D4B; Fri, 31 Aug 2018 16:57:28 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 37A6D689D4B for ; Fri, 31 Aug 2018 16:57:20 +0300 (EEST) Received: from localhost (unknown [210.45.123.188]) by mail (Coremail) with SMTP id QMiowPCxaeQuSYlb_vMHAA--.35312S3; Fri, 31 Aug 2018 21:57:03 +0800 (CST) From: Shiyou Yin To: ffmpeg-devel@ffmpeg.org Date: Fri, 31 Aug 2018 21:57:23 +0800 Message-Id: <1535723843-928-1-git-send-email-yinshiyou-hf@loongson.cn> X-Mailer: git-send-email 2.1.0 X-CM-TRANSID: QMiowPCxaeQuSYlb_vMHAA--.35312S3 X-Coremail-Antispam: 1UD129KBjvJXoW3Xr1UKw4rWw1xKryUXF1DWrg_yoW7GF4xpw 1rG3y8Z3WrKFWfW3W7Jr4UGr13AFsYvF1rCF4DKF17Ja43trs7ArZ7Xwn8WFs5KF1fZFZF qrZ8uFW3A348Aw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUv0b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7xvr2IYc2Ij64vIr40E4x8a64kEw24lc2xS Y4AK67AK6ry8MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I 8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUJVWU XwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x 0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Zr0_Wr1UMIIF0xvEx4A2jsIE14v2 6r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU0 rsqJUUUUU== X-CM-SenderInfo: p1lq2x5l1r3gtki6z05rqj20fqof0/ Subject: [FFmpeg-devel] [PATCH v3] avcodec/mips: [loongson] optimize memset in h264dsp. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Optimized memset with mmi in following functions: 1. ff_h264_add_pixels4_8_mmi. 2. ff_h264_idct_add_8_mmi. 3. ff_h264_idct8_add_8_mmi. This optimization improved h264 decoding performance about 1.3%(tested on loongson 3A3000). --- libavcodec/mips/h264dsp_mmi.c | 30 +++++++++++++++++++++--------- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/libavcodec/mips/h264dsp_mmi.c b/libavcodec/mips/h264dsp_mmi.c index ac6fa99..ac65a20 100644 --- a/libavcodec/mips/h264dsp_mmi.c +++ b/libavcodec/mips/h264dsp_mmi.c @@ -31,7 +31,6 @@ void ff_h264_add_pixels4_8_mmi(uint8_t *dst, int16_t *src, int stride) { double ftmp[9]; DECLARE_VAR_LOW32; - DECLARE_VAR_ALL64; __asm__ volatile ( "xor %[ftmp0], %[ftmp0], %[ftmp0] \n\t" @@ -59,12 +58,16 @@ void ff_h264_add_pixels4_8_mmi(uint8_t *dst, int16_t *src, int stride) MMI_SWC1(%[ftmp2], %[dst1], 0x00) MMI_SWC1(%[ftmp3], %[dst2], 0x00) MMI_SWC1(%[ftmp4], %[dst3], 0x00) + + /* memset(src, 0, 32); */ + "xor %[ftmp0], %[ftmp0], %[ftmp0] \n\t" + "gssqc1 %[ftmp0], %[ftmp0], 0x00(%[src]) \n\t" + "gssqc1 %[ftmp0], %[ftmp0], 0x10(%[src]) \n\t" : [ftmp0]"=&f"(ftmp[0]), [ftmp1]"=&f"(ftmp[1]), [ftmp2]"=&f"(ftmp[2]), [ftmp3]"=&f"(ftmp[3]), [ftmp4]"=&f"(ftmp[4]), [ftmp5]"=&f"(ftmp[5]), [ftmp6]"=&f"(ftmp[6]), [ftmp7]"=&f"(ftmp[7]), RESTRICT_ASM_LOW32 - RESTRICT_ASM_ALL64 [ftmp8]"=&f"(ftmp[8]) : [dst0]"r"(dst), [dst1]"r"(dst+stride), [dst2]"r"(dst+2*stride), [dst3]"r"(dst+3*stride), @@ -72,7 +75,6 @@ void ff_h264_add_pixels4_8_mmi(uint8_t *dst, int16_t *src, int stride) : "memory" ); - memset(src, 0, 32); } void ff_h264_idct_add_8_mmi(uint8_t *dst, int16_t *block, int stride) @@ -80,7 +82,6 @@ void ff_h264_idct_add_8_mmi(uint8_t *dst, int16_t *block, int stride) double ftmp[12]; uint64_t tmp[1]; DECLARE_VAR_LOW32; - DECLARE_VAR_ALL64; DECLARE_VAR_ADDRT; __asm__ volatile ( @@ -152,6 +153,11 @@ void ff_h264_idct_add_8_mmi(uint8_t *dst, int16_t *block, int stride) MMI_SWC1(%[ftmp2], %[dst], 0x00) "packushb %[ftmp0], %[ftmp0], %[ftmp7] \n\t" MMI_SWXC1(%[ftmp0], %[dst], %[stride], 0x00) + + /* memset(block, 0, 32) */ + "xor %[ftmp0], %[ftmp0], %[ftmp0] \n\t" + "gssqc1 %[ftmp0], %[ftmp0], 0x00(%[block]) \n\t" + "gssqc1 %[ftmp0], %[ftmp0], 0x10(%[block]) \n\t" : [ftmp0]"=&f"(ftmp[0]), [ftmp1]"=&f"(ftmp[1]), [ftmp2]"=&f"(ftmp[2]), [ftmp3]"=&f"(ftmp[3]), [ftmp4]"=&f"(ftmp[4]), [ftmp5]"=&f"(ftmp[5]), @@ -159,7 +165,6 @@ void ff_h264_idct_add_8_mmi(uint8_t *dst, int16_t *block, int stride) [ftmp8]"=&f"(ftmp[8]), [ftmp9]"=&f"(ftmp[9]), [ftmp10]"=&f"(ftmp[10]), [ftmp11]"=&f"(ftmp[11]), RESTRICT_ASM_LOW32 - RESTRICT_ASM_ALL64 RESTRICT_ASM_ADDRT [tmp0]"=&r"(tmp[0]) : [dst]"r"(dst), [block]"r"(block), @@ -167,7 +172,6 @@ void ff_h264_idct_add_8_mmi(uint8_t *dst, int16_t *block, int stride) : "memory" ); - memset(block, 0, 32); } void ff_h264_idct8_add_8_mmi(uint8_t *dst, int16_t *block, int stride) @@ -176,7 +180,6 @@ void ff_h264_idct8_add_8_mmi(uint8_t *dst, int16_t *block, int stride) uint64_t tmp[7]; mips_reg addr[1]; DECLARE_VAR_LOW32; - DECLARE_VAR_ALL64; DECLARE_VAR_ADDRT; __asm__ volatile ( @@ -617,6 +620,17 @@ void ff_h264_idct8_add_8_mmi(uint8_t *dst, int16_t *block, int stride) MMI_SWC1(%[ftmp6], %[addr0], 0x00) MMI_SWXC1(%[ftmp7], %[addr0], %[stride], 0x00) PTR_ADDIU "$29, $29, 0x20 \n\t" + + /* memset(block, 0, 128) */ + "xor %[ftmp0], %[ftmp0], %[ftmp0] \n\t" + "gssqc1 %[ftmp0], %[ftmp0], 0x00(%[block]) \n\t" + "gssqc1 %[ftmp0], %[ftmp0], 0x10(%[block]) \n\t" + "gssqc1 %[ftmp0], %[ftmp0], 0x20(%[block]) \n\t" + "gssqc1 %[ftmp0], %[ftmp0], 0x30(%[block]) \n\t" + "gssqc1 %[ftmp0], %[ftmp0], 0x40(%[block]) \n\t" + "gssqc1 %[ftmp0], %[ftmp0], 0x50(%[block]) \n\t" + "gssqc1 %[ftmp0], %[ftmp0], 0x60(%[block]) \n\t" + "gssqc1 %[ftmp0], %[ftmp0], 0x70(%[block]) \n\t" : [ftmp0]"=&f"(ftmp[0]), [ftmp1]"=&f"(ftmp[1]), [ftmp2]"=&f"(ftmp[2]), [ftmp3]"=&f"(ftmp[3]), [ftmp4]"=&f"(ftmp[4]), [ftmp5]"=&f"(ftmp[5]), @@ -630,7 +644,6 @@ void ff_h264_idct8_add_8_mmi(uint8_t *dst, int16_t *block, int stride) [tmp4]"=&r"(tmp[4]), [tmp5]"=&r"(tmp[5]), [tmp6]"=&r"(tmp[6]), RESTRICT_ASM_LOW32 - RESTRICT_ASM_ALL64 RESTRICT_ASM_ADDRT [addr0]"=&r"(addr[0]) : [dst]"r"(dst), [block]"r"(block), @@ -638,7 +651,6 @@ void ff_h264_idct8_add_8_mmi(uint8_t *dst, int16_t *block, int stride) : "$29","memory" ); - memset(block, 0, 128); } void ff_h264_idct_dc_add_8_mmi(uint8_t *dst, int16_t *block, int stride)