From patchwork Tue Sep 4 08:15:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jeyapal, Karthick" X-Patchwork-Id: 10228 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:12c4:0:0:0:0:0 with SMTP id 65-v6csp3591175jap; Tue, 4 Sep 2018 01:16:11 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbxKsEz2sGR3YZXvAz9hwGfvm1B2FIiPbnfycP0RyapIakHq2yPS+6WZmgpLbyrIonh5Goj X-Received: by 2002:a5d:61c1:: with SMTP id q1-v6mr22806979wrv.33.1536048971786; Tue, 04 Sep 2018 01:16:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536048971; cv=none; d=google.com; s=arc-20160816; b=inj5UU/JpEprX9mQU4VApbJ8zPbcG5T/tW+fI/SRnowoyepiTgrJKXexfpwqjZXfbn ZY6ghB+JwMtbV0wfDP5Jh3pD0CqD+u8PpCCu08RrMYo/CNiJM58Xu1TC3/yo7swjCUm5 hLLexCqkLkGRgeRVQbP/153AXRs0D18cyWVo1kR2wFBQu35KcSP/NlTdrmHy6m+SOgbN hsxoDy+G9jRk1YORYpKKhCNhNDo4eX7kCJF3lULZ7dA+hsw8clHCOLnf8wmi4550uHHu Ay0zWjX7YW5xHlqjUflP6hxSwsTLY176jgGgAzOLpakQvCpk1c6ksq4zEY/ijv9YavLw KL0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:feedback-id:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to :arc-authentication-results; bh=qepPTElSfA33tZT6fWd1QA29cP60jk83HdLqUJ2tWqg=; b=Nv2uA6P3dvKJM5LS7i+xzkf6y9sRS1t/uVqk3qHRX7IBLTmwbP0YJzckIIUwmKn0oT AE9gMAPrVVcuJQTOLJ7NaU6l12qjS7xZoyT5my588gH/fGrBmDjyHAOR5otVB6TUnfOV ymlXLo4u+fSxH6I4yzlXpn0m6UJNWkokzN5cKReAxTCHNWUnWQWWLvmILXeONHSJSNXv V6Kqf04ffKQgkDYTPs5yx7L8gPx9RuKSL2BcXUv1DhPGkhKXBXv31lqy7CEX+R61/0FR YuREDdl08ijCply6RhNmbg4DvKrNis0lT6mEvjOyAgswgbA3KvxIuif/rc5VXQ2SvN7m 0FiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@smtpservice.net header.s=m78bu0.a1-4.dyn header.b=TtnccDFi; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=akamai.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id s62-v6si11568167wmb.179.2018.09.04.01.16.11; Tue, 04 Sep 2018 01:16:11 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@smtpservice.net header.s=m78bu0.a1-4.dyn header.b=TtnccDFi; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=akamai.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9773F689EB1; Tue, 4 Sep 2018 11:16:02 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from a1i318.smtp2go.com (a1i318.smtp2go.com [43.228.185.62]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8511E689E96 for ; Tue, 4 Sep 2018 11:15:56 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpservice.net; s=m78bu0.a1-4.dyn; x=1536049868; h=Feedback-ID: X-Smtpcorp-Track:Message-Id:Date:Subject:To:From:Reply-To:Sender: List-Unsubscribe; bh=F8e/dNGt0xNmrgkhPB3uHPHQX4/5WY/WiSxIFzowhl0=; b=TtnccDFi 5X/RuwVLJVEec5uxz6UAjS8wRXTc8aocuKIkAmDsWxl1aUdiGd9p1PtIgl8LnYlUG6V9U+PNsdQ+3 R68zHCeaU8baF5x0J0IPMtedJrwghoX1sL63qNXndUDlqH4dQgD7v/X64NKV6N4qBJQcUDtP38Fxk Ap+oMF/7napf9TCeukvRlUHABBldRPuGP6uSP36lw4kOxvmRKV7UsfvSajGI660TrB9Cumr7BWEpi bWIGLEjTq++0odL5j7uqut7yHaPIHZOxLL4lE711V88HO1Qxwm4VgY27VC8ve9A239sNhEK84e5ux MWF6bgn3lCMtIC4UZxxIQt1Qig==; Received: from [10.45.79.71] (helo=SmtpCorp) by smtpcorp.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.91) (envelope-from ) id 1fx6VE-Itk9Kr-AO; Tue, 04 Sep 2018 08:16:00 +0000 Received: from [10.125.17.166] (helo=gmail.com) by smtpcorp.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.91) (envelope-from ) id 1fx6VD-DuubcY-3n; Tue, 04 Sep 2018 08:15:59 +0000 Received: from gmail.com (localhost [127.0.0.1]) by gmail.com (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id w848FtAG027428; Tue, 4 Sep 2018 13:45:55 +0530 Received: (from akamai@localhost) by gmail.com (8.14.4/8.14.4/Submit) id w848FtN5027427; Tue, 4 Sep 2018 13:45:55 +0530 From: Karthick J To: ffmpeg-devel@ffmpeg.org Date: Tue, 4 Sep 2018 13:45:48 +0530 Message-Id: <1536048948-27353-2-git-send-email-kjeyapal@akamai.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1536048948-27353-1-git-send-email-kjeyapal@akamai.com> References: <1536048948-27353-1-git-send-email-kjeyapal@akamai.com> X-Smtpcorp-Track: 1fx6VDDIIPcY3n.Mn8AdcI4D Feedback-ID: 337386m:337386asVRLGB:337386sHD87qlUy1:SMTPCORP X-Report-Abuse: Please forward a copy of this message, including all headers, to Subject: [FFmpeg-devel] [PATCH v2 2/2] avformat/dashenc: Remove muxer overhead from Bandwidth field in DASH manifest X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Karthick Jeyapal MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Karthick Jeyapal Fixes bug id #7386 Muxer overhead calculations was intented for HLS playlist as Apple's mediastreamvalidator tests were failing. But applying the same fix for DASH manifest proved counterproductive, as Bandwidth can be used for segment name templates. --- libavformat/dashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index c36ab12..2564b9e 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -611,7 +611,7 @@ static int write_adaptation_set(AVFormatContext *s, AVIOContext *out, int as_ind if (os->bit_rate > 0) snprintf(bandwidth_str, sizeof(bandwidth_str), " bandwidth=\"%d\"", - os->bit_rate + os->muxer_overhead); + os->bit_rate); if (as->media_type == AVMEDIA_TYPE_VIDEO) { AVStream *st = s->streams[i];