From patchwork Sun Sep 30 09:15:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Zhong Li X-Patchwork-Id: 10517 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:ab0:73d2:0:0:0:0:0 with SMTP id m18csp429933uaq; Sun, 30 Sep 2018 02:14:07 -0700 (PDT) X-Google-Smtp-Source: ACcGV63zlDc0UiZi1Xn88itOw+8T3WN9yrZGfSYW15LTAm5dMUA/EYQb1GFqdewhCAAwS4pJgrIj X-Received: by 2002:a5d:4fcf:: with SMTP id h15-v6mr3514769wrw.261.1538298847078; Sun, 30 Sep 2018 02:14:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538298847; cv=none; d=google.com; s=arc-20160816; b=tUfVg8ZB1VWpYRLjkIzhtrXuC5XY3U5NHqRf+aBs7tXLzITlErpe8+BVJMjsuWLssc ZQfttq86ui9Vjv/6xzznLdHX+ySn0/goHMj/jLNEsqAxJg0r3ABIA8PgP4Y6QL+PAaxa BnPgHmVYgTbspOy6e8+taDn6ex42cCl2v5xdPaPSvsMT26Z4isn/6QZRn8FR8oHPdtvC 25a7wwj6i5h1SUL2L04+dJ860/MVz70/NibzhOVHdXgXCHNUN3ZHs+/afoiFbea1JXxT mxuwD1wbi5DNw+qloWmsNkT4gD6peD4hPhLmTJHWAaImoGCIre4iw5l7ZRNxtu2TpaKc mQ9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=dbDk2Y608IJ/+wCzmRBNLnJgZWpQFttsDfrHRMYi2BY=; b=CzwlQX5MCOyJ4tmd0wSQDJfKwrBap4bCcz8bWCkBjW/ZPB8kS3X9/CgGJ+ukWEEPu6 P9xUrmAB1ax7xQPNIurlJ2AAQH47+U9F1bPfCkiyNPst9JLEmQqAQVVQTqW7bsNnNCuh J1YFP4zOMiHYgP8G3p8K49b70bW7nEJRhLqk1jhjuWk96AUIZnFG3wenUt6uDNiX4CeB bDXpaBiSMxaO3pDHhkpOnNp7e5oTgVWuwMqG1TNCiJiaB3kA0vQk9y8H+xJ0KpYlFgld 4ZMNlreTZ4KjNRUmM430riNZbTfMoRK1EBID2bfFU1+AlwmYj1gFFHIZJmxdwvuz+I4V ZBcw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id d11-v6si9527528wrm.61.2018.09.30.02.14.06; Sun, 30 Sep 2018 02:14:07 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7DC8968A15F; Sun, 30 Sep 2018 12:13:46 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0457068A145 for ; Sun, 30 Sep 2018 12:13:39 +0300 (EEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Sep 2018 02:13:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,323,1534834800"; d="scan'208";a="94727304" Received: from media_ffmpeg_skl_e3.sh.intel.com ([10.239.156.42]) by fmsmga001.fm.intel.com with ESMTP; 30 Sep 2018 02:13:55 -0700 From: Zhong Li To: ffmpeg-devel@ffmpeg.org Date: Sun, 30 Sep 2018 17:15:10 +0800 Message-Id: <1538298911-27149-1-git-send-email-zhong.li@intel.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/2] lavu/qsv: fix a random hwupload failure regression X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhong Li Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Variable 'ret' hasn't been initialized,thus introducing a random hwupload failure regression due to qsv session uninitialized. Signed-off-by: Zhong Li --- libavutil/hwcontext_qsv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c index cb3e184..33e121b 100644 --- a/libavutil/hwcontext_qsv.c +++ b/libavutil/hwcontext_qsv.c @@ -861,7 +861,7 @@ static int qsv_transfer_data_to(AVHWFramesContext *ctx, AVFrame *dst, mfxSyncPoint sync = NULL; mfxStatus err; - int ret; + int ret = 0; while (!s->session_upload_init && !s->session_upload && !ret) { #if HAVE_PTHREADS