From patchwork Thu Jun 20 13:43:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jun Zhao X-Patchwork-Id: 13647 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 6CBB2448958 for ; Thu, 20 Jun 2019 16:52:15 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4744268AAEB; Thu, 20 Jun 2019 16:52:15 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9FEC968AAEA for ; Thu, 20 Jun 2019 16:52:08 +0300 (EEST) Received: by mail-pf1-f196.google.com with SMTP id r1so1705977pfq.12 for ; Thu, 20 Jun 2019 06:52:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=aea1x/kk6E0AUvieRgx6a+5nRXOecpLfmVm9HfcRAjk=; b=RZjjCZQfiJbPbj1f9xCHVM5kCCAOLEe/9UoMusGt7Sj6Lyd1N0g9BKvZl1cXoaD8Cl 0jGQS6siOQ9KOzdy2Shm/SNxdNKYgV/h1d84tFatOCDi1L4PxzMHSsiRCyaD397tV5+1 QwQDFv0c2oU98o8iGtf2H46vlYgIgT+0fCcRV0h0bFGaVYEL6x1da8Pjm16P1PiLu2zS eZ1YnmGdy0eRpIneUlSez7SH5dl4OPbGvYUckXt8BH3W2hi1MEgBRxPt8L59G8EQfzKR YjVP9NwgYEQ/Za/f6ZdAX7UYd4+COrRHMiyskcZ+n8Go7tjLQL/9ygDOP/q61teHKyb3 mNzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=aea1x/kk6E0AUvieRgx6a+5nRXOecpLfmVm9HfcRAjk=; b=i8uTKsrCGYnvljeTAN8PzfRy+g90ZCjZv38D7Uh6KNpujAx2xI/UmoJEpNIiLEaryd Svq8Mr2O/lEtjpxvJVgMFnFF4irfwvrCYlRXmSdtoOy2jUgpzqKk4kU4aXADkkKcl8qr c/cEmFaq9nEJafd4izrScXILC08zC4RREwlpeqy4JuBuppO/fdmoo8UWy0h/WGLmjUrH CNdsjVHFneyD/UM14s8fAz5TAajQYsPkybqN/XJ4otucxmjMqmm/yJ+rH/83hUlf/ziW Q65X6qIWgfL6u4Q9FOK6p3J6aPstJvW0UymAd+XNea3WCrcV+8OfOERSMpWyh6BXlHs6 UJtg== X-Gm-Message-State: APjAAAWOe+H3U0YzS7K342YqIgpY7xZIMEzQ9EOHrA5xxCkuW8LLurw9 cpWLFMk+OaZkXCJlbIWLsD1C2aNU X-Google-Smtp-Source: APXvYqyLNKmO8nEsYhKwRDkyzhEsthXEgSg4pZA7EyDhMD0Az/BXV6PW7YWEMUEyB2297ty5jVvyzw== X-Received: by 2002:aa7:9190:: with SMTP id x16mr117781527pfa.86.1561038231039; Thu, 20 Jun 2019 06:43:51 -0700 (PDT) Received: from localhost.localdomain ([47.90.47.25]) by smtp.gmail.com with ESMTPSA id f10sm18674908pgo.14.2019.06.20.06.43.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Jun 2019 06:43:50 -0700 (PDT) From: Jun Zhao To: ffmpeg-devel@ffmpeg.org Date: Thu, 20 Jun 2019 21:43:46 +0800 Message-Id: <1561038226-451-1-git-send-email-mypopydev@gmail.com> X-Mailer: git-send-email 1.7.1 Subject: [FFmpeg-devel] [PATCH V1] lavfi/normalize: improve the performance X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jun Zhao MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Jun Zhao Remove unnecessary max value found, it's will improve the performance about 10%. Used the test command like: ffmpeg -i 1080P.mp4 -an -vf normalize -f null /dev/null, the FPS change from 96fps to 107fps. Signed-off-by: Jun Zhao --- libavfilter/vf_normalize.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_normalize.c b/libavfilter/vf_normalize.c index 48eea59..40dc031 100644 --- a/libavfilter/vf_normalize.c +++ b/libavfilter/vf_normalize.c @@ -143,14 +143,13 @@ static void normalize(NormalizeContext *s, AVFrame *in, AVFrame *out) min[c].in = max[c].in = in->data[0][s->co[c]]; for (y = 0; y < in->height; y++) { uint8_t *inp = in->data[0] + y * in->linesize[0]; - uint8_t *outp = out->data[0] + y * out->linesize[0]; for (x = 0; x < in->width; x++) { for (c = 0; c < 3; c++) { - min[c].in = FFMIN(min[c].in, inp[s->co[c]]); - max[c].in = FFMAX(max[c].in, inp[s->co[c]]); + uint8_t val = inp[s->co[c]]; + if (val < min[c].in) min[c].in = val; + else if (val > max[c].in) max[c].in = val; } inp += s->step; - outp += s->step; } }