diff mbox

[FFmpeg-devel,V2,2/2] lavf/showinfo: use error level when get invalid sidedata

Message ID 1565001561-8992-3-git-send-email-mypopydev@gmail.com
State Accepted
Commit e282b7ed7bf8d70135c03ec5555c994f2707009e
Headers show

Commit Message

Jun Zhao Aug. 5, 2019, 10:39 a.m. UTC 
From: Jun Zhao <barryjzhao@tencent.com>

Use error level when get invalid sidedata, and remove a unnecessary
newline in error message.

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
 libavfilter/vf_showinfo.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Comments

Michael Niedermayer Aug. 5, 2019, 8:38 p.m. UTC | #1 
On Mon, Aug 05, 2019 at 06:39:21PM +0800, Jun Zhao wrote:
> From: Jun Zhao <barryjzhao@tencent.com>
> 
> Use error level when get invalid sidedata, and remove a unnecessary
> newline in error message.
> 
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
>  libavfilter/vf_showinfo.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

should be ok

thx


[...]
diff mbox

Patch

diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c
index d5c444e..9fa322e 100644
--- a/libavfilter/vf_showinfo.c
+++ b/libavfilter/vf_showinfo.c
@@ -62,7 +62,7 @@  static void dump_spherical(AVFilterContext *ctx, AVFrame *frame, AVFrameSideData
 
     av_log(ctx, AV_LOG_INFO, "spherical information: ");
     if (sd->size < sizeof(*spherical)) {
-        av_log(ctx, AV_LOG_INFO, "invalid data");
+        av_log(ctx, AV_LOG_ERROR, "invalid data");
         return;
     }
 
@@ -100,7 +100,7 @@  static void dump_stereo3d(AVFilterContext *ctx, AVFrameSideData *sd)
 
     av_log(ctx, AV_LOG_INFO, "stereoscopic information: ");
     if (sd->size < sizeof(*stereo)) {
-        av_log(ctx, AV_LOG_INFO, "invalid data");
+        av_log(ctx, AV_LOG_ERROR, "invalid data");
         return;
     }
 
@@ -121,7 +121,7 @@  static void dump_roi(AVFilterContext *ctx, AVFrameSideData *sd)
     roi = (const AVRegionOfInterest *)sd->data;
     roi_size = roi->self_size;
     if (!roi_size || sd->size % roi_size != 0) {
-        av_log(ctx, AV_LOG_ERROR, "Invalid AVRegionOfInterest.self_size.\n");
+        av_log(ctx, AV_LOG_ERROR, "Invalid AVRegionOfInterest.self_size.");
         return;
     }
     nb_rois = sd->size / roi_size;