From patchwork Sat Sep 21 02:12:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jun Zhao X-Patchwork-Id: 15200 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 9D4D044A3A0 for ; Sat, 21 Sep 2019 05:40:26 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 712BA68A539; Sat, 21 Sep 2019 05:40:26 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 442C9688154 for ; Sat, 21 Sep 2019 05:40:20 +0300 (EEST) Received: by mail-io1-f67.google.com with SMTP id n197so20516678iod.9 for ; Fri, 20 Sep 2019 19:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=YSldrzB4jFRLI8sPam6/lF0QIto0ZXNbAMVPV6YEyGs=; b=Xj9r6+dq1oUHoXU3Bhj/tVEWJ5RbC0vLw0scLLnEWIznQ+KA4La6cY+Q9+HkYjFcFZ HZGL7qEf4wKNDSqmA6r+VyvTagPAhA3ANXk4BAH7GIzxY65NHzfdgwigLik5DHpo2ZvE ECXxErvWmV6Jm7ewT5AgLj1BobjhVP1PdxtL3r2Hs/lSc0dlqqKJQb3pAVB8DlWuYezd N23LBJ/Q7oB5ANGk8ixTeA4+dvAzOSjlC5dzF47Hio2yBVXAQysW9SXNEIXGW/vydOC1 1gG5WoovqGjkpQZnlMRtcTPZNkjs200lIuk9muSatlXuiMfNyiFnuH+HcaQMRlBRfsP3 3VYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=YSldrzB4jFRLI8sPam6/lF0QIto0ZXNbAMVPV6YEyGs=; b=resVDdFYe58iii/N9AHUYT0aNlfJKHX09jotP1GSnbcxLBH0+vKQSPQ2Rqc2yxGHC8 UzeGUwwvD9NGP5h5vF83olArDtwWl6b2H4+xUiQsMDSzTjKrgq7mACMIs7P9qapSsVdM YMsr5UNiJYDrJl1nOXkMQv44ZwK6pfG7PckF8ft4ihMHj39KefbaNDezoX8FtpbfZLyS wAuSVp3TQBHTqGHrJEoMH1Y7wHSM0eMCcCdi93AYYKF2PI5SCtSppyo94xaIsjLh+lQ7 i6h/ivjiHpz9g5nXzrGQ7wJv4dSJbPAp+B8nelal3UegerN6SDaOMA4jMVm75V3y5tFU 7W9g== X-Gm-Message-State: APjAAAWexXWldhTR1mTI46htjZeFvhtDtErUOdtUND0MacmVY+x7AF5L DYVnS/b8trmIHlYBbdYVl44zQ8gQ X-Google-Smtp-Source: APXvYqwDHetHUx12OGR4IWwzMtb4YTM40i5/G+2FBVd3XAfEjxY65grQ5/ijENxkZwdNEDiTUmHFbg== X-Received: by 2002:a63:ee08:: with SMTP id e8mr16098042pgi.70.1569031939874; Fri, 20 Sep 2019 19:12:19 -0700 (PDT) Received: from localhost.localdomain ([47.90.47.25]) by smtp.gmail.com with ESMTPSA id l7sm8986688pga.92.2019.09.20.19.12.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Sep 2019 19:12:19 -0700 (PDT) From: Jun Zhao To: ffmpeg-devel@ffmpeg.org Date: Sat, 21 Sep 2019 10:12:10 +0800 Message-Id: <1569031935-8967-1-git-send-email-mypopydev@gmail.com> X-Mailer: git-send-email 1.7.1 Subject: [FFmpeg-devel] [PATCH V1 1/6] lavf/4xm: fix memory leak in error handing path X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jun Zhao MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Jun Zhao need to free the header in error path Signed-off-by: Jun Zhao --- libavformat/4xm.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libavformat/4xm.c b/libavformat/4xm.c index a984fc9..8054980 100644 --- a/libavformat/4xm.c +++ b/libavformat/4xm.c @@ -241,6 +241,7 @@ static int fourxm_read_header(AVFormatContext *s) size = AV_RL32(&header[i + 4]); if (size > header_size - i - 8 && (fourcc_tag == vtrk_TAG || fourcc_tag == strk_TAG)) { av_log(s, AV_LOG_ERROR, "chunk larger than array %d>%d\n", size, header_size - i - 8); + av_free(header); return AVERROR_INVALIDDATA; }