From patchwork Tue Nov 12 09:09:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhong Li X-Patchwork-Id: 16218 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 1314344A05F for ; Tue, 12 Nov 2019 11:40:45 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E5B7568A9AA; Tue, 12 Nov 2019 11:40:44 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from m15-113.126.com (m15-113.126.com [220.181.15.113]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EEC7F68A67E for ; Tue, 12 Nov 2019 11:40:37 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id; bh=LX+aLCmNK3GEkpgCXg DDtmg2weta/2Sqak8EhdBh/Ls=; b=VEEG4pl13GvAAOcdcaRVzjkwL7io8TmqgL zxBVTZHszMtXIh9kFG7J0Arghm++oh4Br+evTCYnhO/s4Szq0zTXWsp/TjKyVvIe BWDctdGg9mtLlt3NLfX6ZTaTCGIbrQTfXiGS/rqUzIv7q7W8WO9/u8hNb1Tho+AN 0J81lhaW8= Received: from localhost.localdomain (unknown [140.205.147.88]) by smtp3 (Coremail) with SMTP id DcmowAC3ge7EdspdzGzpAQ--.14666S2; Tue, 12 Nov 2019 17:09:25 +0800 (CST) From: Zhong Li To: ffmpeg-devel@ffmpeg.org Date: Tue, 12 Nov 2019 09:09:20 +0000 Message-Id: <1573549761-69180-1-git-send-email-zhongli_dev@126.com> X-Mailer: git-send-email 1.8.3.1 X-CM-TRANSID: DcmowAC3ge7EdspdzGzpAQ--.14666S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7CFyxAF4UXFWDtr4xuF4kWFg_yoW8Zry8pr 15Xrs5Kr17KF18AF95A3yrXa4UAryfWFsxGa1j9w4xAw1IvrsFqw13CFyY9ayDW3yvqay2 v3yF9a4rCw47Jw7anT9S1TB71UUUUUDqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07U8b1nUUUUU= X-Originating-IP: [140.205.147.88] X-CM-SenderInfo: x2kr0wxolbvvby6rjloofrz/1tbiHAVrwFpD+H1-FgAAsH Subject: [FFmpeg-devel] [PATCH 1/2] lavc/rav1e: log and doc updated for const quantizer mode X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhong Li MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Signed-off-by: Zhong Li --- doc/encoders.texi | 2 +- libavcodec/librav1e.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 6cf3a74093..6b02c7798d 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -1395,7 +1395,7 @@ Sets the maximum quantizer to use when using bitrate mode. Sets the minimum quantizer to use when using bitrate mode. @item qp -Uses quantizer mode to encode at the given quantizer. +Uses quantizer mode to encode at the given quantizer (0-255). @item speed Selects the speed preset (0-10) to encode with. diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c index 5052cac896..f25d91bb95 100644 --- a/libavcodec/librav1e.c +++ b/libavcodec/librav1e.c @@ -356,7 +356,7 @@ static av_cold int librav1e_encode_init(AVCodecContext *avctx) } } else if (ctx->quantizer >= 0) { if (avctx->bit_rate) - av_log(avctx, AV_LOG_WARNING, "Both bitrate and quantizer specified. Using quantizer mode."); + av_log(avctx, AV_LOG_WARNING, "Both bitrate and quantizer specified. Using const quantizer mode."); rret = rav1e_config_parse_int(cfg, "quantizer", ctx->quantizer); if (rret < 0) { @@ -533,7 +533,7 @@ retry: #define VE AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM static const AVOption options[] = { - { "qp", "use constant quantizer mode", OFFSET(quantizer), AV_OPT_TYPE_INT, { .i64 = 100 }, -1, 255, VE }, + { "qp", "qp value of constant quantizer mode", OFFSET(quantizer), AV_OPT_TYPE_INT, { .i64 = 100 }, -1, 255, VE }, { "speed", "what speed preset to use", OFFSET(speed), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 10, VE }, { "tiles", "number of tiles encode with", OFFSET(tiles), AV_OPT_TYPE_INT, { .i64 = 0 }, -1, INT64_MAX, VE }, { "tile-rows", "number of tiles rows to encode with", OFFSET(tile_rows), AV_OPT_TYPE_INT, { .i64 = 0 }, -1, INT64_MAX, VE },