diff mbox

[FFmpeg-devel,V1,1/2] lavf/rtmpproto: Don't unref uninitialized buffers

Message ID 1575370860-26345-1-git-send-email-mypopydev@gmail.com
State Accepted
Commit 70e292becf3fc62535aefd6b48c5834f89eed7f4
Headers show

Commit Message

Jun Zhao Dec. 3, 2019, 11 a.m. UTC
From: Jun Zhao <barryjzhao@tencent.com>

This happens if ffurl_open_whitelist fails and stream is unset.

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
 libavformat/rtmpproto.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Steven Liu Dec. 3, 2019, 1:26 p.m. UTC | #1
> 在 2019年12月3日,下午7:00,Jun Zhao <mypopydev@gmail.com> 写道:
> 
> From: Jun Zhao <barryjzhao@tencent.com>
> 
> This happens if ffurl_open_whitelist fails and stream is unset.
> 
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
> libavformat/rtmpproto.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c
> index 5274993..42aacbd 100644
> --- a/libavformat/rtmpproto.c
> +++ b/libavformat/rtmpproto.c
> @@ -1111,7 +1111,7 @@ static int rtmp_calc_swfhash(URLContext *s)
>     RTMPContext *rt = s->priv_data;
>     uint8_t *in_data = NULL, *out_data = NULL, *swfdata;
BTW, swf_data = NULL too.
>     int64_t in_size;
BTW in_size = 0.
> -    URLContext *stream;
> +    URLContext *stream = NULL;
>     char swfhash[32];
>     int swfsize;
BTW, swfsize = 0.
>     int ret = 0;
> -- 
> 1.7.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".



Steven
Thanks
diff mbox

Patch

diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c
index 5274993..42aacbd 100644
--- a/libavformat/rtmpproto.c
+++ b/libavformat/rtmpproto.c
@@ -1111,7 +1111,7 @@  static int rtmp_calc_swfhash(URLContext *s)
     RTMPContext *rt = s->priv_data;
     uint8_t *in_data = NULL, *out_data = NULL, *swfdata;
     int64_t in_size;
-    URLContext *stream;
+    URLContext *stream = NULL;
     char swfhash[32];
     int swfsize;
     int ret = 0;