From patchwork Wed Jan 1 05:20:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jun Zhao X-Patchwork-Id: 17103 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id CA9E744AC6A for ; Wed, 1 Jan 2020 07:20:53 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9E05068A435; Wed, 1 Jan 2020 07:20:53 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7EB9A687FB5 for ; Wed, 1 Jan 2020 07:20:46 +0200 (EET) Received: by mail-pg1-f195.google.com with SMTP id r11so20285794pgf.1 for ; Tue, 31 Dec 2019 21:20:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=GRqmA0lXZxsz6cvrFBOFvUkPiFGZBRN3ZzAvjjBtUPw=; b=dN0vtMQ5wOTRzCnIFlCSs9Ee4HDkvGEYxvfYEhJnkla4vCvd6HT+pDLZzuBWlmTHDe LFaRPs3HXAzckmw/YIQwnc0uvKVAfHTPEXqrGMuBFBrXDcuQ9AMRkFLh7MTixLBLIZhF 1Bi7BfpCSvNYtWxBQwmZvGGfKxUKNF7RaWneTSMWnPwoEPb9JCa+DcSD2z7uMsft1APv yOmevRifUl+Y4ZTTwFQ2SD0vxkAUP0pa7P6VucR28ZGDPHNBmXhIh54C/tLuq/uQkYRj kxa5kg6HGVpohiEKZLP6pHUcgZlkzTX8u8xlgAuni4agAZx/jBiDUYmeH0N1JFR1mwqh e58w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=GRqmA0lXZxsz6cvrFBOFvUkPiFGZBRN3ZzAvjjBtUPw=; b=pauoC5Z0yDQpHeyYFk49/LLlRfKXY47usKYWvg0CX0d29H2+n8Zmydjnln23NF5QKw pLPgN+zUmncOCjysBiX6VOMTBW/hVOkZkvWcIyIarJyeEdfSPAUWmBwxRiMqB1Ct2Nsx 5lWLsoDpvS1msHUn5KkcNhfJ8T9NEzav4Vrej/v6+D9c1VHRa04ULoOCHiN8wXqUAg+Q /pw9oGPY6hFTcmLSNJJRPfoa0ZjQsNEwzkIUgAvwWqFxNQrxzze/2a0f8AjBvVp0i5NE 4LKfrV2H9Wl2mvVUE6swqc14ZgNj5XYDulJwys1d1t/Tielh5UHfc4/1bCoHme2pVQCQ W6IA== X-Gm-Message-State: APjAAAWthT2fw0vyBGSNkWlyo/Vm8njck7rM8NcaUrfq7wUjnP+6FTTW FpU6/o7jRCz/QRHVGD69osQHsbNo X-Google-Smtp-Source: APXvYqzBHStUwvI+xr75cQ7vG6SRGKAtIrEjr4PCsh/XdVRbfu4D/DL9K6r/YguVFdpEiMXKJGCi2g== X-Received: by 2002:aa7:8181:: with SMTP id g1mr82273211pfi.215.1577856044595; Tue, 31 Dec 2019 21:20:44 -0800 (PST) Received: from localhost.localdomain ([47.90.47.25]) by smtp.gmail.com with ESMTPSA id s15sm53908530pgq.4.2019.12.31.21.20.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Dec 2019 21:20:43 -0800 (PST) From: Jun Zhao To: ffmpeg-devel@ffmpeg.org Date: Wed, 1 Jan 2020 13:20:29 +0800 Message-Id: <1577856040-17409-1-git-send-email-mypopydev@gmail.com> X-Mailer: git-send-email 1.7.1 Subject: [FFmpeg-devel] [PATCH V1 01/12] lavc/bsf: fix memory leak after av_dict_parse_string fail X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jun Zhao MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Jun Zhao In case of failure, all the successfully set entries are stored in *pm. We need to manually free the created dictionary to avoid memory leak. Signed-off-by: Jun Zhao --- libavcodec/bsf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c index c1653cd..8e1af60 100644 --- a/libavcodec/bsf.c +++ b/libavcodec/bsf.c @@ -517,8 +517,8 @@ static int bsf_parse_single(const char *str, AVBSFList *bsf_lst) ret = av_bsf_list_append2(bsf_lst, bsf_name, &bsf_options); - av_dict_free(&bsf_options); end: + av_dict_free(&bsf_options); av_free(buf); return ret; }