From patchwork Wed Jan 1 05:20:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jun Zhao X-Patchwork-Id: 17104 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id BAF8D44AC6A for ; Wed, 1 Jan 2020 07:20:56 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A601368AD10; Wed, 1 Jan 2020 07:20:56 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4430D68AD1B for ; Wed, 1 Jan 2020 07:20:49 +0200 (EET) Received: by mail-pg1-f196.google.com with SMTP id z124so20243067pgb.13 for ; Tue, 31 Dec 2019 21:20:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xW91GX5xTyoTtDayWVhcJft9wjBK1VCWwyEydMBqiwo=; b=XPk+HuHXMxkc9IEKe/bDPXJ5R/JBxjNYtGIA6y8uw3Zc6LGuYm+b/cR25yaA4YyGKa h6seuJ9f7pqCn4i3woT5O29FTAJcvVNhFnmUjIZfx8qJEFhlrYHD75XrP+HBG9y8hENV o6e1yTrip+BcvML1ounmDMM9iwD+T1VOk23sJVYxsYVPZQtrvSBQfSlQigu1lHXJQnpN /Xefp3IA64xFpck0w8AH19Tr967T3K/4yyK3TmFVafL0rYssLsNQ+3vlTC7D79gAmWul YDVvKoQTrqmZcuUgeGedtAHoL1hPiDod3SI15JfEGOcVEw9jFNZCRk4s1SHzTfBRgbiX hg6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xW91GX5xTyoTtDayWVhcJft9wjBK1VCWwyEydMBqiwo=; b=gGw8Utx9eQg5QACuqpAoWc9Yz/3w1UUKyRPzvoPjGVqdO7GYEyzHi4GjB39nja51tq LYzPeECST3i6Nbz+9SO9Dv7blHf7xGTwwxaztfMWEB4rWbCx+e7vkh9Mzp2JHtgBtnr7 6uFRZxuZA0YRL5zDkVRdDd3gCzo14/+lpcqmwq8YGvV14Vtk+I+MaHCPi3PzWHJiATaS CcWWVg+Jh1E4rKQfHO3u83L/WFof7rICcBpeEDvN91pJ9eeRgG3jVN4Bq2QLIU57AeOM h0MUbDXQkwwOa5Tytbl4Bg1sgPRSiSL30/GjcSD6Xs8sUZQWm4qWBQEbflzciQsMdwDI cRZw== X-Gm-Message-State: APjAAAX2s2feBm/52Yr+8wHD44Rhc5rITL0uaECyCQm+7L9sZrInVFkb ercPKYgDGbpW2cnYCYJLf/i4UIm2 X-Google-Smtp-Source: APXvYqwIR106twv1942eg6G0sa+BtOF2hAmC/CAbTIAq7AQhHy6ZeRl1lA71d3ncQGJncW31S6GiSQ== X-Received: by 2002:aa7:96f9:: with SMTP id i25mr82690316pfq.161.1577856047706; Tue, 31 Dec 2019 21:20:47 -0800 (PST) Received: from localhost.localdomain ([47.90.47.25]) by smtp.gmail.com with ESMTPSA id s15sm53908530pgq.4.2019.12.31.21.20.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Dec 2019 21:20:47 -0800 (PST) From: Jun Zhao To: ffmpeg-devel@ffmpeg.org Date: Wed, 1 Jan 2020 13:20:30 +0800 Message-Id: <1577856040-17409-2-git-send-email-mypopydev@gmail.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1577856040-17409-1-git-send-email-mypopydev@gmail.com> References: <1577856040-17409-1-git-send-email-mypopydev@gmail.com> Subject: [FFmpeg-devel] [PATCH V1 02/12] lavc/libkvazaar: fix memory leak after av_dict_parse_string fail X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jun Zhao MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Jun Zhao In case of failure, all the successfully set entries are stored in *pm. We need to manually free the created dictionary to avoid memory leak. Signed-off-by: Jun Zhao --- libavcodec/libkvazaar.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c index a89ca7f..02bcae3 100644 --- a/libavcodec/libkvazaar.c +++ b/libavcodec/libkvazaar.c @@ -110,8 +110,8 @@ static av_cold int libkvazaar_init(AVCodecContext *avctx) entry->key, entry->value); } } - av_dict_free(&dict); } + av_dict_free(&dict); } ctx->encoder = enc = api->encoder_open(cfg);