From patchwork Wed Jan 1 05:20:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jun Zhao X-Patchwork-Id: 17105 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id ABB7644AC6A for ; Wed, 1 Jan 2020 07:20:58 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9718A68AD26; Wed, 1 Jan 2020 07:20:58 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 11C2F68AD1B for ; Wed, 1 Jan 2020 07:20:52 +0200 (EET) Received: by mail-pf1-f196.google.com with SMTP id x185so20454771pfc.5 for ; Tue, 31 Dec 2019 21:20:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MJMOWBDtDjZ3a9zS6i0kVan9dAg38AM9DRvfRfMfVYQ=; b=Neh6rH06G2MY1LI9yPngRsHT2ZxOdZ+NoQSf09gHxquFvOUUp0vXxgaiuQOBi/aCA2 mke2OxEGnKmCCrCUEXJ4v/wmbPDvcYvdOxAAey0Ok0Z/VJMEVHBZ+8f3JRYfVshhwAnd N4fIzXIAEvU7lcEPK0ci19/+bW+Ea0xVV/y/W/N/klbZ5WyUDt0YtCIFKVs3Xz0SBh+x ddU9U7B267Na2IHyeRCw+kpTkJ/BSz6k3dtvEHyZorOVMdrMEfufB/ukCItgPT8tflKT Avn7SdvGz8WuqsgA3r7Rn9MtCoJ3nmE1GLinQmj3DUoqgcHwhINO3uArr0ZnKlVosan7 NYjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MJMOWBDtDjZ3a9zS6i0kVan9dAg38AM9DRvfRfMfVYQ=; b=AtnuKB2Y31q6H8koAT4+MYWvNaHzHCwHidZ6e/pblztZgNzMfWTZTo+wFAEPydiqvq Mw29H5t2mwOdji3xNOYfD1wRBC9xfCd2HJ84zcBPsz3cSkY1kZMvF42wU6iWE516G8Tv sx+gRO4NwIUfx3InATfsfEHe7qCqhcQIvdHU69CM+CGg7WzBOSHmFPKYHQhA6Oc4X4Lk OSjlPlC2k2SIKPaDslXHm119xBKtMTfSCmVAVdlq4sGR21HGTOJZbyJD8GADrvQ/mfZy Se8lhyw40d52ObHX48kqs++pRjXXo89ZpM6dvczlO/LngQMQWw0SLBuoL7u9CLrQTJRS M1SQ== X-Gm-Message-State: APjAAAU/L13RM3WIxK7YFfvjlIH0OmDnC4lYQ9P+afJZbS1yZKs8qsAD yNrKSwPBeDC1VLm3am8j5moL8KUy X-Google-Smtp-Source: APXvYqyNOIucJu2MdK37loeTuCrF2EQcpAtNZwWOkOXG3+x6Dcu9vvnTDn71epPBPDSszcNyP3GRrg== X-Received: by 2002:a62:1857:: with SMTP id 84mr82032142pfy.257.1577856050306; Tue, 31 Dec 2019 21:20:50 -0800 (PST) Received: from localhost.localdomain ([47.90.47.25]) by smtp.gmail.com with ESMTPSA id s15sm53908530pgq.4.2019.12.31.21.20.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Dec 2019 21:20:50 -0800 (PST) From: Jun Zhao To: ffmpeg-devel@ffmpeg.org Date: Wed, 1 Jan 2020 13:20:31 +0800 Message-Id: <1577856040-17409-3-git-send-email-mypopydev@gmail.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1577856040-17409-1-git-send-email-mypopydev@gmail.com> References: <1577856040-17409-1-git-send-email-mypopydev@gmail.com> Subject: [FFmpeg-devel] [PATCH V1 03/12] lavc/librav1e: fix memory leak after av_dict_parse_string fail X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jun Zhao MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Jun Zhao In case of failure, all the successfully set entries are stored in *pm. We need to manually free the created dictionary to avoid memory leak. Signed-off-by: Jun Zhao --- libavcodec/librav1e.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c index a5aedd5..13ebe53 100644 --- a/libavcodec/librav1e.c +++ b/libavcodec/librav1e.c @@ -254,8 +254,8 @@ static av_cold int librav1e_encode_init(AVCodecContext *avctx) if (parse_ret < 0) av_log(avctx, AV_LOG_WARNING, "Invalid value for %s: %s.\n", en->key, en->value); } - av_dict_free(&dict); } + av_dict_free(&dict); } rret = rav1e_config_parse_int(cfg, "width", avctx->width);