From patchwork Wed Jan 1 05:20:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jun Zhao X-Patchwork-Id: 17107 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 905B844AD49 for ; Wed, 1 Jan 2020 07:21:10 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8128C68ADB3; Wed, 1 Jan 2020 07:21:10 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 500DA68AD73 for ; Wed, 1 Jan 2020 07:21:02 +0200 (EET) Received: by mail-pl1-f193.google.com with SMTP id p27so16494857pli.10 for ; Tue, 31 Dec 2019 21:21:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=L0zErQt7qcBY7Ru0Cw8YC3lvCX8nC26am7xKUFg4EGk=; b=Qi8Nz5MU67YmsnPzc6tYq5HF6wM6lYtrw2mqvieVL+gXFmL0zXwnAQ2DqAaVAwT7IP yq6BHzXgmd0xAnrJ8mGFSsPJafA/i8nK0AN6Ue9A+/Q4JodhJtUP4W4lox7Bgm6MXJWG 4gSlwPeIMCqaH+EbQLYN4W6+GxqpQL47o1ZPafNWjmI45fAmAMTC7s5BOVD0KjGZv8CF RRFADHeeOW7ZnjX0OcSOg3yEeibm0pbd6OoWQoFZtvhW738WouRdgj+WgUmtoh/8qwi8 O0y5YCtTJlm/J/UEI1xTWVmlow8w8amBK/8xVnwO8C3cYTd/sT/c0K5cKNu6L3Rwbq8M bpMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=L0zErQt7qcBY7Ru0Cw8YC3lvCX8nC26am7xKUFg4EGk=; b=d4GikdDrWyfCV1edHyL4323MCoHzHsOXVbjdXpS/TthHg6jGNj8FxAPxVXJpUFgokj 2NuJ8KZBAZO7491UBD6s4co6wLy0dJJukX0S8rHDGfmibPL2z6WCmJHrVpqW/PhAEAp0 zGvmVXyJjk3qX6fNMyJA4APHaCj2mVPRJI34OL0B1UeSz8YcGuEiwPWbXAHe+GI9p5ZH WuEEa2Gdi0B/iSLQFhO/KvQRQ+tlew+GWv+Oq6YPYyQQ5tFjInqGoYWbJvh1C9hZh+h1 6AGSrx7apzZ6cWHlUYvHOyZNYREuxzsvzysqpqDe2YoRntonV9dgCQ17NtkUMN/JwgYs D4LQ== X-Gm-Message-State: APjAAAUIsXvKKk1z7VQC7Xi+rs2mCxauG0MJBe8bA3elXJRYFaT8mhi3 d5whzcFdKU2CPO4m0jIFGQcX53Yr X-Google-Smtp-Source: APXvYqxSYAlWQNZrrKLdGmCWz9ycvnv8MBuiloRiqKfMzL2tWTeXfhjjjlrLoEoruldLlvf5dJ9f7Q== X-Received: by 2002:a17:902:8f85:: with SMTP id z5mr78806909plo.43.1577856060710; Tue, 31 Dec 2019 21:21:00 -0800 (PST) Received: from localhost.localdomain ([47.90.47.25]) by smtp.gmail.com with ESMTPSA id s15sm53908530pgq.4.2019.12.31.21.20.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Dec 2019 21:21:00 -0800 (PST) From: Jun Zhao To: ffmpeg-devel@ffmpeg.org Date: Wed, 1 Jan 2020 13:20:35 +0800 Message-Id: <1577856040-17409-7-git-send-email-mypopydev@gmail.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1577856040-17409-1-git-send-email-mypopydev@gmail.com> References: <1577856040-17409-1-git-send-email-mypopydev@gmail.com> Subject: [FFmpeg-devel] [PATCH V1 07/12] lavc/libxavs2: fix memory leak after av_dict_parse_string fail X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jun Zhao MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Jun Zhao In case of failure, all the successfully set entries are stored in *pm. We need to manually free the created dictionary to avoid memory leak. Signed-off-by: Jun Zhao --- libavcodec/libxavs2.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c index 2f8460a..91afeeb 100644 --- a/libavcodec/libxavs2.c +++ b/libavcodec/libxavs2.c @@ -100,8 +100,8 @@ static av_cold int xavs2_init(AVCodecContext *avctx) while ((en = av_dict_get(dict, "", en, AV_DICT_IGNORE_SUFFIX))) { xavs2_opt_set2(en->key, "%s", en->value); } - av_dict_free(&dict); } + av_dict_free(&dict); } /* Rate control */