From patchwork Thu Jan 2 11:55:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jun Zhao X-Patchwork-Id: 17129 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 903E644987A for ; Thu, 2 Jan 2020 13:55:18 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 68C9068AD22; Thu, 2 Jan 2020 13:55:18 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E206268ACE4 for ; Thu, 2 Jan 2020 13:55:11 +0200 (EET) Received: by mail-pj1-f68.google.com with SMTP id j11so3163615pjs.1 for ; Thu, 02 Jan 2020 03:55:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=GRqmA0lXZxsz6cvrFBOFvUkPiFGZBRN3ZzAvjjBtUPw=; b=ib7m5XcCESpQ3479wWHoD5mtWlJzBQmIx6usZuzzdSlvgaqOGNeGAzK7yOthTPYUL4 rqsxbe3lwf43dAGxvBtKMnuwrVjhUI8zfNEtnN0zALW/6i/ekZ5V6Pw8fdvlQccCR7db 5uhbpEgYRKHuKvsBO1PEQZGb5VZiK9iz4eLI10/Ul5r6jOHExgZBrGOCh6t/NOJXcxBm ReZecz9ofk5pQSRB8dN1NcnSyVnraAN3L6hpxBg1cXLtwcSH4jLIpPPp5mHraDdJZgOE go+EGTJjuKCBb2ahggZzLh7VIeio9kHX14tsXqrA7/AMqYHLhJ0I2NitfKFammxWcdMH XxoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=GRqmA0lXZxsz6cvrFBOFvUkPiFGZBRN3ZzAvjjBtUPw=; b=qlRJhJDNoKmJ9RIxPE+xpg3H1/Azn8udZwmKvqC8lmhW6q+7Okr95lP1YgwY28MOah M8owyoJ7mjpKlrtbh/LRBvWbpQViffPsVyyjMMF8Hs/s7vsugOHgecDaEcTApIMDXQtg clay7DCXy22A2kbsbFSyELnUD73IExG0Dv0xgIM/PUPXd8BZcmrgjVdxHETDDDNmOy5n DbG7cCHNFNQ3GpbgfWhb2aM9YxQTdZfEq/k5MX+rZ/2Z78Q2vjzgh+z3WNKaJsPfhIYf E7JzlN3jeY9iNLvPP6WsOt5w1GNt/6KP3pf39AYXjpR9NuVrcwJcq8M5GL68lzj+abL8 Dp6A== X-Gm-Message-State: APjAAAX+9RJNMILoa/Egl5uwm5L/K3XovdQ1YXmJqww9+tZ02GYweYb+ 1RDNShOXwlyxPl1D9kHhUocr+bRp X-Google-Smtp-Source: APXvYqxy9jfeDxKKXi8eXll8ezUaCC0bQwfGgRUqeYvOjcY0gn35BizQ9BfXPudNqiFpewJ8lbw00w== X-Received: by 2002:a17:90a:8a12:: with SMTP id w18mr19168800pjn.68.1577966109805; Thu, 02 Jan 2020 03:55:09 -0800 (PST) Received: from localhost.localdomain ([47.90.47.25]) by smtp.gmail.com with ESMTPSA id y76sm66267524pfc.87.2020.01.02.03.55.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Jan 2020 03:55:08 -0800 (PST) From: Jun Zhao To: ffmpeg-devel@ffmpeg.org Date: Thu, 2 Jan 2020 19:55:01 +0800 Message-Id: <1577966105-4642-1-git-send-email-mypopydev@gmail.com> X-Mailer: git-send-email 1.7.1 Subject: [FFmpeg-devel] [PATCH V2 1/5] lavc/bsf: fix memory leak after av_dict_parse_string fail X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jun Zhao MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Jun Zhao In case of failure, all the successfully set entries are stored in *pm. We need to manually free the created dictionary to avoid memory leak. Signed-off-by: Jun Zhao --- libavcodec/bsf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c index c1653cd..8e1af60 100644 --- a/libavcodec/bsf.c +++ b/libavcodec/bsf.c @@ -517,8 +517,8 @@ static int bsf_parse_single(const char *str, AVBSFList *bsf_lst) ret = av_bsf_list_append2(bsf_lst, bsf_name, &bsf_options); - av_dict_free(&bsf_options); end: + av_dict_free(&bsf_options); av_free(buf); return ret; }