From patchwork Thu Jan 2 11:55:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jun Zhao X-Patchwork-Id: 17130 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 95CFF44987A for ; Thu, 2 Jan 2020 13:55:21 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7F46168A24C; Thu, 2 Jan 2020 13:55:21 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 10D7568AD71 for ; Thu, 2 Jan 2020 13:55:14 +0200 (EET) Received: by mail-pl1-f196.google.com with SMTP id bd4so17737937plb.8 for ; Thu, 02 Jan 2020 03:55:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xW91GX5xTyoTtDayWVhcJft9wjBK1VCWwyEydMBqiwo=; b=vIOFkIcwt7TFbECxuFWYmF8Q0s8Z+wmIljLCeFrDjDYsPoBT9aST/gLMNzMuNv2fw7 Y9BSXRto9m+H/G8ZzLJX0Q1BJebTNlEk9YS+96/N+DLBhkCgDqC/ZYQHXFrh6W0gYKQu Z3v3F8doHe4m1rTiIywK3XMIWTzFq6ZZotWNEpDJQx0LqIVKqovc2/Lq4tfcNIdmDUt3 4wVgfE8/xa2Tm9u767YOKjD0Am0fxGdhkubu7icm+FmWxEmUpFZLUwsZxdeNaDjKe44D YeFlwQinioV7JIve9CHuw3zTL2kXinVWHMy6fsmu6lqPS+IxH6VlXVg17HTWAuU9ysRI HLyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xW91GX5xTyoTtDayWVhcJft9wjBK1VCWwyEydMBqiwo=; b=o4H9SO0EhubEX1xdmtmeqAgVgPPgQKVzGq8Dxzd7RvaGCCRb+S+U9kZJElu166ebGI rYc5NfjDTuT2O7yWshx0/brZ9G9XbQBjgVIYPFhAUtXvO8gRboQOUeiSI9GkP1wGk0ZI 9K8fMtOgAjfRuH4vcmZisJI8JC3qTqWt0Prj28k0Dh2EJIjMqrnteIJykl7mFPGvKShH eIzo1Bh2tOzHwaTuJT/1V0WjaiDunsAm5Mt/HrGq8pNINb/xTnoH0zY7zBGt+wG5acOr BHXW5kO0XQdR4oVgh3zjwzr/Q/vzG0LAMRWtpKFeo5HE9/npmUpSMR18T1s38OPbgyBo XrGQ== X-Gm-Message-State: APjAAAW9nUYrcwqU7d8MWRpESNEbR+Y50mLa+DJxCcamNE/I1kG4sDj8 KoBOSbI2HpyyPXF3/pZnYd2wH0Uu X-Google-Smtp-Source: APXvYqwKaJ4kJsdlsoOn9J7wCNiq+pFx+3nKWVsqYvciz4MAOZYdIcOM7vJcIZrDBotCduVI7b+8Sw== X-Received: by 2002:a17:902:b087:: with SMTP id p7mr87376702plr.10.1577966112196; Thu, 02 Jan 2020 03:55:12 -0800 (PST) Received: from localhost.localdomain ([47.90.47.25]) by smtp.gmail.com with ESMTPSA id y76sm66267524pfc.87.2020.01.02.03.55.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Jan 2020 03:55:11 -0800 (PST) From: Jun Zhao To: ffmpeg-devel@ffmpeg.org Date: Thu, 2 Jan 2020 19:55:02 +0800 Message-Id: <1577966105-4642-2-git-send-email-mypopydev@gmail.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1577966105-4642-1-git-send-email-mypopydev@gmail.com> References: <1577966105-4642-1-git-send-email-mypopydev@gmail.com> Subject: [FFmpeg-devel] [PATCH V2 2/5] lavc/libkvazaar: fix memory leak after av_dict_parse_string fail X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jun Zhao MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Jun Zhao In case of failure, all the successfully set entries are stored in *pm. We need to manually free the created dictionary to avoid memory leak. Signed-off-by: Jun Zhao --- libavcodec/libkvazaar.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c index a89ca7f..02bcae3 100644 --- a/libavcodec/libkvazaar.c +++ b/libavcodec/libkvazaar.c @@ -110,8 +110,8 @@ static av_cold int libkvazaar_init(AVCodecContext *avctx) entry->key, entry->value); } } - av_dict_free(&dict); } + av_dict_free(&dict); } ctx->encoder = enc = api->encoder_open(cfg);