diff mbox series

[FFmpeg-devel,V1,04/11] lavfi/hue: enable runtime change flag

Message ID 1578716038-9645-4-git-send-email-mypopydev@gmail.com
State New
Headers show
Series [FFmpeg-devel,V1,01/11] lavfi/spp: add "quality" option in runtime change path | expand

Checks

Context Check Description
andriy/ffmpeg-patchwork success Make fate finished

Commit Message

Jun Zhao Jan. 11, 2020, 4:13 a.m. UTC 
From: Jun Zhao <barryjzhao@tencent.com>

enable runtime change flag.

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
 libavfilter/vf_hue.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Michael Niedermayer Jan. 11, 2020, 6:52 p.m. UTC | #1 
On Sat, Jan 11, 2020 at 12:13:51PM +0800, Jun Zhao wrote:
> From: Jun Zhao <barryjzhao@tencent.com>
> 
> enable runtime change flag.
> 
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
>  libavfilter/vf_hue.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/libavfilter/vf_hue.c b/libavfilter/vf_hue.c
> index 323333b..026d4b6 100644
> --- a/libavfilter/vf_hue.c
> +++ b/libavfilter/vf_hue.c
> @@ -86,7 +86,7 @@ typedef struct HueContext {
>  } HueContext;
>  
>  #define OFFSET(x) offsetof(HueContext, x)
> -#define FLAGS AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_FILTERING_PARAM
> +#define FLAGS AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_FILTERING_PARAM|AV_OPT_FLAG_RUNTIME_PARAM

its maybe confusing if FLAGS sometimes means what TFLAGS means elsewhere
while there FLAGS has different meaning.
Something consistent across filters would be better

Thanks

[...]
Paul B Mahol Jan. 11, 2020, 8:28 p.m. UTC | #2 
On 1/11/20, Michael Niedermayer <michael@niedermayer.cc> wrote:
> On Sat, Jan 11, 2020 at 12:13:51PM +0800, Jun Zhao wrote:
>> From: Jun Zhao <barryjzhao@tencent.com>
>>
>> enable runtime change flag.
>>
>> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
>> ---
>>  libavfilter/vf_hue.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/libavfilter/vf_hue.c b/libavfilter/vf_hue.c
>> index 323333b..026d4b6 100644
>> --- a/libavfilter/vf_hue.c
>> +++ b/libavfilter/vf_hue.c
>> @@ -86,7 +86,7 @@ typedef struct HueContext {
>>  } HueContext;
>>
>>  #define OFFSET(x) offsetof(HueContext, x)
>> -#define FLAGS AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_FILTERING_PARAM
>> +#define FLAGS
>> AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_FILTERING_PARAM|AV_OPT_FLAG_RUNTIME_PARAM
>
> its maybe confusing if FLAGS sometimes means what TFLAGS means elsewhere
> while there FLAGS has different meaning.
> Something consistent across filters would be better
>
> Thanks
>

I disagree.

> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Many things microsoft did are stupid, but not doing something just because
> microsoft did it is even more stupid. If everything ms did were stupid they
> would be bankrupt already.
>
diff mbox series

Patch

diff --git a/libavfilter/vf_hue.c b/libavfilter/vf_hue.c
index 323333b..026d4b6 100644
--- a/libavfilter/vf_hue.c
+++ b/libavfilter/vf_hue.c
@@ -86,7 +86,7 @@  typedef struct HueContext {
 } HueContext;
 
 #define OFFSET(x) offsetof(HueContext, x)
-#define FLAGS AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_FILTERING_PARAM
+#define FLAGS AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_FILTERING_PARAM|AV_OPT_FLAG_RUNTIME_PARAM
 static const AVOption hue_options[] = {
     { "h", "set the hue angle degrees expression", OFFSET(hue_deg_expr), AV_OPT_TYPE_STRING,
       { .str = NULL }, .flags = FLAGS },