diff mbox series

[FFmpeg-devel,V1,1/2] doc/bsfs: h264_metadata: Update docs about display orientation SEI

Message ID 1579311829-24376-1-git-send-email-mypopydev@gmail.com
State New
Headers show
Series [FFmpeg-devel,V1,1/2] doc/bsfs: h264_metadata: Update docs about display orientation SEI
Related show

Checks

Context Check Description
andriy/ffmpeg-patchwork pending
andriy/ffmpeg-patchwork success Applied patch
andriy/ffmpeg-patchwork success Configure finished
andriy/ffmpeg-patchwork success Make finished
andriy/ffmpeg-patchwork success Make fate finished

Commit Message

Jun Zhao Jan. 18, 2020, 1:43 a.m. UTC
From: Jun Zhao <barryjzhao@tencent.com>

Add docs about display orientation SEI.

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
 doc/bitstream_filters.texi |   21 +++++++++++++++++++++
 1 files changed, 21 insertions(+), 0 deletions(-)

Comments

Andreas Rheinhardt Jan. 18, 2020, 2:28 a.m. UTC | #1
On Sat, Jan 18, 2020 at 3:11 AM Jun Zhao <mypopydev@gmail.com> wrote:

> From: Jun Zhao <barryjzhao@tencent.com>
>
> Add docs about display orientation SEI.
>
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
>  doc/bitstream_filters.texi |   21 +++++++++++++++++++++
>  1 files changed, 21 insertions(+), 0 deletions(-)
>
> diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi
> index 8fe5b3a..ff5d027 100644
> --- a/doc/bitstream_filters.texi
> +++ b/doc/bitstream_filters.texi
> @@ -276,6 +276,27 @@ insert the string ``hello'' associated with the given
> UUID.
>  @item delete_filler
>  Deletes both filler NAL units and filler SEI messages.
>
> +@item display_orientation
> +Pass, insert, remove or extract display orientation SEI.  Default is pass.
> +
> +@table @samp
> +@item pass
> +@item insert
> +@item remove
> +@item extract
> +@end table
> +
> +@item rotate
> +Set rotation in display orientation SEI (anticlockwise angle in degrees)
> (from -360 to 360)
> +
> +@item flip
> +Set flip in display orientation SEI
> +
> +@table @samp
> +@item horizontal
> +@item vertical
> +@end table
> +
>  @item level
>  Set the level in the SPS.  Refer to H.264 section A.3 and tables A-1
>  to A-5.
> --
> 1.7.1


If I am not mistaken, then the handling of display orientation SEI is buggy
(see [1]). It should be fixed before documenting it.

- Andreas

[1]:
https://lists.ffmpeg.org/pipermail/ffmpeg-devel-irc/2019-June/005804.html
mypopy@gmail.com Jan. 19, 2020, 1:52 a.m. UTC | #2
On Sat, Jan 18, 2020 at 10:29 AM Andreas Rheinhardt
<andreas.rheinhardt@gmail.com> wrote:
>
> On Sat, Jan 18, 2020 at 3:11 AM Jun Zhao <mypopydev@gmail.com> wrote:
>
> > From: Jun Zhao <barryjzhao@tencent.com>
> >
> > Add docs about display orientation SEI.
> >
> > Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> > ---
> >  doc/bitstream_filters.texi |   21 +++++++++++++++++++++
> >  1 files changed, 21 insertions(+), 0 deletions(-)
> >
> > diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi
> > index 8fe5b3a..ff5d027 100644
> > --- a/doc/bitstream_filters.texi
> > +++ b/doc/bitstream_filters.texi
> > @@ -276,6 +276,27 @@ insert the string ``hello'' associated with the given
> > UUID.
> >  @item delete_filler
> >  Deletes both filler NAL units and filler SEI messages.
> >
> > +@item display_orientation
> > +Pass, insert, remove or extract display orientation SEI.  Default is pass.
> > +
> > +@table @samp
> > +@item pass
> > +@item insert
> > +@item remove
> > +@item extract
> > +@end table
> > +
> > +@item rotate
> > +Set rotation in display orientation SEI (anticlockwise angle in degrees)
> > (from -360 to 360)
> > +
> > +@item flip
> > +Set flip in display orientation SEI
> > +
> > +@table @samp
> > +@item horizontal
> > +@item vertical
> > +@end table
> > +
> >  @item level
> >  Set the level in the SPS.  Refer to H.264 section A.3 and tables A-1
> >  to A-5.
> > --
> > 1.7.1
>
>
> If I am not mistaken, then the handling of display orientation SEI is buggy
> (see [1]). It should be fixed before documenting it.
>
> - Andreas
>
> [1]:
> https://lists.ffmpeg.org/pipermail/ffmpeg-devel-irc/2019-June/005804.html
Will hold on the patch until the issue fix, thanks
diff mbox series

Patch

diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi
index 8fe5b3a..ff5d027 100644
--- a/doc/bitstream_filters.texi
+++ b/doc/bitstream_filters.texi
@@ -276,6 +276,27 @@  insert the string ``hello'' associated with the given UUID.
 @item delete_filler
 Deletes both filler NAL units and filler SEI messages.
 
+@item display_orientation
+Pass, insert, remove or extract display orientation SEI.  Default is pass.
+
+@table @samp
+@item pass
+@item insert
+@item remove
+@item extract
+@end table
+
+@item rotate
+Set rotation in display orientation SEI (anticlockwise angle in degrees) (from -360 to 360)
+
+@item flip
+Set flip in display orientation SEI
+
+@table @samp
+@item horizontal
+@item vertical
+@end table
+
 @item level
 Set the level in the SPS.  Refer to H.264 section A.3 and tables A-1
 to A-5.