diff mbox series

[FFmpeg-devel,V2] doc/spp: Update spp command options docs

Message ID 1579335061-30354-1-git-send-email-mypopydev@gmail.com
State New
Headers show
Series [FFmpeg-devel,V2] doc/spp: Update spp command options docs
Related show

Checks

Context Check Description
andriy/ffmpeg-patchwork pending
andriy/ffmpeg-patchwork success Applied patch
andriy/ffmpeg-patchwork success Configure finished
andriy/ffmpeg-patchwork success Make finished
andriy/ffmpeg-patchwork success Make fate finished

Commit Message

Jun Zhao Jan. 18, 2020, 8:11 a.m. UTC
From: Jun Zhao <barryjzhao@tencent.com>

Update spp command options docs

Suggested-by: Moritz Barsnick <barsnick@gmx.net>
Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
 doc/filters.texi |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Comments

Gyan Doshi Jan. 18, 2020, 8:19 a.m. UTC | #1
On 18-01-2020 01:41 pm, Jun Zhao wrote:
> From: Jun Zhao <barryjzhao@tencent.com>
>
> Update spp command options docs
>
> Suggested-by: Moritz Barsnick <barsnick@gmx.net>
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
>   doc/filters.texi |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/doc/filters.texi b/doc/filters.texi
> index 7f1f59b..aa7dad5 100644
> --- a/doc/filters.texi
> +++ b/doc/filters.texi
> @@ -17323,9 +17323,9 @@ option may cause flicker since the B-Frames have often larger QP. Default is
>   
>   This filter supports the following commands:
>   @table @option
> -@item level
> -@item quality
> -Same as quality option. And the command accepts the @code{max} same as the @code{6}.
> +@item quality, level
> +Set quality level. The value @code{max} can be used to set the maximum level,
> +currently @code{6}.
>   @end table
>   
>   @section sr

LGTM

Gyan
Moritz Barsnick Jan. 18, 2020, 9:50 p.m. UTC | #2
On Sat, Jan 18, 2020 at 16:11:01 +0800, Jun Zhao wrote:
> Suggested-by: Moritz Barsnick <barsnick@gmx.net>

You don't really need to do this. ;-) Especially as Gyan's suggestion
(which was better) is now in.

> +@item quality, level
> +Set quality level. The value @code{max} can be used to set the maximum level,
> +currently @code{6}.

Also fine by me.

Moritz
mypopy@gmail.com Jan. 19, 2020, 2:03 a.m. UTC | #3
On Sun, Jan 19, 2020 at 5:50 AM Moritz Barsnick <barsnick@gmx.net> wrote:
>
> On Sat, Jan 18, 2020 at 16:11:01 +0800, Jun Zhao wrote:
> > Suggested-by: Moritz Barsnick <barsnick@gmx.net>
>
> You don't really need to do this. ;-) Especially as Gyan's suggestion
> (which was better) is now in.
>
> > +@item quality, level
> > +Set quality level. The value @code{max} can be used to set the maximum level,
> > +currently @code{6}.
>
> Also fine by me.
>
> Moritz
Pushed, thanks the comments and review
diff mbox series

Patch

diff --git a/doc/filters.texi b/doc/filters.texi
index 7f1f59b..aa7dad5 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -17323,9 +17323,9 @@  option may cause flicker since the B-Frames have often larger QP. Default is
 
 This filter supports the following commands:
 @table @option
-@item level
-@item quality
-Same as quality option. And the command accepts the @code{max} same as the @code{6}.
+@item quality, level
+Set quality level. The value @code{max} can be used to set the maximum level,
+currently @code{6}.
 @end table
 
 @section sr