diff mbox series

[FFmpeg-devel,V1,1/3] lavf/dashenc: add 3GPP TS26.247 probe in dash demuxer

Message ID 1583066326-7307-1-git-send-email-mypopydev@gmail.com
State New
Headers show
Series [FFmpeg-devel,V1,1/3] lavf/dashenc: add 3GPP TS26.247 probe in dash demuxer
Related show

Checks

Context Check Description
andriy/ffmpeg-patchwork pending
andriy/ffmpeg-patchwork success Applied patch
andriy/ffmpeg-patchwork success Configure finished
andriy/ffmpeg-patchwork success Make finished
andriy/ffmpeg-patchwork success Make fate finished

Commit Message

Jun Zhao March 1, 2020, 12:38 p.m. UTC
From: Jun Zhao <barryjzhao@tencent.com>

Enabled the 3GP-DASH Release-10/Relase-11(3GPP TS26.247) profile
to dash demuxer probe.

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
 libavformat/dashdec.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

Comments

Jeyapal, Karthick March 2, 2020, 3:54 a.m. UTC | #1
On 3/1/20 6:08 PM, Jun Zhao wrote:
> From: Jun Zhao <barryjzhao@tencent.com>
>
> Enabled the 3GP-DASH Release-10/Relase-11(3GPP TS26.247) profile
> to dash demuxer probe.
>
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
>  libavformat/dashdec.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
You have modified dashdec, but the subject says dashenc. Please correct the typo error.
Thanks.
> index 15e79fd..7be3276 100644
> --- a/libavformat/dashdec.c
> +++ b/libavformat/dashdec.c
> @@ -2361,7 +2361,9 @@ static int dash_probe(const AVProbeData *p)
>      if (av_stristr(p->buf, "dash:profile:isoff-on-demand:2011") ||
>          av_stristr(p->buf, "dash:profile:isoff-live:2011") ||
>          av_stristr(p->buf, "dash:profile:isoff-live:2012") ||
> -        av_stristr(p->buf, "dash:profile:isoff-main:2011")) {
> +        av_stristr(p->buf, "dash:profile:isoff-main:2011") ||
> +        av_stristr(p->buf, "3GPP:PSS:profile:DASH10") ||
> +        av_stristr(p->buf, "3GPP:PSS:profile:DASH11")) {
>          return AVPROBE_SCORE_MAX;
>      }
>      if (av_stristr(p->buf, "dash:profile")) {
mypopy@gmail.com March 2, 2020, 5:31 a.m. UTC | #2
On Mon, Mar 2, 2020 at 11:54 AM Jeyapal, Karthick <kjeyapal@akamai.com> wrote:
>
>
> On 3/1/20 6:08 PM, Jun Zhao wrote:
> > From: Jun Zhao <barryjzhao@tencent.com>
> >
> > Enabled the 3GP-DASH Release-10/Relase-11(3GPP TS26.247) profile
> > to dash demuxer probe.
> >
> > Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> > ---
> >  libavformat/dashdec.c |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
> You have modified dashdec, but the subject says dashenc. Please correct the typo error.
> Thanks.
Will fix the typo
Carl Eugen Hoyos March 2, 2020, 9:10 a.m. UTC | #3
Am So., 1. März 2020 um 13:39 Uhr schrieb Jun Zhao <mypopydev@gmail.com>:
>
> From: Jun Zhao <barryjzhao@tencent.com>
>
> Enabled the 3GP-DASH Release-10/Relase-11(3GPP TS26.247) profile
> to dash demuxer probe.
>
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
>  libavformat/dashdec.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
> index 15e79fd..7be3276 100644
> --- a/libavformat/dashdec.c
> +++ b/libavformat/dashdec.c
> @@ -2361,7 +2361,9 @@ static int dash_probe(const AVProbeData *p)
>      if (av_stristr(p->buf, "dash:profile:isoff-on-demand:2011") ||
>          av_stristr(p->buf, "dash:profile:isoff-live:2011") ||
>          av_stristr(p->buf, "dash:profile:isoff-live:2012") ||
> -        av_stristr(p->buf, "dash:profile:isoff-main:2011")) {
> +        av_stristr(p->buf, "dash:profile:isoff-main:2011") ||

> +        av_stristr(p->buf, "3GPP:PSS:profile:DASH10") ||
> +        av_stristr(p->buf, "3GPP:PSS:profile:DASH11")) {

Is there a reason why you don't compare with "3GPP:PSS:profile:DASH1"?

Carl Eugen
mypopy@gmail.com March 2, 2020, 10:42 a.m. UTC | #4
On Mon, Mar 2, 2020 at 5:10 PM Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
>
> Am So., 1. März 2020 um 13:39 Uhr schrieb Jun Zhao <mypopydev@gmail.com>:
> >
> > From: Jun Zhao <barryjzhao@tencent.com>
> >
> > Enabled the 3GP-DASH Release-10/Relase-11(3GPP TS26.247) profile
> > to dash demuxer probe.
> >
> > Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> > ---
> >  libavformat/dashdec.c |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
> > index 15e79fd..7be3276 100644
> > --- a/libavformat/dashdec.c
> > +++ b/libavformat/dashdec.c
> > @@ -2361,7 +2361,9 @@ static int dash_probe(const AVProbeData *p)
> >      if (av_stristr(p->buf, "dash:profile:isoff-on-demand:2011") ||
> >          av_stristr(p->buf, "dash:profile:isoff-live:2011") ||
> >          av_stristr(p->buf, "dash:profile:isoff-live:2012") ||
> > -        av_stristr(p->buf, "dash:profile:isoff-main:2011")) {
> > +        av_stristr(p->buf, "dash:profile:isoff-main:2011") ||
>
> > +        av_stristr(p->buf, "3GPP:PSS:profile:DASH10") ||
> > +        av_stristr(p->buf, "3GPP:PSS:profile:DASH11")) {
>
> Is there a reason why you don't compare with "3GPP:PSS:profile:DASH1"?
>
No particular reason , in fact :)
diff mbox series

Patch

diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 15e79fd..7be3276 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -2361,7 +2361,9 @@  static int dash_probe(const AVProbeData *p)
     if (av_stristr(p->buf, "dash:profile:isoff-on-demand:2011") ||
         av_stristr(p->buf, "dash:profile:isoff-live:2011") ||
         av_stristr(p->buf, "dash:profile:isoff-live:2012") ||
-        av_stristr(p->buf, "dash:profile:isoff-main:2011")) {
+        av_stristr(p->buf, "dash:profile:isoff-main:2011") ||
+        av_stristr(p->buf, "3GPP:PSS:profile:DASH10") ||
+        av_stristr(p->buf, "3GPP:PSS:profile:DASH11")) {
         return AVPROBE_SCORE_MAX;
     }
     if (av_stristr(p->buf, "dash:profile")) {