| Message ID | 1586779102-31293-2-git-send-email-mypopydev@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Support Dolby Vision | expand |
| Context | Check | Description |
|---|---|---|
| andriy/default | pending | |
| andriy/make | success | Make finished |
| andriy/make_fate | success | Make fate finished |
On Mon, Apr 13, 2020 at 3:20 PM Jun Zhao <mypopydev@gmail.com> wrote: > > From: Jun Zhao <barryjzhao@tencent.com> > > add a new sidedata type for DOVI. > > Signed-off-by: Jun Zhao <barryjzhao@tencent.com> > --- > libavcodec/avpacket.c | 1 + > libavcodec/packet.h | 9 +++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c > index ad020ee..675652d 100644 > --- a/libavcodec/avpacket.c > +++ b/libavcodec/avpacket.c > @@ -396,6 +396,7 @@ const char *av_packet_side_data_name(enum AVPacketSideDataType type) > case AV_PKT_DATA_ENCRYPTION_INFO: return "Encryption info"; > case AV_PKT_DATA_AFD: return "Active Format Description data"; > case AV_PKT_DATA_ICC_PROFILE: return "ICC Profile"; > + case AV_PKT_DATA_DOVI_CONF: return "DOVI metadata"; > } Unfortunately, I am not really able to quickly give this a full review tonight, but at least this should be called similarly to what it is called elsewhere. "DOVI configuration record" or so. Best regards, Jan
On Tue, Apr 14, 2020 at 5:54 AM Jan Ekström <jeebjp@gmail.com> wrote: > > On Mon, Apr 13, 2020 at 3:20 PM Jun Zhao <mypopydev@gmail.com> wrote: > > > > From: Jun Zhao <barryjzhao@tencent.com> > > > > add a new sidedata type for DOVI. > > > > Signed-off-by: Jun Zhao <barryjzhao@tencent.com> > > --- > > libavcodec/avpacket.c | 1 + > > libavcodec/packet.h | 9 +++++++++ > > 2 files changed, 10 insertions(+) > > > > diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c > > index ad020ee..675652d 100644 > > --- a/libavcodec/avpacket.c > > +++ b/libavcodec/avpacket.c > > @@ -396,6 +396,7 @@ const char *av_packet_side_data_name(enum AVPacketSideDataType type) > > case AV_PKT_DATA_ENCRYPTION_INFO: return "Encryption info"; > > case AV_PKT_DATA_AFD: return "Active Format Description data"; > > case AV_PKT_DATA_ICC_PROFILE: return "ICC Profile"; > > + case AV_PKT_DATA_DOVI_CONF: return "DOVI metadata"; > > } > > Unfortunately, I am not really able to quickly give this a full review > tonight, but at least this should be called similarly to what it is > called elsewhere. "DOVI configuration record" or so. The patch-set support DOVI Video Stream Descriptor for MPEG-TS format and Dolby Vision configuration box (DOVIDecoderConfigurationRecord) for MP4 format both, this is the reason to use a more general string "DOVI metadata" Anyway, I can change this part as the comment, wait more comments, tks > > Best regards,
diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index ad020ee..675652d 100644 --- a/libavcodec/avpacket.c +++ b/libavcodec/avpacket.c @@ -396,6 +396,7 @@ const char *av_packet_side_data_name(enum AVPacketSideDataType type) case AV_PKT_DATA_ENCRYPTION_INFO: return "Encryption info"; case AV_PKT_DATA_AFD: return "Active Format Description data"; case AV_PKT_DATA_ICC_PROFILE: return "ICC Profile"; + case AV_PKT_DATA_DOVI_CONF: return "DOVI metadata"; } return NULL; } diff --git a/libavcodec/packet.h b/libavcodec/packet.h index e53abe6..41485f4 100644 --- a/libavcodec/packet.h +++ b/libavcodec/packet.h @@ -274,6 +274,15 @@ enum AVPacketSideDataType { AV_PKT_DATA_ICC_PROFILE, /** + * DOVI configuration + * ref: + * dolby-vision-bitstreams-within-the-iso-base-media-file-format-v2.1.2, section 2.2 + * dolby-vision-bitstreams-in-mpeg-2-transport-stream-multiplex-v1.2, section 3.3 + * Tags are stored in struct AVDOVIDecoderConfigurationRecord. + */ + AV_PKT_DATA_DOVI_CONF, + + /** * The number of side data types. * This is not part of the public API/ABI in the sense that it may * change when new side data types are added.