diff mbox series

[FFmpeg-devel,2/2] dnn-layer-mathbinary-test: add unit test for minimum

Message ID 1587891905-6257-1-git-send-email-yejun.guo@intel.com
State Accepted
Commit 6fd61234d59783d87f917dcac4d7cf2b89a661c5
Headers show
Series [FFmpeg-devel,1/2] dnn/native: add native support for minimum | expand

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Guo, Yejun April 26, 2020, 9:05 a.m. UTC
Signed-off-by: Guo, Yejun <yejun.guo@intel.com>
---
 tests/dnn/dnn-layer-mathbinary-test.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Guo, Yejun April 30, 2020, 11:39 a.m. UTC | #1
> -----Original Message-----
> From: Guo, Yejun <yejun.guo@intel.com>
> Sent: Sunday, April 26, 2020 5:05 PM
> To: ffmpeg-devel@ffmpeg.org
> Cc: Guo, Yejun <yejun.guo@intel.com>
> Subject: [PATCH 2/2] dnn-layer-mathbinary-test: add unit test for minimum
> 
> Signed-off-by: Guo, Yejun <yejun.guo@intel.com>
> ---
>  tests/dnn/dnn-layer-mathbinary-test.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 

This patch set asks for review, thanks.
Guo, Yejun May 7, 2020, 6:07 a.m. UTC | #2
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Guo,
> Yejun
> Sent: 2020年4月30日 19:39
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH 2/2] dnn-layer-mathbinary-test: add unit
> test for minimum
> 
> 
> 
> > -----Original Message-----
> > From: Guo, Yejun <yejun.guo@intel.com>
> > Sent: Sunday, April 26, 2020 5:05 PM
> > To: ffmpeg-devel@ffmpeg.org
> > Cc: Guo, Yejun <yejun.guo@intel.com>
> > Subject: [PATCH 2/2] dnn-layer-mathbinary-test: add unit test for
> > minimum
> >
> > Signed-off-by: Guo, Yejun <yejun.guo@intel.com>
> > ---
> >  tests/dnn/dnn-layer-mathbinary-test.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> 
> This patch set asks for review, thanks.

Will push tomorrow if no other comments, thanks.

> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with
> subject "unsubscribe".
diff mbox series

Patch

diff --git a/tests/dnn/dnn-layer-mathbinary-test.c b/tests/dnn/dnn-layer-mathbinary-test.c
index f67c0f2..e7f8f85 100644
--- a/tests/dnn/dnn-layer-mathbinary-test.c
+++ b/tests/dnn/dnn-layer-mathbinary-test.c
@@ -38,6 +38,8 @@  static float get_expected(float f1, float f2, DNNMathBinaryOperation op)
         return f1 * f2;
     case DMBO_REALDIV:
         return f1 / f2;
+    case DMBO_MINIMUM:
+        return (f1 < f2) ? f1 : f2;
     default:
         av_assert0(!"not supported yet");
         return 0.f;
@@ -200,5 +202,8 @@  int main(int argc, char **argv)
     if (test(DMBO_REALDIV))
         return 1;
 
+    if (test(DMBO_MINIMUM))
+        return 1;
+
     return 0;
 }