From patchwork Tue Apr 28 09:16:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Fu, Linjie" X-Patchwork-Id: 19320 Delivered-To: andriy.gelman@gmail.com Received: by 2002:a25:3c87:0:0:0:0:0 with SMTP id j129csp3945530yba; Tue, 28 Apr 2020 02:18:16 -0700 (PDT) X-Google-Smtp-Source: APiQypJnalfCNjpyG5Ceoahpnu0NQuPtQTjxYQjjUUDsDmiI5ZjVQaB0vJ334I3vYEO8s7ebyQQu X-Received: by 2002:a5d:6b86:: with SMTP id n6mr31379521wrx.113.1588065496034; Tue, 28 Apr 2020 02:18:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588065496; cv=none; d=google.com; s=arc-20160816; b=T0WrSmlR2WXWHdarU4CXW+GWwZmdvdcdmwAogoX3PLj8P8IQCv/rC/fTOWAcIEor/7 Uc4iIVRjoNx8xP5d1ne5usl3SOZ1mCtMAcuCn7Jm1+Z+U9pivdCSlUg+63wazFq5c2Dk Uf4tmRvqxxC/tF3yMOVbDGlmIWSSfp75hQc0ClLon45C6FPYLaPT8alJGzo5OlNWr0AH qBW66Q+VS+5cV6ca5ZnMSRscT93KY2v/l6fkCsDWiUDyIbtcngBH2xJ+oowFzACtJAJa DjxJZjrHoOEeZVt8BVvc7wCXVX/r5kbE9eR2xaxv7ZruXdKTzWb4exPrBFceQ2HXBEHm ZRUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:ironport-sdr:ironport-sdr:delivered-to; bh=sg6jHZRdTSiC/XHXkCsAafFmojs1pBex+Nzwiq5Le+0=; b=cXOyuUqGrxTBXITUd/mf/aHNsW+IGa50rfk9n75z15Z5PYSn33ibaTsA3q2wG2GHX+ X6X72DUHQkyjB3KYw9o2vLCpQe3cenYcXMawJYEYkE7kXJ710EM2r7RZNgdp/bDXqRw1 HdRfVYpstvUGawgSGcJsEAjX3wWeoqeE6HLap4sGM5fJ75YGhdVChRQyIg4TlrbdXICr zPlSfBKurCMBFADMbHCa+sA7FjBv5k9tLIws6eh0RGHcyFAFQEM4nlI0VTSDDIVzJPI3 vMddI566CUypdgcMcckxRMq0j3tYSojdiDv6NTmWB+4AQtC0229dp3HYMRgVtaEHbaWU JOlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 40si16749185wrc.366.2020.04.28.02.18.15; Tue, 28 Apr 2020 02:18:16 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E40FA68BC0C; Tue, 28 Apr 2020 12:18:01 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9323768BBF7 for ; Tue, 28 Apr 2020 12:17:55 +0300 (EEST) IronPort-SDR: IUC+7tJSFDk/oEvtdwt8EmsqVlvkWvmu2uky5gmrC5ROGfb1ZeBCF7vhRl+tUsJ7p+9cBJAbE1 Q7V4A/g0gYSg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 02:17:55 -0700 IronPort-SDR: iNwV7/mbPSIhbXyy09b333ovggMglPVHDxbNqTlIKrWRQ898KcunbFjQBvPUySJyuW6sUe9n6U Tpe/ihAfJJ5g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,327,1583222400"; d="scan'208";a="261037286" Received: from icl-dev.sh.intel.com ([10.239.158.73]) by orsmga006.jf.intel.com with ESMTP; 28 Apr 2020 02:17:54 -0700 From: Linjie Fu To: ffmpeg-devel@ffmpeg.org Date: Tue, 28 Apr 2020 17:16:00 +0800 Message-Id: <1588065363-7104-3-git-send-email-linjie.fu@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1588065363-7104-1-git-send-email-linjie.fu@intel.com> References: <1588065363-7104-1-git-send-email-linjie.fu@intel.com> Subject: [FFmpeg-devel] [PATCH v5 2/5] lavc/libopenh264enc: add default gop size and bit rate X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Linjie Fu MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: QFnT4U/4PQFB Content-Length: 3230 It would be 200kbps bitrate with gop size = 12 by default which generated too many IDR frames in rather low bit rate. The quality would be poor. Set these default values to -1 to check whether it's specified by user explicitly. Use 2Mbps bitrate as nvenc sugguested, and leave gop size untouched in libopenh264. Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index 1b6b53a..0951412 100644 --- a/libavcodec/libopenh264enc.c +++ b/libavcodec/libopenh264enc.c @@ -37,6 +37,8 @@ #define SM_SIZELIMITED_SLICE SM_DYN_SLICE #endif +#define TARGET_BITRATE_DEFAULT 2*1000*1000 + typedef struct SVCContext { const AVClass *av_class; ISVCEncoder *encoder; @@ -132,7 +134,7 @@ FF_ENABLE_DEPRECATION_WARNINGS param.fMaxFrameRate = 1/av_q2d(avctx->time_base); param.iPicWidth = avctx->width; param.iPicHeight = avctx->height; - param.iTargetBitrate = avctx->bit_rate; + param.iTargetBitrate = avctx->bit_rate > 0 ? avctx->bit_rate : TARGET_BITRATE_DEFAULT; param.iMaxBitrate = FFMAX(avctx->rc_max_rate, avctx->bit_rate); param.iRCMode = RC_QUALITY_MODE; // QP = 0 is not well supported, so clip to (1, 51) @@ -148,7 +150,8 @@ FF_ENABLE_DEPRECATION_WARNINGS param.bEnableFrameSkip = s->skip_frames; param.bEnableLongTermReference = 0; param.iLtrMarkPeriod = 30; - param.uiIntraPeriod = avctx->gop_size; + if (avctx->gop_size) + param.uiIntraPeriod = avctx->gop_size; #if OPENH264_VER_AT_LEAST(1, 4) param.eSpsPpsIdStrategy = CONSTANT_ID; #else @@ -337,6 +340,8 @@ static int svc_encode_frame(AVCodecContext *avctx, AVPacket *avpkt, } static const AVCodecDefault svc_enc_defaults[] = { + { "b", "0" }, + { "g", "-1" }, { "qmin", "-1" }, { "qmax", "-1" }, { NULL },