diff mbox series

[FFmpeg-devel,2/5] avformat/mxfdec: reindent code

Message ID 1588251554-3665-2-git-send-email-lance.lmwang@gmail.com
State Superseded
Headers show
Series [FFmpeg-devel,1/5] avcodec/v4l2_m2m_enc: reindent code | expand

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Lance Wang April 30, 2020, 12:59 p.m. UTC 
From: Limin Wang <lance.lmwang@gmail.com>

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 libavformat/mxfdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tomas Härdin May 4, 2020, 8:13 a.m. UTC | #1 
tor 2020-04-30 klockan 20:59 +0800 skrev lance.lmwang@gmail.com:
> From: Limin Wang <lance.lmwang@gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
>  libavformat/mxfdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index fdd0dd2a88..02a2a6d97a 100644
> --- a/libavformat/mxfdec.c
> +++ b/libavformat/mxfdec.c
> @@ -363,7 +363,7 @@ static void mxf_free_metadataset(MXFMetadataSet
> **ctx, int freectx)
>          break;
>      }
>      if (freectx)
> -    av_freep(ctx);
> +        av_freep(ctx);
>  }

Might as well att some {} braces too

/Tomas
Lance Wang May 4, 2020, 10:58 a.m. UTC | #2 
On Mon, May 4, 2020 at 4:13 PM Tomas Härdin <tjoppen@acc.umu.se> wrote:

> tor 2020-04-30 klockan 20:59 +0800 skrev lance.lmwang@gmail.com:
> > From: Limin Wang <lance.lmwang@gmail.com>
> >
> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > ---
> >  libavformat/mxfdec.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> > index fdd0dd2a88..02a2a6d97a 100644
> > --- a/libavformat/mxfdec.c
> > +++ b/libavformat/mxfdec.c
> > @@ -363,7 +363,7 @@ static void mxf_free_metadataset(MXFMetadataSet
> > **ctx, int freectx)
> >          break;
> >      }
> >      if (freectx)
> > -    av_freep(ctx);
> > +        av_freep(ctx);
> >  }
>
> Might as well att some {} braces too
>
>
Sorry, I haven't understand your comments, are you want  to change like
below?
 if (freectx) {
      av_freep(cox);
 }


/Tomas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Tomas Härdin May 4, 2020, 12:02 p.m. UTC | #3 
mån 2020-05-04 klockan 18:58 +0800 skrev Lance Wang:
> On Mon, May 4, 2020 at 4:13 PM Tomas Härdin <tjoppen@acc.umu.se>
> wrote:
> 
> > tor 2020-04-30 klockan 20:59 +0800 skrev lance.lmwang@gmail.com:
> > > From: Limin Wang <lance.lmwang@gmail.com>
> > > 
> > > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > > ---
> > >  libavformat/mxfdec.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> > > index fdd0dd2a88..02a2a6d97a 100644
> > > --- a/libavformat/mxfdec.c
> > > +++ b/libavformat/mxfdec.c
> > > @@ -363,7 +363,7 @@ static void
> > > mxf_free_metadataset(MXFMetadataSet
> > > **ctx, int freectx)
> > >          break;
> > >      }
> > >      if (freectx)
> > > -    av_freep(ctx);
> > > +        av_freep(ctx);
> > >  }
> > 
> > Might as well att some {} braces too
> > 
> > 
> Sorry, I haven't understand your comments, are you want  to change
> like
> below?
>  if (freectx) {
>       av_freep(cox);
>  }
> 

yes
diff mbox series

Patch

diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
index fdd0dd2a88..02a2a6d97a 100644
--- a/libavformat/mxfdec.c
+++ b/libavformat/mxfdec.c
@@ -363,7 +363,7 @@  static void mxf_free_metadataset(MXFMetadataSet **ctx, int freectx)
         break;
     }
     if (freectx)
-    av_freep(ctx);
+        av_freep(ctx);
 }
 
 static int64_t klv_decode_ber_length(AVIOContext *pb)