From patchwork Sun May 17 07:24:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jun Zhao X-Patchwork-Id: 19719 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id A673344A90F for ; Sun, 17 May 2020 10:30:37 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 85BFB687EC0; Sun, 17 May 2020 10:30:37 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A107C680BD1 for ; Sun, 17 May 2020 10:30:30 +0300 (EEST) Received: by mail-pg1-f195.google.com with SMTP id u5so3178203pgn.5 for ; Sun, 17 May 2020 00:30:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VZBe8+vlIONyekIW1e1XJHwlL85dN/zYmzTLny8TrQs=; b=R2skFSPqP7lF3j6KDsP0s58XO0Xxsmj4++3XvmkkqVY3o/hXw61KYgeNMeU8QJx224 V2x46Xtu/Z7deCP7Bjxq0pZs5r/fdPAArhfAImw+9fpa16YQko0YuIO1AcwI5jRPTKuJ a8z4O52RG/I6tboy1emmv+JdWMqVKgDkcHW1mkZlvxv85tmYI7wenWdoFP+A3PCrnAUc af7Rae7muKAIbGuNpxDM3xw8BfQYeLGXjXraJI2cSHwgLLY4iO6oq4piBw2928gLtf8h TaZQudhaC0/KO/qQidUQtxUA6I3L31SeCETiNclXv74RGi7M7cnCathdZn3cHoR9Yyi2 0bYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VZBe8+vlIONyekIW1e1XJHwlL85dN/zYmzTLny8TrQs=; b=C625SNIJj6/HguqUi+qw8G6Hmk5uGKdom4M8RaxA0SCQJOjylo2nqnE88V+Wv1DASh xX5iKN5YweabV7JHBiosuW/4B5WbyanEv4G42pJMZQZYCSmxiNVLZgb9OV5odnsJ1INx 2nolLwDVnM6iJBMZk5Pqlc8A7TgPhnu0n029vCSEGTWjRAxmOdKeTvsUzg1DEzN40DsE hw7VKigxPMrdbDkqx5BnghWMZymJ7s688WNATJi7dp4I1ym4uQw//9hIpT0F3eM0XS4j I9vd/FgqVcbMdz0qU0vGPfWV9FbIg/8gAOQ6CpOBeADM8JtF6ro5hwtIg3E8JD76LdEo 216w== X-Gm-Message-State: AOAM530DJwtcAeoPLrdDzzbLK8vyWAK1YwNBlt+UpLoG7arFgPnRnRC2 hwWiV+BmInIlQ7IchvAnqLWcW7Ur X-Google-Smtp-Source: ABdhPJwcY93V7eqJoRVR2StKRTt3tlugHk/CPh8ku8VXmMw44XdxFt/qPjGFyzUEi6hIAYMwSJHYHw== X-Received: by 2002:a65:5a8b:: with SMTP id c11mr10173364pgt.215.1589700304853; Sun, 17 May 2020 00:25:04 -0700 (PDT) Received: from localhost.localdomain ([49.51.162.193]) by smtp.gmail.com with ESMTPSA id w186sm5840740pff.83.2020.05.17.00.25.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 May 2020 00:25:04 -0700 (PDT) From: Jun Zhao To: ffmpeg-devel@ffmpeg.org Date: Sun, 17 May 2020 15:24:45 +0800 Message-Id: <1589700286-4129-2-git-send-email-mypopydev@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589700286-4129-1-git-send-email-mypopydev@gmail.com> References: <1589700286-4129-1-git-send-email-mypopydev@gmail.com> Subject: [FFmpeg-devel] [PATCH 2/3] lavf/utils: fix start_time dump when the value is AV_NOPTS_VALUE X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jun Zhao MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Jun Zhao The command: ffprobe -show_format -i ../fate-suite/aac/foo.aac -loglevel 99 will dump the trace message as follow when start_time is AV_NOPTS_VALUE [aac @ 0x55bf8e1f3dc0] stream 0: start_time: -326791809695.818 duration: 2.174 [aac @ 0x55bf8e1f3dc0] format: start_time: -9223372036854.775 duration: 2.174 bitrate=120 kb/s after this fix, will dump the start_time with "N/A". Signed-off-by: Jun Zhao --- libavformat/utils.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index e6158d8..d7fdd72 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -2983,11 +2983,24 @@ static void estimate_timings(AVFormatContext *ic, int64_t old_offset) AVStream av_unused *st; for (i = 0; i < ic->nb_streams; i++) { st = ic->streams[i]; - if (st->time_base.den) + if (st->time_base.den) { + if (st->start_time == AV_NOPTS_VALUE) + av_log(ic, AV_LOG_TRACE, "stream %d: start_time: N/A duration: %0.3f\n", i, + (double) st->duration * av_q2d(st->time_base)); + else av_log(ic, AV_LOG_TRACE, "stream %d: start_time: %0.3f duration: %0.3f\n", i, (double) st->start_time * av_q2d(st->time_base), (double) st->duration * av_q2d(st->time_base)); + } } + + if (ic->start_time == AV_NOPTS_VALUE) + av_log(ic, AV_LOG_TRACE, + "format: start_time: N/A duration: %0.3f (estimate from %s) bitrate=%"PRId64" kb/s\n", + (double) ic->duration / AV_TIME_BASE, + duration_estimate_name(ic->duration_estimation_method), + (int64_t)ic->bit_rate / 1000); + else av_log(ic, AV_LOG_TRACE, "format: start_time: %0.3f duration: %0.3f (estimate from %s) bitrate=%"PRId64" kb/s\n", (double) ic->start_time / AV_TIME_BASE,