Message ID | 1592839474-2804-6-git-send-email-lance.lmwang@gmail.com |
---|---|
State | Accepted |
Headers | show |
Series | [FFmpeg-devel,1/6] avutil/opt: check return value of av_bprint_finalize() | expand |
Context | Check | Description |
---|---|---|
andriy/default | pending | |
andriy/make | success | Make finished |
andriy/make_fate | success | Make fate finished |
lance.lmwang@gmail.com (12020-06-22): > From: Limin Wang <lance.lmwang@gmail.com> > > Don't need to do double check by the description of the API. Looks ok. Could be simplified even further bu passing s directly. I do not maintain that file. Regards,
On Wed, Jun 24, 2020 at 05:37:59PM +0200, Nicolas George wrote: > lance.lmwang@gmail.com (12020-06-22): > > From: Limin Wang <lance.lmwang@gmail.com> > > > > Don't need to do double check by the description of the API. > > Looks ok. Could be simplified even further bu passing s directly. Yes, I prefer to change it in another patch, if you think it's OK to change in one patch, I'll update the patch. > > I do not maintain that file. > > Regards, > > -- > Nicolas George
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index f7a4f30..a34da2f 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -398,7 +398,7 @@ static int replace_str_data_in_filename(char **s, const char *filename, char pla av_bprint_finalize(&buf, NULL); return AVERROR(ENOMEM); } - if ((ret = av_bprint_finalize(&buf, &new_filename)) < 0 || !new_filename) + if ((ret = av_bprint_finalize(&buf, &new_filename)) < 0) return ret; *s = new_filename; return found_count; @@ -448,7 +448,7 @@ static int replace_int_data_in_filename(char **s, const char *filename, char pla av_bprint_finalize(&buf, NULL); return AVERROR(ENOMEM); } - if ((ret = av_bprint_finalize(&buf, &new_filename)) < 0 || !new_filename) + if ((ret = av_bprint_finalize(&buf, &new_filename)) < 0) return ret; *s = new_filename; return found_count;