diff mbox series

[FFmpeg-devel,v2,2/2] lavf/udp: fix the commets for defalt UDP socket recvbuf size

Message ID 1594466515-32524-2-git-send-email-mypopydev@gmail.com
State Accepted
Commit 3205ed31a7756ae563301e2f5a5dd2c853b20349
Headers show
Series [FFmpeg-devel,v2,1/2] lavfi/setpts: fix setpts/asetpts option dump error | expand

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Jun Zhao July 11, 2020, 11:21 a.m. UTC 
From: Jun Zhao <barryjzhao@tencent.com>

15d160cc0b2 increased the UDP socket receiving buffer size
(64K ->384K), but missed to update this comments.

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
 libavformat/udp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marton Balint July 11, 2020, 5:10 p.m. UTC | #1 
On Sat, 11 Jul 2020, Jun Zhao wrote:

> From: Jun Zhao <barryjzhao@tencent.com>
>
> 15d160cc0b2 increased the UDP socket receiving buffer size
> (64K ->384K), but missed to update this comments.
>
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
> libavformat/udp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/udp.c b/libavformat/udp.c
> index ad6992c..30d8041 100644
> --- a/libavformat/udp.c
> +++ b/libavformat/udp.c
> @@ -852,7 +852,7 @@ static int udp_open(URLContext *h, const char *uri, int flags)
>             goto fail;
>         }
>     } else {
> -        /* set udp recv buffer size to the requested value (default 64K) */
> +        /* set udp recv buffer size to the requested value (default UDP_RX_BUF_SIZE) */
>         tmp = s->buffer_size;
>         if (setsockopt(udp_fd, SOL_SOCKET, SO_RCVBUF, &tmp, sizeof(tmp)) < 0) {
>             ff_log_net_error(h, AV_LOG_WARNING, "setsockopt(SO_RECVBUF)");

LGTM, thanks.

Marton
Nicolas George July 11, 2020, 5:38 p.m. UTC | #2 
Marton Balint (12020-07-11):
> LGTM, thanks.

Whoever pushes, fix the typo in the commit message please.

Regards,
Jun Zhao July 12, 2020, 2:48 p.m. UTC | #3 
On Sun, Jul 12, 2020 at 1:38 AM Nicolas George <george@nsup.org> wrote:
>
> Marton Balint (12020-07-11):
> > LGTM, thanks.
>
> Whoever pushes, fix the typo in the commit message please.
>
fixed the typo and pushed
diff mbox series

Patch

diff --git a/libavformat/udp.c b/libavformat/udp.c
index ad6992c..30d8041 100644
--- a/libavformat/udp.c
+++ b/libavformat/udp.c
@@ -852,7 +852,7 @@  static int udp_open(URLContext *h, const char *uri, int flags)
             goto fail;
         }
     } else {
-        /* set udp recv buffer size to the requested value (default 64K) */
+        /* set udp recv buffer size to the requested value (default UDP_RX_BUF_SIZE) */
         tmp = s->buffer_size;
         if (setsockopt(udp_fd, SOL_SOCKET, SO_RCVBUF, &tmp, sizeof(tmp)) < 0) {
             ff_log_net_error(h, AV_LOG_WARNING, "setsockopt(SO_RECVBUF)");