diff mbox series

[FFmpeg-devel,5/5] avcodec/libsvtav1: remove the auto thread flag

Message ID 1596280963-15526-5-git-send-email-lance.lmwang@gmail.com
State New
Headers show
Series [FFmpeg-devel,1/5] avcodec/libsvtav1: fix copy and paste error | expand

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Lance Wang Aug. 1, 2020, 11:22 a.m. UTC 
From: Limin Wang <lance.lmwang@gmail.com>

Please use the cores and socket for the setting of multi-thread.

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 libavcodec/libsvtav1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Thompson Aug. 1, 2020, 12:49 p.m. UTC | #1 
On 01/08/2020 12:22, lance.lmwang@gmail.com wrote:
> From: Limin Wang <lance.lmwang@gmail.com>
> 
> Please use the cores and socket for the setting of multi-thread.
> 
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
>   libavcodec/libsvtav1.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
> index 78e0ee5..dfb361a 100644
> --- a/libavcodec/libsvtav1.c
> +++ b/libavcodec/libsvtav1.c
> @@ -556,7 +556,7 @@ AVCodec ff_libsvtav1_encoder = {
>       .init           = eb_enc_init,
>       .receive_packet = eb_receive_packet,
>       .close          = eb_enc_close,
> -    .capabilities   = AV_CODEC_CAP_DELAY | AV_CODEC_CAP_AUTO_THREADS,
> +    .capabilities   = AV_CODEC_CAP_DELAY,
>       .pix_fmts       = (const enum AVPixelFormat[]){ AV_PIX_FMT_YUV420P,
>                                                       AV_PIX_FMT_YUV420P10,
>                                                       AV_PIX_FMT_NONE },
> 

But this is true anyway, isn't it?  The encoder will happily saturate the machine with threads if you don't set anything.

- Mark
diff mbox series

Patch

diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
index 78e0ee5..dfb361a 100644
--- a/libavcodec/libsvtav1.c
+++ b/libavcodec/libsvtav1.c
@@ -556,7 +556,7 @@  AVCodec ff_libsvtav1_encoder = {
     .init           = eb_enc_init,
     .receive_packet = eb_receive_packet,
     .close          = eb_enc_close,
-    .capabilities   = AV_CODEC_CAP_DELAY | AV_CODEC_CAP_AUTO_THREADS,
+    .capabilities   = AV_CODEC_CAP_DELAY,
     .pix_fmts       = (const enum AVPixelFormat[]){ AV_PIX_FMT_YUV420P,
                                                     AV_PIX_FMT_YUV420P10,
                                                     AV_PIX_FMT_NONE },