From patchwork Sat Jan 30 07:13:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lance Wang X-Patchwork-Id: 25271 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 9C8D5442D62 for ; Sat, 30 Jan 2021 09:40:01 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6BCF5689AB4; Sat, 30 Jan 2021 09:40:01 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7D1B56881A1 for ; Sat, 30 Jan 2021 09:39:55 +0200 (EET) Received: by mail-il1-f178.google.com with SMTP id z18so10394769ile.9 for ; Fri, 29 Jan 2021 23:39:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ek8NlrU9bHsIj/pX9punP5oyrZndmGyfajYMfwncNOE=; b=MmDapO0PZ2y8pA0tv3OsqGSYFCwG1t2OgY9898iL3NL3jfEaVkk2kNBF3wWJuSntAV 4krE/peXAQEVu7W1Ft0yi3ExFz2aQXTRGXqr8Se/q52c6OTGzirwflTcO5zDzBzOtlsy FL+5lKNFkXu8aULg2i9PpMcTMByeyd0kbKIcLdEAPnAoNrZKRJu+XMLpkAGZ4BZLXAPI tejZAJ22tTdAvibdHrokJ8k1kqI7QXcjXsu4ehOv08ZcQKoPmMi6y3pOnRJdcVJK4cpB 5FtpH5xcp20du3xtYigZXjJ+nbhGJssRRYC8X+jmjJS/sm0JZkuHvTb3+njgyY4xYCEQ TThQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ek8NlrU9bHsIj/pX9punP5oyrZndmGyfajYMfwncNOE=; b=gwBIaYI06HDTNyPa8dcecI10JryjFszHv3WsRdCdfQTuTkjXKtmeedwG1I/8eXrxre +G8tb7XX5tE2FTsIm7dh32KILZDUjxwfezupxI7xqCBSN87AFv0f4xOaJpyXFk6CuCCZ DDTpb4rVzXm7Gxg8Jb5NeEVAZq/s6WkcubbWPIlqzWqkaEKnWvzU6YZBFN0BYon/FYXZ OKpXQC3PBAw8HXi2DiTvF4ZboLehm0BesE0v2Vyj9wW9bV0r4MmTPcBti23vGxZGaPUN jNBOjZ2TvqWxttlt7yUf8Ix9/b1qGpFEGz0TTMtRsmJjwh0RpjZnL5phh180M19AtqP1 7qFA== X-Gm-Message-State: AOAM533iK0U8sXfQGOfliqDYWzZ2BHJOZcKC2MnhduVgVfZUOsqIgrSd +3FOU1TXTgZ99r8uZgLNnyAcu/Fmfdo= X-Google-Smtp-Source: ABdhPJxdA7Oo/Yl/VcCiUOV2b7l56KaWzJHKK5JBy+6TtHaKoE4lX2mugYKmTzErlQ/kWCbt3gI4IA== X-Received: by 2002:a63:3e0c:: with SMTP id l12mr8010958pga.165.1611990826327; Fri, 29 Jan 2021 23:13:46 -0800 (PST) Received: from vpn2.localdomain ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id k141sm11504545pfd.9.2021.01.29.23.13.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Jan 2021 23:13:45 -0800 (PST) From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Sat, 30 Jan 2021 15:13:40 +0800 Message-Id: <1611990820-10877-2-git-send-email-lance.lmwang@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1611990820-10877-1-git-send-email-lance.lmwang@gmail.com> References: <1610168848-17933-3-git-send-email-lance.lmwang@gmail.com> <1611990820-10877-1-git-send-email-lance.lmwang@gmail.com> Subject: [FFmpeg-devel] [PATCH v5 2/2] avformat/mxfenc: prefer to use the configured metadta X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Limin Wang MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Limin Wang The metadata company_name, product_name, product_version from input file will be deleted to avoid overwriting information Please to test with below command: ./ffmpeg -i ../fate-suite/mxf/Sony-00001.mxf -c:v copy -c:a copy out.mxf and ./ffmpeg -i ../fate-suite/mxf/Sony-00001.mxf -c:v copy -c:a copy \ -metadata company_name="xxx" \ -metadata product_name="xxx" \ -metadata product_version="xxx" \ out.mxf Signed-off-by: Limin Wang --- fftools/ffmpeg_opt.c | 3 +++ libavformat/mxfenc.c | 12 ++++++++---- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index bf2eb26..07308cc 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -2641,6 +2641,9 @@ loop_end: if(o->recording_time != INT64_MAX) av_dict_set(&oc->metadata, "duration", NULL, 0); av_dict_set(&oc->metadata, "creation_time", NULL, 0); + av_dict_set(&oc->metadata, "company_name", NULL, 0); + av_dict_set(&oc->metadata, "product_name", NULL, 0); + av_dict_set(&oc->metadata, "product_version", NULL, 0); } if (!o->metadata_streams_manual) for (i = of->ost_index; i < nb_output_streams; i++) { diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index 2cf443f..d69bc9a 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -724,9 +724,13 @@ static void mxf_write_identification(AVFormatContext *s) { MXFContext *mxf = s->priv_data; AVIOContext *pb = s->pb; - const char *company = "FFmpeg"; - const char *product = s->oformat != &ff_mxf_opatom_muxer ? "OP1a Muxer" : "OPAtom Muxer"; - const char *version; + AVDictionaryEntry *com_entry = av_dict_get(s->metadata, "company_name", NULL, 0); + AVDictionaryEntry *product_entry = av_dict_get(s->metadata, "product_name", NULL, 0); + AVDictionaryEntry *version_entry = av_dict_get(s->metadata, "product_version", NULL, 0); + const char *company = com_entry ? com_entry->value : "FFmpeg"; + const char *product = product_entry ? product_entry->value : s->oformat != &ff_mxf_opatom_muxer ? "OP1a Muxer" : "OPAtom Muxer"; + const char *version = NULL; + const char *product_version = version_entry ? version_entry->value : AV_STRINGIFY(LIBAVFORMAT_VERSION); const char *platform = s->flags & AVFMT_FLAG_BITEXACT ? "Lavf" : PLATFROM_IDENT; int length; @@ -734,7 +738,7 @@ static void mxf_write_identification(AVFormatContext *s) PRINT_KEY(s, "identification key", pb->buf_ptr - 16); version = s->flags & AVFMT_FLAG_BITEXACT ? - "0.0.0" : AV_STRINGIFY(LIBAVFORMAT_VERSION); + "0.0.0" : product_version; length = 100 +mxf_utf16_local_tag_length(company) + mxf_utf16_local_tag_length(product) + mxf_utf16_local_tag_length(platform) +