diff mbox series

[FFmpeg-devel,3/3] libavcodec/mips: Fix fate errors reported by clang

Message ID 1622167481-10973-3-git-send-email-jinbo@loongson.cn
State Accepted
Commit 2fac1e370c9cf48b2e9d4a7f2c0d7236017f9bbe
Headers show
Series [FFmpeg-devel,1/3] libavcodec/mips: Fix specification of instruction name | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

金波 May 28, 2021, 2:04 a.m. UTC
The data width of gsldrc1/gsldlc1 should be 8 bytes wide.

Signed-off-by: Jin Bo <jinbo@loongson.cn>
---
 libavcodec/mips/vp9_mc_mmi.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Comments

殷时友 June 1, 2021, 1:03 p.m. UTC | #1
&gt; -----原始邮件-----
&gt; 发件人: "Jin Bo" <jinbo@loongson.cn>
&gt; 发送时间: 2021-05-28 10:04:41 (星期五)
&gt; 收件人: ffmpeg-devel@ffmpeg.org
&gt; 抄送: "Jin Bo" <jinbo@loongson.cn>
&gt; 主题: [FFmpeg-devel] [PATCH 3/3] libavcodec/mips: Fix fate errors reported by clang
&gt; 
&gt; The data width of gsldrc1/gsldlc1 should be 8 bytes wide.
&gt; 
&gt; Signed-off-by: Jin Bo <jinbo@loongson.cn>
&gt; ---
&gt;  libavcodec/mips/vp9_mc_mmi.c | 16 ++++++++--------
&gt;  1 file changed, 8 insertions(+), 8 deletions(-)
&gt; 
&gt; diff --git a/libavcodec/mips/vp9_mc_mmi.c b/libavcodec/mips/vp9_mc_mmi.c
&gt; index fa65ff5..812f7a6 100644
&gt; --- a/libavcodec/mips/vp9_mc_mmi.c
&gt; +++ b/libavcodec/mips/vp9_mc_mmi.c
&gt; @@ -83,9 +83,9 @@ static void convolve_horiz_mmi(const uint8_t *src, int32_t src_stride,
&gt;      __asm__ volatile (
&gt;          "move       %[tmp1],    %[width]                   \n\t"
&gt;          "pxor       %[ftmp0],   %[ftmp0],    %[ftmp0]      \n\t"
&gt; -        "gsldlc1    %[filter1], 0x03(%[filter])            \n\t"
&gt; +        "gsldlc1    %[filter1], 0x07(%[filter])            \n\t"
&gt;          "gsldrc1    %[filter1], 0x00(%[filter])            \n\t"
&gt; -        "gsldlc1    %[filter2], 0x0b(%[filter])            \n\t"
&gt; +        "gsldlc1    %[filter2], 0x0f(%[filter])            \n\t"
&gt;          "gsldrc1    %[filter2], 0x08(%[filter])            \n\t"
&gt;          "li         %[tmp0],    0x07                       \n\t"
&gt;          "dmtc1      %[tmp0],    %[ftmp13]                  \n\t"
&gt; @@ -158,9 +158,9 @@ static void convolve_vert_mmi(const uint8_t *src, int32_t src_stride,
&gt;  
&gt;      __asm__ volatile (
&gt;          "pxor       %[ftmp0],    %[ftmp0],   %[ftmp0]      \n\t"
&gt; -        "gsldlc1    %[ftmp4],    0x03(%[filter])           \n\t"
&gt; +        "gsldlc1    %[ftmp4],    0x07(%[filter])           \n\t"
&gt;          "gsldrc1    %[ftmp4],    0x00(%[filter])           \n\t"
&gt; -        "gsldlc1    %[ftmp5],    0x0b(%[filter])           \n\t"
&gt; +        "gsldlc1    %[ftmp5],    0x0f(%[filter])           \n\t"
&gt;          "gsldrc1    %[ftmp5],    0x08(%[filter])           \n\t"
&gt;          "punpcklwd  %[filter10], %[ftmp4],   %[ftmp4]      \n\t"
&gt;          "punpckhwd  %[filter32], %[ftmp4],   %[ftmp4]      \n\t"
&gt; @@ -254,9 +254,9 @@ static void convolve_avg_horiz_mmi(const uint8_t *src, int32_t src_stride,
&gt;      __asm__ volatile (
&gt;          "move       %[tmp1],    %[width]                   \n\t"
&gt;          "pxor       %[ftmp0],   %[ftmp0],    %[ftmp0]      \n\t"
&gt; -        "gsldlc1    %[filter1], 0x03(%[filter])            \n\t"
&gt; +        "gsldlc1    %[filter1], 0x07(%[filter])            \n\t"
&gt;          "gsldrc1    %[filter1], 0x00(%[filter])            \n\t"
&gt; -        "gsldlc1    %[filter2], 0x0b(%[filter])            \n\t"
&gt; +        "gsldlc1    %[filter2], 0x0f(%[filter])            \n\t"
&gt;          "gsldrc1    %[filter2], 0x08(%[filter])            \n\t"
&gt;          "li         %[tmp0],    0x07                       \n\t"
&gt;          "dmtc1      %[tmp0],    %[ftmp13]                  \n\t"
&gt; @@ -340,9 +340,9 @@ static void convolve_avg_vert_mmi(const uint8_t *src, int32_t src_stride,
&gt;  
&gt;      __asm__ volatile (
&gt;          "pxor       %[ftmp0],    %[ftmp0],   %[ftmp0]      \n\t"
&gt; -        "gsldlc1    %[ftmp4],    0x03(%[filter])           \n\t"
&gt; +        "gsldlc1    %[ftmp4],    0x07(%[filter])           \n\t"
&gt;          "gsldrc1    %[ftmp4],    0x00(%[filter])           \n\t"
&gt; -        "gsldlc1    %[ftmp5],    0x0b(%[filter])           \n\t"
&gt; +        "gsldlc1    %[ftmp5],    0x0f(%[filter])           \n\t"
&gt;          "gsldrc1    %[ftmp5],    0x08(%[filter])           \n\t"
&gt;          "punpcklwd  %[filter10], %[ftmp4],   %[ftmp4]      \n\t"
&gt;          "punpckhwd  %[filter32], %[ftmp4],   %[ftmp4]      \n\t"
&gt; -- 
&gt; 2.1.0
&gt; 

LGTM.</jinbo@loongson.cn></jinbo@loongson.cn></jinbo@loongson.cn>
Michael Niedermayer June 3, 2021, 7:45 p.m. UTC | #2
On Tue, Jun 01, 2021 at 09:03:24PM +0800, yinshiyou-hf@loongson.cn wrote:
[...]
> &gt;          "punpcklwd  %[filter10], %[ftmp4],   %[ftmp4]      \n\t"
> &gt;          "punpckhwd  %[filter32], %[ftmp4],   %[ftmp4]      \n\t"
> &gt; -- 
> &gt; 2.1.0
> &gt; 
> 
> LGTM.</jinbo@loongson.cn></jinbo@loongson.cn></jinbo@loongson.cn>

will apply

thx

[...]
diff mbox series

Patch

diff --git a/libavcodec/mips/vp9_mc_mmi.c b/libavcodec/mips/vp9_mc_mmi.c
index fa65ff5..812f7a6 100644
--- a/libavcodec/mips/vp9_mc_mmi.c
+++ b/libavcodec/mips/vp9_mc_mmi.c
@@ -83,9 +83,9 @@  static void convolve_horiz_mmi(const uint8_t *src, int32_t src_stride,
     __asm__ volatile (
         "move       %[tmp1],    %[width]                   \n\t"
         "pxor       %[ftmp0],   %[ftmp0],    %[ftmp0]      \n\t"
-        "gsldlc1    %[filter1], 0x03(%[filter])            \n\t"
+        "gsldlc1    %[filter1], 0x07(%[filter])            \n\t"
         "gsldrc1    %[filter1], 0x00(%[filter])            \n\t"
-        "gsldlc1    %[filter2], 0x0b(%[filter])            \n\t"
+        "gsldlc1    %[filter2], 0x0f(%[filter])            \n\t"
         "gsldrc1    %[filter2], 0x08(%[filter])            \n\t"
         "li         %[tmp0],    0x07                       \n\t"
         "dmtc1      %[tmp0],    %[ftmp13]                  \n\t"
@@ -158,9 +158,9 @@  static void convolve_vert_mmi(const uint8_t *src, int32_t src_stride,
 
     __asm__ volatile (
         "pxor       %[ftmp0],    %[ftmp0],   %[ftmp0]      \n\t"
-        "gsldlc1    %[ftmp4],    0x03(%[filter])           \n\t"
+        "gsldlc1    %[ftmp4],    0x07(%[filter])           \n\t"
         "gsldrc1    %[ftmp4],    0x00(%[filter])           \n\t"
-        "gsldlc1    %[ftmp5],    0x0b(%[filter])           \n\t"
+        "gsldlc1    %[ftmp5],    0x0f(%[filter])           \n\t"
         "gsldrc1    %[ftmp5],    0x08(%[filter])           \n\t"
         "punpcklwd  %[filter10], %[ftmp4],   %[ftmp4]      \n\t"
         "punpckhwd  %[filter32], %[ftmp4],   %[ftmp4]      \n\t"
@@ -254,9 +254,9 @@  static void convolve_avg_horiz_mmi(const uint8_t *src, int32_t src_stride,
     __asm__ volatile (
         "move       %[tmp1],    %[width]                   \n\t"
         "pxor       %[ftmp0],   %[ftmp0],    %[ftmp0]      \n\t"
-        "gsldlc1    %[filter1], 0x03(%[filter])            \n\t"
+        "gsldlc1    %[filter1], 0x07(%[filter])            \n\t"
         "gsldrc1    %[filter1], 0x00(%[filter])            \n\t"
-        "gsldlc1    %[filter2], 0x0b(%[filter])            \n\t"
+        "gsldlc1    %[filter2], 0x0f(%[filter])            \n\t"
         "gsldrc1    %[filter2], 0x08(%[filter])            \n\t"
         "li         %[tmp0],    0x07                       \n\t"
         "dmtc1      %[tmp0],    %[ftmp13]                  \n\t"
@@ -340,9 +340,9 @@  static void convolve_avg_vert_mmi(const uint8_t *src, int32_t src_stride,
 
     __asm__ volatile (
         "pxor       %[ftmp0],    %[ftmp0],   %[ftmp0]      \n\t"
-        "gsldlc1    %[ftmp4],    0x03(%[filter])           \n\t"
+        "gsldlc1    %[ftmp4],    0x07(%[filter])           \n\t"
         "gsldrc1    %[ftmp4],    0x00(%[filter])           \n\t"
-        "gsldlc1    %[ftmp5],    0x0b(%[filter])           \n\t"
+        "gsldlc1    %[ftmp5],    0x0f(%[filter])           \n\t"
         "gsldrc1    %[ftmp5],    0x08(%[filter])           \n\t"
         "punpcklwd  %[filter10], %[ftmp4],   %[ftmp4]      \n\t"
         "punpckhwd  %[filter32], %[ftmp4],   %[ftmp4]      \n\t"