diff mbox series

[FFmpeg-devel,1/5] avfilter/vf_showinfo: minor adjustment for the dump format of ROI

Message ID 1632964440-24060-1-git-send-email-lance.lmwang@gmail.com
State New
Headers show
Series [FFmpeg-devel,1/5] avfilter/vf_showinfo: minor adjustment for the dump format of ROI
Related show

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

Limin Wang Sept. 30, 2021, 1:13 a.m. UTC
From: Limin Wang <lance.lmwang@gmail.com>

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
 libavfilter/vf_showinfo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Andreas Rheinhardt Sept. 30, 2021, 1:19 a.m. UTC | #1
lance.lmwang@gmail.com:
> From: Limin Wang <lance.lmwang@gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
>  libavfilter/vf_showinfo.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c
> index 87c2bed..5d97ef6 100644
> --- a/libavfilter/vf_showinfo.c
> +++ b/libavfilter/vf_showinfo.c
> @@ -147,10 +147,10 @@ static void dump_roi(AVFilterContext *ctx, const AVFrameSideData *sd)
>      }
>      nb_rois = sd->size / roi_size;
>  
> -    av_log(ctx, AV_LOG_INFO, "Regions Of Interest(RoI) information: ");
> +    av_log(ctx, AV_LOG_INFO, "Regions Of Interest(ROI) information: \n");
                                                                      ^
                                                      Unnecessary space

>      for (int i = 0; i < nb_rois; i++) {
>          roi = (const AVRegionOfInterest *)(sd->data + roi_size * i);
> -        av_log(ctx, AV_LOG_INFO, "index: %d, region: (%d, %d)/(%d, %d), qp offset: %d/%d.\n",
> +        av_log(ctx, AV_LOG_INFO, "index: %d, region: (%d, %d) -> (%d, %d), qp offset: %d/%d.\n",
>                 i, roi->left, roi->top, roi->right, roi->bottom, roi->qoffset.num, roi->qoffset.den);
>      }
>  }
>
Limin Wang Sept. 30, 2021, 1:29 a.m. UTC | #2
On Thu, Sep 30, 2021 at 03:19:39AM +0200, Andreas Rheinhardt wrote:
> lance.lmwang@gmail.com:
> > From: Limin Wang <lance.lmwang@gmail.com>
> > 
> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > ---
> >  libavfilter/vf_showinfo.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c
> > index 87c2bed..5d97ef6 100644
> > --- a/libavfilter/vf_showinfo.c
> > +++ b/libavfilter/vf_showinfo.c
> > @@ -147,10 +147,10 @@ static void dump_roi(AVFilterContext *ctx, const AVFrameSideData *sd)
> >      }
> >      nb_rois = sd->size / roi_size;
> >  
> > -    av_log(ctx, AV_LOG_INFO, "Regions Of Interest(RoI) information: ");
> > +    av_log(ctx, AV_LOG_INFO, "Regions Of Interest(ROI) information: \n");
>                                                                       ^
>                                                       Unnecessary space

Yes, will remove it, thanks.

> 
> >      for (int i = 0; i < nb_rois; i++) {
> >          roi = (const AVRegionOfInterest *)(sd->data + roi_size * i);
> > -        av_log(ctx, AV_LOG_INFO, "index: %d, region: (%d, %d)/(%d, %d), qp offset: %d/%d.\n",
> > +        av_log(ctx, AV_LOG_INFO, "index: %d, region: (%d, %d) -> (%d, %d), qp offset: %d/%d.\n",
> >                 i, roi->left, roi->top, roi->right, roi->bottom, roi->qoffset.num, roi->qoffset.den);
> >      }
> >  }
> > 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c
index 87c2bed..5d97ef6 100644
--- a/libavfilter/vf_showinfo.c
+++ b/libavfilter/vf_showinfo.c
@@ -147,10 +147,10 @@  static void dump_roi(AVFilterContext *ctx, const AVFrameSideData *sd)
     }
     nb_rois = sd->size / roi_size;
 
-    av_log(ctx, AV_LOG_INFO, "Regions Of Interest(RoI) information: ");
+    av_log(ctx, AV_LOG_INFO, "Regions Of Interest(ROI) information: \n");
     for (int i = 0; i < nb_rois; i++) {
         roi = (const AVRegionOfInterest *)(sd->data + roi_size * i);
-        av_log(ctx, AV_LOG_INFO, "index: %d, region: (%d, %d)/(%d, %d), qp offset: %d/%d.\n",
+        av_log(ctx, AV_LOG_INFO, "index: %d, region: (%d, %d) -> (%d, %d), qp offset: %d/%d.\n",
                i, roi->left, roi->top, roi->right, roi->bottom, roi->qoffset.num, roi->qoffset.den);
     }
 }