From patchwork Sat Dec 25 03:48:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lance Wang X-Patchwork-Id: 32905 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp8628211iog; Fri, 24 Dec 2021 19:49:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJw36X+cEzRCZB0aF1xPNiNdlHUejnPdPHn/qCLYfG4Ww3pzcdq9OsYRwusILca4cH+PO88a X-Received: by 2002:a05:6402:5107:: with SMTP id m7mr8038879edd.108.1640404169146; Fri, 24 Dec 2021 19:49:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1640404169; cv=none; d=google.com; s=arc-20160816; b=eeWUn657BVThgqIL/CdnUUNgTR/5+2m0cRiLpkHoJbMWt9XYombKJah5RD3rufMQ84 IU0aHtlU4Rpl91zr5vJVEhPP+MbvL7jyj48cSVFL3bNF6AAgW4cXrppqSkCJhWCeFwPA qJBl+IBlKR48LRYEiYC4H3qNqIFP5vq8Ptq3PgB/Y5ddEPzpWMx866xFHrEVj8mwa9ER duaRhG+Q6Fsui6lLC+mSpHmVgG0soatFrD1tbKXaXNAKbQLIT6sphArSRe3Hzb2javys qylBj05MSfLN5VKmb4F6QhpemGNbGtYSH6P1Flx9Yp7l+ZqmJ/HxwQCXw2o4H3vCs1YN j9SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to; bh=O3KhMv8GukRXb2/DHxBoozuFpfLcBrjFTEwLLeCdib8=; b=hJSwuH6Ip584prlcUCqNvWdkG/4z+TNma3md5v1Z2dgDF8qO8lzAk6NmcX8n5df6fA GKOV5Jds9M3U+Hh/jfgYGxet2+pJ90uUjDKaMPTmBFSQE8OYbkvaQkucpTdyyaXIuoee 9rHfm40Zvj1DjoEurcNySLiRNjdD+iPuajpVtrAFC03wtRjpB5jQbKjUtbFFtbsSUVr2 L+eZpmQMVxAyx1YYvP11r2sZV8AcfWO8CGRqt4DqXC4Lew2kuZaq33j0E0pHzpJV70hF Pki9lCtUm8OHQhqSS5ipzJwgZoM6HbiHLbDBUMSzRtw/27aWXZSLPjsfr8elT7Y3eqob D5Kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=G+4uiMnC; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id k25si3831946edx.419.2021.12.24.19.49.28; Fri, 24 Dec 2021 19:49:29 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=G+4uiMnC; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 16FBE68AFAF; Sat, 25 Dec 2021 05:49:17 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D466F68B04E for ; Sat, 25 Dec 2021 05:49:08 +0200 (EET) Received: by mail-pf1-f169.google.com with SMTP id m1so8993486pfk.8 for ; Fri, 24 Dec 2021 19:49:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=H6EJ84d5IZh9xE0/smqFIANi5zBamB/2+KcH/YOKOHw=; b=G+4uiMnCedCbyc+ICn16pB27ZWdJABXbIdjJiY6rH9fphOlX73+WyCOUlrab8+GSkU n63x+JMaOpuS/nx20PYHyApj7uq4GeXu7cIEJWaT7/FWYTi08iINbwGFjL0OsmmWUwam 2MP5lGRDmft24XSqp0uqwTyWdJvnZSItt22nfb3HL9q0Ak9oVpV4p42EZn2FrRApSOKy AIxLaoa+yaTS/D91c8aItCTrO4tHlmrz4YwxgN+LogGemIcsJbimO4IQnYxC1K6k0j/c RvKzoxZFlBSK9mB0p0/8HU5MePczZul26edXKGPnJR3+5UgbPKK1fLsTD7JcanXVB7rV WoPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=H6EJ84d5IZh9xE0/smqFIANi5zBamB/2+KcH/YOKOHw=; b=Qtj5D34EXdWJ2FiD6pP97D7whEkRqr5EKgpmQTKUEVw7huK3CWiPhxCTfTcv2A4Rq+ ikQF+dJgzH6lRNF29JfDB73iEYIAEpecB9WDRwq0jqLw0AUd+VQO7eiZOgyxoL+8d9i4 GMVoV1/5YUERXeqTVMZEMjodXYFtq/3xwgElflX9FQsBQ7HFKiEuF/ZvKlCqhgmUZESt M/kmSqzhpDrpUyWqJP1uVWF5ZROELKTU4PqVzPqYwdLrux7paPilt0MGtSl7WLYl0005 EjkqcOqCh04+oFacHOQmrCPkQcEyImykS2K+Kp55E0SvsFUtagZ97FazxlQPyY6ZzN8H mU+g== X-Gm-Message-State: AOAM533MVDraiQQuS/zsxwbsaqd4goNTaY0pSUzMkVhN2Bv2rq/y0WsA C3k4/hBt5+Sqy7/NzPevHbk2yybIZHU= X-Received: by 2002:a63:8c5a:: with SMTP id q26mr5796244pgn.17.1640404146500; Fri, 24 Dec 2021 19:49:06 -0800 (PST) Received: from vpn2.localdomain ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id l2sm7418445pfu.13.2021.12.24.19.49.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Dec 2021 19:49:06 -0800 (PST) From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Sat, 25 Dec 2021 11:48:59 +0800 Message-Id: <1640404139-7205-2-git-send-email-lance.lmwang@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1640404139-7205-1-git-send-email-lance.lmwang@gmail.com> References: <1640404139-7205-1-git-send-email-lance.lmwang@gmail.com> Subject: [FFmpeg-devel] [PATCH 2/2] avcodec/qsvenc_h264: use AV_OPT_TYPE_BOOL for aud, a53cc, cavlc, look_ahead, pic_timing_sei options X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Limin Wang MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: j0c2pvOZbxtF From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/qsvenc_h264.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/qsvenc_h264.c b/libavcodec/qsvenc_h264.c index 80fe3cc..9f12760 100644 --- a/libavcodec/qsvenc_h264.c +++ b/libavcodec/qsvenc_h264.c @@ -103,17 +103,17 @@ static av_cold int qsv_enc_close(AVCodecContext *avctx) static const AVOption options[] = { QSV_COMMON_OPTS - { "cavlc", "Enable CAVLC", OFFSET(qsv.cavlc), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, VE }, + { "cavlc", "Enable CAVLC", OFFSET(qsv.cavlc), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE }, #if QSV_HAVE_VCM - { "vcm", "Use the video conferencing mode ratecontrol", OFFSET(qsv.vcm), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, VE }, + { "vcm", "Use the video conferencing mode ratecontrol", OFFSET(qsv.vcm), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE }, #endif { "idr_interval", "Distance (in I-frames) between IDR frames", OFFSET(qsv.idr_interval), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, VE }, - { "pic_timing_sei", "Insert picture timing SEI with pic_struct_syntax element", OFFSET(qsv.pic_timing_sei), AV_OPT_TYPE_INT, { .i64 = 1 }, 0, 1, VE }, + { "pic_timing_sei", "Insert picture timing SEI with pic_struct_syntax element", OFFSET(qsv.pic_timing_sei), AV_OPT_TYPE_BOOL, { .i64 = 1 }, 0, 1, VE }, { "single_sei_nal_unit", "Put all the SEI messages into one NALU", OFFSET(qsv.single_sei_nal_unit), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 1, VE }, { "max_dec_frame_buffering", "Maximum number of frames buffered in the DPB", OFFSET(qsv.max_dec_frame_buffering), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, UINT16_MAX, VE }, #if QSV_HAVE_LA - { "look_ahead", "Use VBR algorithm with look ahead", OFFSET(qsv.look_ahead), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, VE }, + { "look_ahead", "Use VBR algorithm with look ahead", OFFSET(qsv.look_ahead), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE }, { "look_ahead_depth", "Depth of look ahead in number frames", OFFSET(qsv.look_ahead_depth), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 100, VE }, #endif #if QSV_HAVE_LA_DS @@ -139,9 +139,9 @@ static const AVOption options[] = { { "main" , NULL, 0, AV_OPT_TYPE_CONST, { .i64 = MFX_PROFILE_AVC_MAIN }, INT_MIN, INT_MAX, VE, "profile" }, { "high" , NULL, 0, AV_OPT_TYPE_CONST, { .i64 = MFX_PROFILE_AVC_HIGH }, INT_MIN, INT_MAX, VE, "profile" }, - { "a53cc" , "Use A53 Closed Captions (if available)", OFFSET(qsv.a53_cc), AV_OPT_TYPE_INT, {.i64 = 1}, 0, 1, VE}, + { "a53cc" , "Use A53 Closed Captions (if available)", OFFSET(qsv.a53_cc), AV_OPT_TYPE_BOOL, {.i64 = 1}, 0, 1, VE}, - { "aud", "Insert the Access Unit Delimiter NAL", OFFSET(qsv.aud), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, VE}, + { "aud", "Insert the Access Unit Delimiter NAL", OFFSET(qsv.aud), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE}, #if QSV_HAVE_MF { "mfmode", "Multi-Frame Mode", OFFSET(qsv.mfmode), AV_OPT_TYPE_INT, { .i64 = MFX_MF_AUTO }, MFX_MF_DEFAULT, MFX_MF_AUTO, VE, "mfmode"},