From patchwork Sun Jan 2 00:43:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lance Wang X-Patchwork-Id: 33000 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp15081684iog; Sat, 1 Jan 2022 16:43:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJy33XSlLSQVKZn5uPyZCG8TIaA882K93zdcvOpHAL+kYcu0FuBxE2NnKzFlkh18OUnYkRFO X-Received: by 2002:a17:907:948f:: with SMTP id dm15mr33282361ejc.250.1641084235545; Sat, 01 Jan 2022 16:43:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1641084235; cv=none; d=google.com; s=arc-20160816; b=B3HfxFhFczB3Bag7vYLo7Ly4iovwoYurta9Nxe6i6YNM0HU6Ikxzv6LWICJ4eQS/j0 VdWCWPdshUp9CqtHbFQ6L7AAGToqdzfPWfayms9bpEN1AIzjrq3jezPkYXdf28AGFOMT e50r0JKd3xWdNwNEptSG1ZmnFKyOIKV+UtkVt4XKca8m7FNbnZ7P3fSIuQUXBZMtOARR O5UVBuZSHg5+7dqItGg7cw3nsc37UGIUONL82kn1L/T2xkUKz0TX/uW65MAppJl6bLdQ GCAmy+KD00gQyg04nHPmoVVEocqlIwqEvZsu1kGxG9ZPcDt6rGfZaMWKzNyypoZXXRG7 nmNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to; bh=BL3uQPh5vathtHLDBW7biddiG+9DQW8trg6Z/GPYc8I=; b=X8grq+6R2wkDgacz7EHfjOmPMizvtjmb4Hq+/0Feya+wzSDmuE4j9thNcd3MX64EN1 Q00YzCYzykURZW5yyPjP+678vnTDU1iyce0cwzlMo/3JAp27jLQVEcIYBFUaUHVUGy8Z krdQ776++mOzXHV5TOVltoBRk+HW1E5ngUNR9RYDuem7dHN0pWH6L7XxtI0AuKgdYuys pY+F0cX2k0L3LyTh7W33xK/6myGT8rKSQsO8xcJKjGW3DRdvusf8Og6Ei4rr8WPsYO5M qOfleR+QT3gsWWbWbOslBEf/CCH3s29qlU59yihzIjL+eWLLHCsaBTr/wSVUutYg6LLt mKZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=BaJqE7om; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id n8si15493030edr.225.2022.01.01.16.43.54; Sat, 01 Jan 2022 16:43:55 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=BaJqE7om; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 75DD568B0F7; Sun, 2 Jan 2022 02:43:50 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6925568B095 for ; Sun, 2 Jan 2022 02:43:43 +0200 (EET) Received: by mail-pl1-f181.google.com with SMTP id w24so22519694ply.12 for ; Sat, 01 Jan 2022 16:43:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4I4aNgQQxL8mwUaisK6MQLrgKFzLUX6sLDmsIU4K8qQ=; b=BaJqE7omHaYCK+AbXZd/YosSNYSR8dw9STAdl8SXFgcO01jZNe9JdpPtlJDLFK3HXh 1OhM+3a+HqdwObf76BPweKNI8RflhTc1I7bOVacKVkzY3fQRfxu+yPLLuh6lubSxXot5 Li9l5l4Ko4UwghboQ4gYhrt3NytvkdNnTkN5uutXvgIrIHh+2ag8ay/ohPl3TxWUjcIt MXHpWNouwWupT8e4Elz7p/15UcK37MS/1g+Tp70fB03ITRcXHZD1lUOLSgaGG5QaWIGM OCw4omlP1rA4OosIYCAR5jGNJS6fPd/eYoASQ0dyfyO0b3r544LQtoAmc07FexxpnVXF 6VLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4I4aNgQQxL8mwUaisK6MQLrgKFzLUX6sLDmsIU4K8qQ=; b=6Sj9DU86dMe98e+SWpuXDbxXqeEYw0apKl0YYhYiQ7t7fJHRl/DoQdNLYkmFV05+7r 7G0/PP0q7GEVXL/xiJeBKFoqJCnXpWExRwv7ICufEiDBHMaH7pW/CEXvgXW5/6/zLBAZ bXqlxOu0NdD2uW/Z8+gFdq+7qz68LqIefIhpX3w8jzcoWAkyitfmoRfVTkrQW3UzfVgh jfKMaW+b3VtcI1cB3pZJygG2GsPusfxHL1e87bxTrPZ3QyViIOoCSoct976fCBQucRnM cdtvuadamZRkfnc/BEN5WIf+k909g0KMNVhJk+QF+a0LY/dnM+Yzwo2+eDWFdc4i95ce uIyg== X-Gm-Message-State: AOAM532JTAuEHt0Q5nDcon8glOgpmZUKIjH75tdATY1aP0Nr36pyzieR vxJi/04da6LWJmKcQQDrq5VxLS7r2aI= X-Received: by 2002:a17:902:8ec9:b0:149:8864:cfd4 with SMTP id x9-20020a1709028ec900b001498864cfd4mr25230999plo.16.1641084221469; Sat, 01 Jan 2022 16:43:41 -0800 (PST) Received: from vpn2.localdomain ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id c12sm337690pjo.55.2022.01.01.16.43.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 01 Jan 2022 16:43:41 -0800 (PST) From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Sun, 2 Jan 2022 08:43:31 +0800 Message-Id: <1641084211-21706-2-git-send-email-lance.lmwang@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1641084211-21706-1-git-send-email-lance.lmwang@gmail.com> References: <1641084211-21706-1-git-send-email-lance.lmwang@gmail.com> Subject: [FFmpeg-devel] [PATCH 2/2] avformat/rtpenc_rfc4175: support for interlace format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Limin Wang MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: /XBSCcX9ckW0 From: Limin Wang Below is step for how to test in your local machine: wget --no-check-certificate https://samples.ffmpeg.org/MPEG2/interlaced/burosch1.mpg 1. test interlace: ffmpeg -re -i ./burosch1.mpg -c:v bitpacked -pix_fmt yuv422p10 -f rtp rtp://239.255.0.1:6000 copy and create sdp file test.sdp ffplay -buffer_size 671088640 -protocol_whitelist "file,http,https,rtp,udp,tcp,tls" test.sdp 2. test progressive: ffmpeg -re -i ./burosch1.mpg -vf yadif -c:v bitpacked -pix_fmt yuv422p10 -f rtp rtp://239.255.0.1:6000 copy and create sdp file test.sdp ffplay -buffer_size 671088640 -protocol_whitelist "file,http,https,rtp,udp,tcp,tls" test.sdp Signed-off-by: Limin Wang --- If someone have other interface source from hardware, please help to test. libavformat/rtpenc.c | 9 +++++++-- libavformat/rtpenc.h | 2 +- libavformat/rtpenc_rfc4175.c | 31 +++++++++++++++++++++---------- libavformat/sdp.c | 5 ++++- 4 files changed, 33 insertions(+), 14 deletions(-) diff --git a/libavformat/rtpenc.c b/libavformat/rtpenc.c index 17f5d9d..6be67b5 100644 --- a/libavformat/rtpenc.c +++ b/libavformat/rtpenc.c @@ -622,9 +622,14 @@ static int rtp_write_packet(AVFormatContext *s1, AVPacket *pkt) ff_rtp_send_jpeg(s1, pkt->data, size); break; case AV_CODEC_ID_BITPACKED: - case AV_CODEC_ID_RAWVIDEO: - ff_rtp_send_raw_rfc4175 (s1, pkt->data, size); + case AV_CODEC_ID_RAWVIDEO: { + int interlaced = st->codecpar->field_order != AV_FIELD_PROGRESSIVE; + + ff_rtp_send_raw_rfc4175(s1, pkt->data, size, interlaced, 0); + if (interlaced) + ff_rtp_send_raw_rfc4175(s1, pkt->data, size, interlaced, 1); break; + } case AV_CODEC_ID_OPUS: if (size > s->max_payload_size) { av_log(s1, AV_LOG_ERROR, diff --git a/libavformat/rtpenc.h b/libavformat/rtpenc.h index 70ea85b..9c8ad14 100644 --- a/libavformat/rtpenc.h +++ b/libavformat/rtpenc.h @@ -95,7 +95,7 @@ void ff_rtp_send_vc2hq(AVFormatContext *s1, const uint8_t *buf, int size, int in void ff_rtp_send_vp8(AVFormatContext *s1, const uint8_t *buff, int size); void ff_rtp_send_vp9(AVFormatContext *s1, const uint8_t *buff, int size); void ff_rtp_send_jpeg(AVFormatContext *s1, const uint8_t *buff, int size); -void ff_rtp_send_raw_rfc4175(AVFormatContext *s1, const uint8_t *buf, int size); +void ff_rtp_send_raw_rfc4175(AVFormatContext *s1, const uint8_t *buf, int size, int interlaced, int field); const uint8_t *ff_h263_find_resync_marker_reverse(const uint8_t *av_restrict start, const uint8_t *av_restrict end); diff --git a/libavformat/rtpenc_rfc4175.c b/libavformat/rtpenc_rfc4175.c index ea4c370..257d072 100644 --- a/libavformat/rtpenc_rfc4175.c +++ b/libavformat/rtpenc_rfc4175.c @@ -21,36 +21,40 @@ #include "avformat.h" #include "rtpenc.h" -void ff_rtp_send_raw_rfc4175(AVFormatContext *s1, const uint8_t *buf, int size) +void ff_rtp_send_raw_rfc4175(AVFormatContext *s1, const uint8_t *buf, int size, int interlaced, int field) { RTPMuxContext *s = s1->priv_data; int width = s1->streams[0]->codecpar->width; int height = s1->streams[0]->codecpar->height; int xinc, yinc, pgroup; - int field = 0; int i = 0; int offset = 0; s->timestamp = s->cur_timestamp; switch (s1->streams[0]->codecpar->format) { case AV_PIX_FMT_UYVY422: - xinc = yinc = 2; + xinc = 2; + yinc = 1 << interlaced; pgroup = 4; break; case AV_PIX_FMT_YUV422P10: - xinc = yinc = 2; + xinc = 2; + yinc = 1 << interlaced; pgroup = 5; break; case AV_PIX_FMT_YUV420P: - xinc = yinc = 4; + xinc = 4; + yinc = 1 << interlaced; pgroup = 6; break; case AV_PIX_FMT_RGB24: - xinc = yinc = 1; + xinc = 1; + yinc = 1 << interlaced; pgroup = 3; break; case AV_PIX_FMT_BGR24: - xinc = yinc = 1; + xinc = 1; + yinc = 1 << interlaced; pgroup = 3; break; default: @@ -72,7 +76,9 @@ void ff_rtp_send_raw_rfc4175(AVFormatContext *s1, const uint8_t *buf, int size) headers = dest; do { - pixels = width * xinc - offset; + int l_line; + + pixels = width - offset; length = (pixels * pgroup) / xinc; left -= head_size; @@ -90,8 +96,9 @@ void ff_rtp_send_raw_rfc4175(AVFormatContext *s1, const uint8_t *buf, int size) *dest++ = length & 0xff; /* Line No */ - *dest++ = ((i >> 8) & 0x7f) | ((field << 7) & 0x80); - *dest++ = i & 0xff; + l_line = i >> interlaced; + *dest++ = ((l_line >> 8) & 0x7f) | ((field << 7) & 0x80); + *dest++ = l_line & 0xff; if (next_line) i += yinc; cont = (left > (head_size + pgroup) && i < height) ? 0x80 : 0x00; @@ -106,16 +113,20 @@ void ff_rtp_send_raw_rfc4175(AVFormatContext *s1, const uint8_t *buf, int size) } while (cont); do { + int l_field; int l_line; int l_off; int copy_offset; length = (headers[0] << 8) | headers[1]; + l_field = (headers[2] & 0x80) >> 7; l_line = ((headers[2] & 0x7f) << 8) | headers[3]; l_off = ((headers[4] & 0x7f) << 8) | headers[5]; cont = headers[4] & 0x80; headers += head_size; + if (interlaced) + l_line = 2 * l_line + l_field; copy_offset = (l_line * width + l_off) * pgroup / xinc; if (copy_offset + length > size) break; diff --git a/libavformat/sdp.c b/libavformat/sdp.c index 111a25b..ec05d4b 100644 --- a/libavformat/sdp.c +++ b/libavformat/sdp.c @@ -728,9 +728,12 @@ static int sdp_write_media_attributes(char *buff, int size, const AVStream *st, av_strlcatf(buff, size, "a=rtpmap:%d raw/90000\r\n" "a=fmtp:%d sampling=%s; " "width=%d; height=%d; " - "depth=%d\r\n", + "depth=%d", payload_type, payload_type, pix_fmt, p->width, p->height, bit_depth); + if (p->field_order != AV_FIELD_PROGRESSIVE) + av_strlcatf(buff, size, "; interlace"); + av_strlcatf(buff, size, "\r\n"); break; }