From patchwork Tue Jan 4 09:43:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lance Wang X-Patchwork-Id: 33057 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp16831070iog; Tue, 4 Jan 2022 01:43:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJx+xggZO2AycGZch2xlThCXWm/R7/uWgBLugjFop54ofrhBRD+5lneRGlS8n5u1uznWD2oA X-Received: by 2002:a17:907:6093:: with SMTP id ht19mr39691838ejc.286.1641289409970; Tue, 04 Jan 2022 01:43:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1641289409; cv=none; d=google.com; s=arc-20160816; b=GkqoV7aGA61pTl5Rmnaax/zh2z2sV2Ce4EFizuV26BUpDliTOpm14bWh9H36YZGCi3 iVyZYvy7pbRAzVddaLEtkYupvjmjloHdErXZ4nnFRzbdSMLOw3HY8KSCvxS0HlWamZOD eOBbMKpEQT0cIkZtkN6pL8J8PCMt1eQIv65ELf9246jRRtoZcqtMzhqv1tpW3i0tFydO R7A7OKJx4y733V6ACKReVCJVoGZjOSU8pZkm1kmODI33/jGJPSDkjO5E0B3/aUAjomBW mjs4rZRoYJvk6QZRpjd0fIyjlF7hbeo9GB1SzczmRY8v0+sJefdDE9aoVSwDxYX3aM6c 76vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to; bh=I7Xi1B2JcIEgO/GeEZSkN2xe3OtSp647gmb83VXqguw=; b=Xn9dNCrpBebS96RtvCy7Oq6joKnvMluIq7mhCOPYmEC+6tITMeKMRhAuM6lrHB7QbJ s1dydw78ijZJyeaE326cdZtr88KiMhrZt30lYoNC1Smm6T3sJweIXKfzXkhnEpIiPpje 90XKr7POGdCgBJov5zgSW4KKhc82eJTQqjND7XcbrRrgPPoY/o1qRrEMQeWzxhdA4qnd Kzs1ZcUil3EohNflH0LGhA5+93/pjsFC3ptskqkijHTXcX8kO84iKyCDjnix+ZZSomUx +hNhUFxlgzpT+nWLoXNxRfuYzIIqTX159bEEWGW4bpG/GZAQD+gRIlJ8qERsqIhheTB4 6lGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=p81B6qlF; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id go41si18532112ejc.680.2022.01.04.01.43.29; Tue, 04 Jan 2022 01:43:29 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=p81B6qlF; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5628168AB5B; Tue, 4 Jan 2022 11:43:27 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 46F0968807F for ; Tue, 4 Jan 2022 11:43:21 +0200 (EET) Received: by mail-pj1-f41.google.com with SMTP id g11-20020a17090a7d0b00b001b2c12c7273so1442472pjl.0 for ; Tue, 04 Jan 2022 01:43:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=PnP3FzcGnY2wfHFmObvUPq/Dlx+nnK+H8iDwu2qqi1o=; b=p81B6qlFTBE0IKR6ij2xyTnSJFxNlGzV8qsvTt4Ysm+emMFwlYTIG9xuxpXVF1ZxqH K/eH1VFRC6/YoPL4IlAjjLzhQPHge1HX2llRoZIeZiH32P4+l+RrOgf6E09olhMWdqyz 0IZVwxb1jQfJukYYRjH1wFG0b1fzOW69xgV+CZ1z60QsXKXGddNaqjiVVlqYIBBOy/dg KF79qyCkd5p5rGw818Auu4toZzSApMa0ZaLT+s1FQTKDe+y69LN8sm1D31muPCsNuZ+F q6nDRh8w6U5MNEdLVxDfgjRwpBNXkMSdaPx/bp3SJuG8SvCCtfZLfOn/eFjZYdFYT92D P7xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=PnP3FzcGnY2wfHFmObvUPq/Dlx+nnK+H8iDwu2qqi1o=; b=z61ry4S3ag4+YI3P89iioGAwlgfPXl7gRG9+xvTOdRC5rdbNnWKiqgmrOfSZ9QDKgc VjkeWQYOLhOwxyYmgQ+TLZ/zFyl8SAmDFYnAIodMw/E41eQwxVMP8rMbStiZjO/vFCEH xZmjaoIl4kOIvlfDoLrxObP9/APZ80H5udzv2HFpIl7/xper/YCP2pl4pJMWwcHFI2T7 35CTYR72fLv6TL1BW6tKBL+zzDssGWigDSoX/XKjflm5Wke/kEWHhPA70xhpH/ucds+Y dhOqUAmApU0c0vA93xgKeU0tCAnDY190Yo0LC/AgGyiS7jYZUVfYea1oH/CusyByUx35 PdMw== X-Gm-Message-State: AOAM530ZDlqo0a4FPgHvWQ2VTC1MHNl+9sL507Mx1ntM3U4Co1MByrxS HcDN9oRgq1ZA6AscYby+8ChxJAEgHP0= X-Received: by 2002:a17:90b:3014:: with SMTP id hg20mr60052258pjb.69.1641289399411; Tue, 04 Jan 2022 01:43:19 -0800 (PST) Received: from vpn2.localdomain ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id lw5sm41292729pjb.13.2022.01.04.01.43.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jan 2022 01:43:19 -0800 (PST) From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Tue, 4 Jan 2022 17:43:13 +0800 Message-Id: <1641289393-4372-1-git-send-email-lance.lmwang@gmail.com> X-Mailer: git-send-email 1.8.3.1 Subject: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: Fix undefined symbol with minimal configuration X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Limin Wang MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: qnXolqZjgYZP From: Limin Wang Please reproduced with the following minimal configure command: ./configure --enable-shared --disable-all --enable-avcodec --enable-decoder=h264 --enable-hwaccel=h264_videotoolbox You'll get below error: Undefined symbols for architecture x86_64: "_ff_videotoolbox_vpcc_extradata_create", referenced from: _videotoolbox_start in videotoolbox.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) Reported-by: Cameron Gutman Signed-off-by: Limin Wang Tested-by: Cameron Gutman --- libavcodec/videotoolbox.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c index 69beb38..51d4eac 100644 --- a/libavcodec/videotoolbox.c +++ b/libavcodec/videotoolbox.c @@ -825,11 +825,13 @@ static CFDictionaryRef videotoolbox_decoder_config_create(CMVideoCodecType codec if (data) CFDictionarySetValue(avc_info, CFSTR("hvcC"), data); break; +#if CONFIG_VP9_VIDEOTOOLBOX_HWACCEL case kCMVideoCodecType_VP9 : data = ff_videotoolbox_vpcc_extradata_create(avctx); if (data) CFDictionarySetValue(avc_info, CFSTR("vpcC"), data); break; +#endif default: break; }