From patchwork Fri Jan 14 09:55:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lance Wang X-Patchwork-Id: 33593 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp177716iog; Fri, 14 Jan 2022 01:55:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJzidKoenuI+ZqR6MjSJmxIl7Of6fBGyG/mwECES+Vnf1yFc6bD539/bnmfSrZHVpD/ypEKp X-Received: by 2002:a17:906:31c4:: with SMTP id f4mr6673574ejf.6.1642154152487; Fri, 14 Jan 2022 01:55:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642154152; cv=none; d=google.com; s=arc-20160816; b=cjWxmfo7uTjZAAcW31KipmPcIng3MxQr+eWhIk5iU8Xb1XWr23ML/ol0zTUfdh3sUP b5+tmPpe/WC1wMLQEHmRY5Ns/vVVg0q9evHqMWePEZoprY+TX94WHUz0rBSmY5J+aTcn R3V/LIb2HTVsvbG5DeqrowDj2ZXP/Vg5c2JREChzuqx9k4ahYdwcc4BojxDpP0SShvyg jSMMAo08OczmByjpDMSlQLbxVVmoF5TLIAACPuEREszem0p43sUEEnlM7PYvxgl+uToY yhwPNiFS2wOAqWPllyoVe+GfOHmK//ZuWrTbfocQ1kHvgJgOHyEsuiIQm6WBcogJngZo S73g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=TjfzSxA6V1Dr8WrwdjG0FTpZN7AAmhm29GyhkcSQTJA=; b=r51MCs9Zy5jkW+Nl4AK17o2G58NBT/Xq/hHARsXMjGpzr4h29QLeiRwBLRZ2ZckdlX MyDlGv7c8UAmvVEWVCc3VgPWMSqQBb9kLuqRnh4Xsq4mIwX0J6j56R0RH8UYUvrduSRV xJRcMpxYx+KUeAF+4a12nSncXFXp42vuKquerrQvCYyjhYD/rCse4nlowrSN7eva3nUZ SNLNK4S87qqNc3BZivsvcLndiGwSTjNbgEFzoM73SkPKUrO1tcqW3JEk/IWSEmaG4JG6 m4KPOyYlziyXFxZC249k4wkojwVkUJmHXVdekewxyzdFYqQUhXRw55yMk3Qk9RCXzdlk Ab/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=p3y0c11Z; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id t13si3033726edd.590.2022.01.14.01.55.52; Fri, 14 Jan 2022 01:55:52 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=p3y0c11Z; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5C7D868B4F9; Fri, 14 Jan 2022 11:55:34 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9C4DB68B317 for ; Fri, 14 Jan 2022 11:55:27 +0200 (EET) Received: by mail-pj1-f43.google.com with SMTP id l10-20020a17090a384a00b001b22190e075so21453784pjf.3 for ; Fri, 14 Jan 2022 01:55:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PZmUiG/FR/vMkJW+dorrSMk5yEqz310SN/sPk/32AvU=; b=p3y0c11ZBuVUuOKG2HDdKzyWj89TewO4DtKcMKN8G1TpqyjufjyIfNmwR8LHCQq2cH IsvL48x4w3QpFZu9+UtkucvZxnoQIFdWjLXM/qONpgAaPN0RJWkxP0FgQv6nz+94eigZ kLs47eHr9iYkwYAe+Xz58jm1N6cL7gEd3MtjP4ImO3Vr6fe39saOq9SJM2Cz+yGwV7Xm v0FLrV04fruMp1V+AHAm+6IALYekI/Eh/ji3kSWj5E2v/tF0l9cNlKK9OqQtHbC4Hfi+ XT8r8flcfxyFxvNfY4xNcO5SfkJOuqzqTeLOakvl91EAayFxf1zFV8iKlJPa4FMgvxm7 s6LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PZmUiG/FR/vMkJW+dorrSMk5yEqz310SN/sPk/32AvU=; b=p1mwvLFtzuX5+6XPae5zEbcJ2lF/iqdaWmTok4ZijGvwgP4/fy/223wq0TTZr76qrz W/pwjIQpA/WzKM1RNdqymrsdpPC2Wbd9l1UJqpnoIBEhVyRS/BME49l0KzxEuowaSl0d AQLE/30v3j1vRyGyki4f2uv6p68puEBKJ8fmIQAU7B9hSUIyJGGGr0BwQFr9mUDxgjwJ 1D7NdIHI8JNiaTIwMhUuxcw4uo0tWKYZgthUk9Q53y7QixyY+sbZv3KqzkV7+JI/HBRe 7rjmZY039UYQpBvSqTPdMVai9t5kN4Sj0ZR0lqwwrMQM3VvzAwbmrdH0we2pnGdnn7V5 3s+g== X-Gm-Message-State: AOAM530oXMWC1HsLU0KIVh00K/J/J0ubDfP1MffQCGM+LA2xo/8qlTC8 bkIJpXBAl8sF+h2bCuWzSCB3PVKtgf4= X-Received: by 2002:a17:90a:c918:: with SMTP id v24mr19461811pjt.208.1642154125969; Fri, 14 Jan 2022 01:55:25 -0800 (PST) Received: from vpn2.localdomain ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id l12sm5535400pfc.181.2022.01.14.01.55.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Jan 2022 01:55:25 -0800 (PST) From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Fri, 14 Jan 2022 17:55:17 +0800 Message-Id: <1642154117-24138-3-git-send-email-lance.lmwang@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1642154117-24138-1-git-send-email-lance.lmwang@gmail.com> References: <1642070709-3104-1-git-send-email-lance.lmwang@gmail.com> <1642154117-24138-1-git-send-email-lance.lmwang@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3 3/3] avcodec/libopenh264enc: set iEntropyCodingModeFlag by coder option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Limin Wang Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: mj4fmYI3w7IZ From: Limin Wang For high/main profile, user can choose to use cavlc by specify "-coder cavlc", for default, it'll will use cabac, if it's baseline, we'll use cavlc by specs anyway. ffmpeg -y -f lavfi -i testsrc -c:v libopenh264 -profile:v main -coder cavlc -frames:v 1 -bsf trace_headers -f null - before the patch: entropy_coding_mode_flag 0 = 1 after the patch: entropy_coding_mode_flag 0 = 0 Reviewed-by: Martin Storsjö Signed-off-by: Limin Wang --- libavcodec/libopenh264enc.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index 1bad233..a1e78c9 100644 --- a/libavcodec/libopenh264enc.c +++ b/libavcodec/libopenh264enc.c @@ -193,7 +193,7 @@ static av_cold int svc_encode_init(AVCodecContext *avctx) #endif param.bPrefixNalAddingCtrl = 0; param.iLoopFilterDisableIdc = !s->loopfilter; - param.iEntropyCodingModeFlag = 0; + param.iEntropyCodingModeFlag = s->coder >= 0 ? s->coder : 1; param.iMultipleThreadIdc = avctx->thread_count; /* Allow specifying the libopenh264 profile through AVCodecContext. */ @@ -221,14 +221,14 @@ static av_cold int svc_encode_init(AVCodecContext *avctx) switch (s->profile) { case FF_PROFILE_H264_HIGH: - param.iEntropyCodingModeFlag = 1; - av_log(avctx, AV_LOG_VERBOSE, "Using CABAC, " - "select EProfileIdc PRO_HIGH in libopenh264.\n"); + av_log(avctx, AV_LOG_VERBOSE, "Using %s, " + "select EProfileIdc PRO_HIGH in libopenh264.\n", + param.iEntropyCodingModeFlag ? "CABAC" : "CAVLC"); break; case FF_PROFILE_H264_MAIN: - param.iEntropyCodingModeFlag = 1; - av_log(avctx, AV_LOG_VERBOSE, "Using CABAC, " - "select EProfileIdc PRO_MAIN in libopenh264.\n"); + av_log(avctx, AV_LOG_VERBOSE, "Using %s, " + "select EProfileIdc PRO_MAIN in libopenh264.\n", + param.iEntropyCodingModeFlag ? "CABAC" : "CAVLC"); break; case FF_PROFILE_UNKNOWN: s->profile = FF_PROFILE_H264_CONSTRAINED_BASELINE;