From patchwork Wed Mar 2 13:58:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lance Wang X-Patchwork-Id: 34570 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6838:d078:0:0:0:0 with SMTP id x24csp4658359nkx; Wed, 2 Mar 2022 05:58:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJzY2UY2eFVFr623cd/x3m0cgVIDXHmRe71SQflkdujzImsh2giQMCndQuKgkfsMaERVTMb0 X-Received: by 2002:a17:907:3f25:b0:6b0:5e9a:83 with SMTP id hq37-20020a1709073f2500b006b05e9a0083mr24070195ejc.659.1646229531883; Wed, 02 Mar 2022 05:58:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646229531; cv=none; d=google.com; s=arc-20160816; b=D8rIr8SwbMOpf4E5X7q+8hqSNW0ypBDEdoHwI79WofXN07hAufjh7mGjdDJmmm00Wd 6z/FNzKsRUkI1URCP7n+8gwBtqLc3TukLMXNmDT0mydHd3YMXDmYNxPhgbhO7QVjgaaa 8ebJKTep23P4GEh6y01biPmq+1AbeqQO1plZEErJpEcC1FMNn0AB4XggiEvJo2krF/FE RExIDr4+GBhOK+F8Zr5hrAKvI4Y+HkUFaxQKxIzh2y5ZitG479vVu9UO0dTkjw5xlQue 7eUwUxqC9y2sQAiLy4r82eeAv9amfr/WtorHAZDFtghsTXW/q0969ikUuRt3hxiDLFQ7 3yGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to; bh=EoMEaNTUSO35uj0GyOepXEp1q5Ycj9tBeaxmGKsGrAk=; b=vzKYx7PVjP5iP0l2+C/1e1A/z9lIosNESAIvC7idAs49yZMXUu6JURFXIjy/glbOcS AJW16/3x8xWX9C3VA3sNVTR5BNlBV8a0ro1nywUBEaMzYh+1j6DptNinvDP2+OxCO0jH RgNp2C4zS3YwjOLr9voamthleZaNIb0aQcr4PQdNzj4wiExvYYnSAguwGxLp0j8kkIGC /HSTNuLCQ1prvIxOiODbTi6QN8+YQHAF54lt129nj/GqGh5YGqYfwTxOhmU8pxWP6O0v nrGXqSB+wCH1n9gAvHXkIzuhFbGH9aKFbYBR3ZzOZi+gORMHxAHPpAEUWuv/07T1MLNe PnYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=X9Ol6RaU; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 8-20020a170906024800b006ac3d8b2389si10230144ejl.847.2022.03.02.05.58.50; Wed, 02 Mar 2022 05:58:51 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=X9Ol6RaU; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C829768B2BB; Wed, 2 Mar 2022 15:58:46 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5234A68A800 for ; Wed, 2 Mar 2022 15:58:40 +0200 (EET) Received: by mail-pj1-f54.google.com with SMTP id bx5so1833344pjb.3 for ; Wed, 02 Mar 2022 05:58:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=7g6llygrv9zMOmxjpX8DM6M5PtpXyu9IH92jo7HTipY=; b=X9Ol6RaUiQzdWwYURrKLk+KnuRozQ23V2VLhlg/b1L+qWMbYo4LJdEm+VuxoSd2NyW //6bW2iL5NmRkRKFPBlmdOPA3apQYls/paqZ/ZNx+J4iGQy0+Fpx5i3Cz7YYw4r3yGT+ Zi91rciNsGRsb1Pqflt90UlBvDp+bkHVX1ttmsDimS/9RIu+wmS/elTeZsZetl71d8Hq 1BJutrcAjpJYm5q1TUyD+5fr4NzWVxZchalnLEbJpVxBLs/k5Oy22Byq2x5yCjWpn246 YDoxcpjBqNKGquy+QhKabrhiYGfqMjVZlSc8vVpcR8NG52CwWIn/FV07TKjz/GJhyE8n qpbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=7g6llygrv9zMOmxjpX8DM6M5PtpXyu9IH92jo7HTipY=; b=0Ckg9rzQRZPA6ctAaY30Es6Bmx5BT92HkFvrqOpGvZAleWqDOCzqSfAkP3v164bCVj dJerfk5DrkpBq4EkYQSU5JLLzDVhwJ8WZ3g1MrTn+G65+l0qpbouDb9oMlE1TlV/8RLU On+RlOBvI+MPcfrJGlWn4oo5UF4BAZx/HPdVCAno3qZMSwbGXr8C15G95IPhyBzWusKn hOMJ2biKSL/W+n+QvpBSwbL6K7JDF14Wi1RJa27UpSH1PyBDTlS9mlAKN730blzAjm/+ XQeOncm2MbXpYt83NdylS5/cSU3PpYt3SXfPpQBpZPX8JVc4Pygx8WtBIcapiJzPzMIJ TlJA== X-Gm-Message-State: AOAM532t80MSttxV/bqlgTP1G9XJ0Cm/JloGD1M7xzvx7GJWj35/xo7T R2OQ6DF5SBhmadJLvSi9QYHYM/U8DM0= X-Received: by 2002:a17:90a:380f:b0:1bd:4aa6:651 with SMTP id w15-20020a17090a380f00b001bd4aa60651mr16301185pjb.83.1646229518135; Wed, 02 Mar 2022 05:58:38 -0800 (PST) Received: from vpn2.localdomain ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id w5-20020a17090aaf8500b001bd4c825deesm5289672pjq.43.2022.03.02.05.58.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Mar 2022 05:58:37 -0800 (PST) From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Wed, 2 Mar 2022 21:58:31 +0800 Message-Id: <1646229512-12103-1-git-send-email-lance.lmwang@gmail.com> X-Mailer: git-send-email 1.8.3.1 Subject: [FFmpeg-devel] [PATCH 1/2] avformat/movenc: initialize pts/dts/duration of timecode packet X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Limin Wang MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: gVbHtfvnM0CF From: Limin Wang Fix below error message when timecode packet is written. "Application provided duration: -9223372036854775808 / timestamp: -9223372036854775808 is out of range for mov/mp4 format" try to reproduce by: ffmpeg -y -f lavfi -i color -metadata "timecode=00:00:00:00" -t 1 test.mov Note although error message is printed, the timecode packet will be written anyway. So the patch 2/2 will try to change the log level to warning. The first two test case of fate-lavf-ismv have timecode setting, so the crc of ref data is different. Fixes ticket #9488 Signed-off-by: Limin Wang --- libavformat/movenc.c | 2 ++ tests/ref/lavf/ismv | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 4c86891..74b94cd 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -6383,6 +6383,8 @@ static int mov_create_timecode_track(AVFormatContext *s, int index, int src_inde pkt->data = data; pkt->stream_index = index; pkt->flags = AV_PKT_FLAG_KEY; + pkt->pts = pkt->dts = av_rescale_q(tc.start, av_inv_q(rate), (AVRational){1,mov->movie_timescale}); + pkt->duration = av_rescale_q(1, av_inv_q(rate), (AVRational){1,mov->movie_timescale}); pkt->size = 4; AV_WB32(pkt->data, tc.start); ret = ff_mov_write_packet(s, pkt); diff --git a/tests/ref/lavf/ismv b/tests/ref/lavf/ismv index ac7f72b..723b432 100644 --- a/tests/ref/lavf/ismv +++ b/tests/ref/lavf/ismv @@ -1,7 +1,7 @@ -48fb8d7a5d19bd60f3a49ccf4b7d6593 *tests/data/lavf/lavf.ismv +7a24b73c096ec0f13f0f7a2d9101c4c1 *tests/data/lavf/lavf.ismv 313169 tests/data/lavf/lavf.ismv tests/data/lavf/lavf.ismv CRC=0x9d9a638a -d19cd8e310a2e94fe0a0d11c5dc29217 *tests/data/lavf/lavf.ismv +79646383fd099d45ad0d0c2791c601dd *tests/data/lavf/lavf.ismv 322075 tests/data/lavf/lavf.ismv tests/data/lavf/lavf.ismv CRC=0xe8130120 3b6023766845b51b075aed474c00f73c *tests/data/lavf/lavf.ismv