From patchwork Mon Mar 14 15:36:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lance Wang X-Patchwork-Id: 34728 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6838:3486:0:0:0:0 with SMTP id ek6csp2268691nkb; Mon, 14 Mar 2022 08:36:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxulwWZD0KbeXU+CSgG7uKXpXDjndULBaaGWwwXll8fhuI5PJUECRF3+GziRnrZipa4L7rT X-Received: by 2002:a17:906:c259:b0:6ce:a165:cd0d with SMTP id bl25-20020a170906c25900b006cea165cd0dmr18502413ejb.270.1647272193764; Mon, 14 Mar 2022 08:36:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647272193; cv=none; d=google.com; s=arc-20160816; b=im+Y0rRBwwQb8U2lUzK/fbgQH60Iq4THZu/lM1vzdHZhoaPZ2xM+/V8JQTjtL6FD8V OUnLbWVnCXsrlgqOCRAcI5YdSUma8D8etRqUC2vCOZovwWpgokWrQNeTMVLn+cqajYp0 pLmvyILMUoU2aZ8HDBoTjDVL3Gl5Oo0fh9pqc3OdJa0UAgkgogOS6pKEFqW6wjhjmIW+ QArOAgMyJRHlr8zFltw2SpAFAY4zUHlRVB4XVkGtjOsi0pkvH0HrM2uBOG/4awVYFNtl 3yk64pmtd5O68V/6SqlEy1r2MJNgWUETuZ2L0weA8pn3ota92ZuyQ2D9vIFKQtojl7DG PINA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to; bh=K9EqHtXLnFmmKrdIAeTdhqlv3j49kwf7u7ULgEzmJSo=; b=VqjXInFBreCLziKP5WckWK7BrXDwtPrXuWiImwJGhqaQ6v17jP71c3DY9GyvcI1iwj rYwplC1Dqw2BIfFiHr4o7xj/QKxG2N9oF01JJlaT6jjpUO79GbhtsHx+79aBSZ/4+4C0 dee4zgBuGbMG0Zfao94lixWnxHZctztrgkmVvhAilAW8zgpfOAzU7pkic30VudaW047M eiN8o4drcONouT+jNMggW+bZpp5YIeqEjLJsKc1sl+bUUgeqdGSB+LaKiqHyXLUWl1bD H3+SDZJDskpairyeyvm0GdcHNDPz0KNUshaE6ZypRdG6TiD9bvXHaFWGQ3sZdR4IZmlv 5mdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=Pv3oSdZr; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id r10-20020a1709062cca00b006cd3404e99asi9318138ejr.549.2022.03.14.08.36.30; Mon, 14 Mar 2022 08:36:33 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=Pv3oSdZr; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8CE9768AFC9; Mon, 14 Mar 2022 17:36:27 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5490A68A920 for ; Mon, 14 Mar 2022 17:36:21 +0200 (EET) Received: by mail-pf1-f175.google.com with SMTP id a5so14787878pfv.2 for ; Mon, 14 Mar 2022 08:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=OSAt8i2tWpEUcztWnKaxjLxisoqsUppu55uC9rwM+o4=; b=Pv3oSdZrh6CTYVwMWcWbntIBS4FdstmYEATrcII3cqG5AIid2DQ+RSbqQWL6hCCGwV SS0JuF52ED75BJ9l8dpVAvwzxqFgAvqY8Cv8wQliSv5Fgm1qUHZ+1oKRsyhN5bxEW2tG Ryz0pThqKvMj+zpg8tUO0KhViwNH3/wufa/7l3KaumItxlQ/Tg+6IuY3E2UP85oF7hdE RTPTQX/xqW305rtcFmLBmIg39VO630gSa7QpI/XlFtW9wIjXYKvcP3CjNZOEftIfe1D+ I9DDaqDvQhOZQzwybNh9uOzh3jEG9rcBK8rSX6QDuBkET18GEUaSPq0HX88j9+YZhH2h YmJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=OSAt8i2tWpEUcztWnKaxjLxisoqsUppu55uC9rwM+o4=; b=zH9ddWRVzRhrMk1FgaoY9pcvbooLw7PPdfnRnEry0fblyvNCzCA8P+wf592z8+loUT 41bSKm1iF29Q+gq+E1Lu1NGpKlHBMwqPSn07Rykm60vgeuy1XUprXXYaWaLBa4Q9J7Hu wvW9oFE7c/HuQVSrdVaj7AWpCpDLc/IaTkfDxrlPtX3CgmNPY1DbnIbYzgeVxDdLhpAe kwEx+StF1KlGfeoaftAAC22ou8whWKlJmojUcti6ukPWo0R3ZVFV1tavkcJWJoyq5dvk q1ZDTnrXEpS8iglqj/DkvaN6qdKS3yqihNcmuyr2p7rjFx6c00HHkg6/bOr1vNLjUGmz fISQ== X-Gm-Message-State: AOAM533Cp8fI1+KK8N9wLYCEoJNJmG/Eq6ZSkl8uupB0RTIINZ9ZhUgx 5Khp2lA4C+iyCYjxtgndSqp2VbGa7ikOQQ== X-Received: by 2002:aa7:8b13:0:b0:4f0:f393:ec42 with SMTP id f19-20020aa78b13000000b004f0f393ec42mr24645586pfd.6.1647272179359; Mon, 14 Mar 2022 08:36:19 -0700 (PDT) Received: from vpn2.localdomain ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id o3-20020a056a0015c300b004f72b29159csm21954989pfu.159.2022.03.14.08.36.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Mar 2022 08:36:19 -0700 (PDT) From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Mon, 14 Mar 2022 23:36:13 +0800 Message-Id: <1647272174-29686-1-git-send-email-lance.lmwang@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1646229512-12103-1-git-send-email-lance.lmwang@gmail.com> References: <1646229512-12103-1-git-send-email-lance.lmwang@gmail.com> Subject: [FFmpeg-devel] [PATCH v2 1/2] avformat/movenc: initialize pts/dts of timecode packet X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Limin Wang MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: DndDVIA4Hbr3 From: Limin Wang Fix below error message when timecode packet is written. "Application provided duration: -9223372036854775808 / timestamp: -9223372036854775808 is out of range for mov/mp4 format" try to reproduce by: ffmpeg -y -f lavfi -i color -metadata "timecode=00:00:00:00" -t 1 test.mov Note although error message is printed, the timecode packet will be written anyway. So the patch 2/2 will try to change the log level to warning. Fixes ticket #9488 Signed-off-by: Limin Wang --- libavformat/movenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index ee1629d..436ceb8 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -6356,6 +6356,7 @@ static int mov_create_timecode_track(AVFormatContext *s, int index, int src_inde pkt->data = data; pkt->stream_index = index; pkt->flags = AV_PKT_FLAG_KEY; + pkt->pts = pkt->dts = av_rescale_q(tc.start, av_inv_q(rate), (AVRational){1,mov->movie_timescale}); pkt->size = 4; AV_WB32(pkt->data, tc.start); ret = ff_mov_write_packet(s, pkt);